Skip to content

Increase the max size of vhd to 4TB. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 869 commits into from
Closed

Conversation

hyonholee
Copy link

Description

Increase the max size of vhd from 1TB to 4TB for Add-AzureVhd and Add-AzureRmVhd

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

cormacpayne and others added 30 commits May 3, 2017 14:43
Refactor common types for authentication and storage
…hell into release-4.0.0

# Conflicts:
#	src/Common/Commands.Common.Authentication.Abstractions/Properties/AssemblyInfo.cs
#	src/ResourceManager/Common/Commands.Common.Authentication.ResourceManager/Properties/AssemblyInfo.cs
#	src/ResourceManager/Intune/AzureRM.Intune.psd1
#	src/ResourceManager/Profile/Commands.Profile.Test/Properties/AssemblyInfo.cs
#	src/ResourceManager/Scheduler/Commands.Scheduler.Test/Properties/AssemblyInfo.cs
…aly" from the accepted values for "ExcludedDetectionType"
[Release 4.0.0] Update module versions for May release
Correcting the name of the Dogfood environment in readme
Added Test-AzureRmNetworkWatcherConnectivity cmdlet
Fix Copy blob from Uri failure
Cody Mansfield and others added 29 commits May 24, 2017 15:52
Azure Analysis Services: added new sku and scale up/down support
Default was listed as 'None' when it is actually 'Incremental'.
Fixed default value for -Mode parameter
Updating Powershell SDK to include the HTTP APNS 2 changes
Add Unit test to cover New storage Context in different RMprofile and SMProfile combination
Updating getobjectsbyobjectId call for objectIds > 1000
Added a better title to the first example
Update DevTest Lab cmdlets and tests to match current SDK
Update New-AzureRmVirtualNetwork.md
Fix breaking change tool failures during sign job
@hyonholee hyonholee closed this May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.