docs: hammerjs using systemjs.config #10711

Longfld · 2018-04-05T01:14:41Z

sync fork with original

Fixes an error that is being thrown when opening a tooltip, closing it and updating its position.

) Similarly to other controls that are based around an input and a popup, the datepicker should open on alt + down arrow and close on alt + up arrow. The opening logic was already being handled and this PR adds the logic for closing.

…r#10661) Fixes the underlying `MatTabBodyPortal` not cleaning up correctly on destroy, because it overrides the `ngOnDestroy` method from the `CdkPortalOutlet`. Also does some general cleanup around the tab body component.

Moves a timeout, that only has some DOM-related logic, to run outside the `NgZone`.

Moves some duplicated logic for coercing CSS values under `cdk/coercion` and replaces the usages.

…osition with a viewport margin (angular#10650) Fixes the `bottom` value and the viewport margin not being calculated correctly when using the `FlexibleConnectedPositionStrategy` with a flexible height and a viewport margin.

…ngular#10644) Fixes the horizontal stepper cutting off the bottom part of its content due to it having `overflow: hidden`. These changes scope the `overflow` only to when the stepper is collapsed. Fixes angular#10634.

* Fixes all of the RTL selectors being scoped to the badge itself, rather than a parent, which means that consumers would have to set `dir="rtl"` on each individual badge. * Fixes none of the `left`/`right` values being inverted.

…gular#10629) Fixes the width of the autocomplete panel not being recalculated when the viewport size changes.

Fixes a few instances in the `table`, `sort` and `paginator` modules where the spacings weren't being inverted in RTL layouts.

Currently most of the timeouts inside the `FocusMonitor` are run outside the `NgZone`, because they're called from event listeners that are bound on the outside, however the one from `_setOriginForCurrentEventQueue` can still end up inside when it's called by `focusVia`.

…gular#10605) Fixes the button toggle setting the `aria-label` of its underlying input to a blank value by default.

…ngular#10670)

Switches all of the slide toggle unit tests to run in the `fakeAsync` zone, rather than `async`, in order to make them cleaner and more reliable.

googlebot · 2018-04-06T06:44:44Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Longfld · 2018-04-06T06:52:42Z

I confirm that I am ok with my commits being contributed to this project.

googlebot · 2018-05-03T16:22:51Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

josephperrott · 2018-05-03T16:22:58Z

Verified signed CLA.

josephperrott · 2018-05-03T16:23:24Z

@Longfld it looks like you still have some failing tests on CI, can you rebase and push again.

googlebot · 2018-05-03T23:07:59Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Longfld · 2018-05-03T23:22:59Z

@josephperrott
I've got this error, any suggestion where I was wrong? any particular tag I should merge?

"ci/angular: merge status — Missing required labels: "target: *", "cla: yes", forbidden lab"

googlebot · 2018-05-07T15:47:15Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

josephperrott · 2018-05-07T15:47:16Z

You should not need to worry about the ci/angular status as it is mostly made up of checks that are based on the Material team applying labels and such.

Verified signed CLA.

jelbourn

LGTM

angular-automatic-lock-bot · 2019-09-08T22:02:08Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Longfld added 3 commits April 2, 2018 22:22

Remove extra space

7638499

Update getting-started.md

e6df813

minified version for hammerjs

a658bb7

Longfld requested review from amcdnl and jelbourn as code owners April 5, 2018 01:14

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 5, 2018

Longfld and others added 3 commits April 5, 2018 12:09

formatting

672a7b6

Merge remote-tracking branch 'upstream/master'

ac675f5

sync fork with original

update hammerjs

f61298d

Longfld mentioned this pull request Apr 5, 2018

docs: hammerjs using systemjs.config #10653

Closed

Longfld changed the title ~~Bring fork up to date~~ docs: hammerjs using systemjs.config Apr 6, 2018

crisbeto and others added 19 commits April 6, 2018 16:40

fix(tooltip): error when updating position while closed (angular#10704)

bdbb63a

Fixes an error that is being thrown when opening a tooltip, closing it and updating its position.

chore: remove duplicate imports (angular#10692)

59e0db8

fix(tree): fix nested node cannot expand/collapse multiple times (ang…

51a77c9

…ular#10671)

fix(slide-toggle): run timeout outside the NgZone (angular#10655)

4614ebd

Moves a timeout, that only has some DOM-related logic, to run outside the `NgZone`.

feat(coercion): add utility for coercing CSS values (angular#10654)

b9902c2

Moves some duplicated logic for coercing CSS values under `cdk/coercion` and replaces the usages.

fix(datepicker): export MatCalendarHeader (angular#10633)

9202be0

fix(badge): incorrectly handling rtl (angular#10630)

d651aac

* Fixes all of the RTL selectors being scoped to the badge itself, rather than a parent, which means that consumers would have to set `dir="rtl"` on each individual badge. * Fixes none of the `left`/`right` values being inverted.

fix(autocomplete): panel width not being updated on window resize (an…

7703329

…gular#10629) Fixes the width of the autocomplete panel not being recalculated when the viewport size changes.

fix(table,sort,paginator): incorrect spacing in rtl (angular#10617)

de1082f

Fixes a few instances in the `table`, `sort` and `paginator` modules where the spacings weren't being inverted in RTL layouts.

fix(button-toggle): setting blank aria-label attribute by default (an…

a5fe459

…gular#10605) Fixes the button toggle setting the `aria-label` of its underlying input to a blank value by default.

fix(form-field): run change detection when prefix or suffix changes (a…

6bdcd92

…ngular#10670)

docs(readme): update angular material links (angular#10717)

7f545d8

chore: bind devapp to 0.0.0.0 (angular#10714)

ad4f73b

chore: bump version to 6.0.0-rc.1 w/ changelog (angular#10725)

a089b07

crisbeto and others added 4 commits April 6, 2018 16:40

refactor(slide-toggle): switch to fakeAsync tests (angular#10506)

aa9a045

Switches all of the slide toggle unit tests to run in the `fakeAsync` zone, rather than `async`, in order to make them cleaner and more reliable.

docs: add schematics guide (angular#10502)

f7b61ff

chore(tree): fix wrong property used in demo-app (angular#10448)

e469e1a

Merge remote-tracking branch 'upstream/master'

fe2319a

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 6, 2018

josephperrott added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 3, 2018

Merge remote-tracking branch 'upstream/master'

2aff7c8

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 3, 2018

josephperrott added cla: yes PR author has agreed to Google's Contributor License Agreement target: master only and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 7, 2018

josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 7, 2018

jelbourn approved these changes May 9, 2018

View reviewed changes

jelbourn merged commit d4cfea1 into angular:master May 9, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: hammerjs using systemjs.config #10711

docs: hammerjs using systemjs.config #10711

Uh oh!

Longfld commented Apr 5, 2018 •

edited

Loading

Uh oh!

googlebot commented Apr 6, 2018

Uh oh!

Longfld commented Apr 6, 2018

Uh oh!

googlebot commented May 3, 2018

Uh oh!

josephperrott commented May 3, 2018

Uh oh!

josephperrott commented May 3, 2018

Uh oh!

googlebot commented May 3, 2018

Uh oh!

Longfld commented May 3, 2018

Uh oh!

googlebot commented May 7, 2018

Uh oh!

josephperrott commented May 7, 2018

Uh oh!

jelbourn left a comment

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Uh oh!

docs: hammerjs using systemjs.config #10711

docs: hammerjs using systemjs.config #10711

Uh oh!

Conversation

Longfld commented Apr 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Apr 6, 2018

Uh oh!

Longfld commented Apr 6, 2018

Uh oh!

googlebot commented May 3, 2018

Uh oh!

josephperrott commented May 3, 2018

Uh oh!

josephperrott commented May 3, 2018

Uh oh!

googlebot commented May 3, 2018

Uh oh!

Longfld commented May 3, 2018

Uh oh!

googlebot commented May 7, 2018

Uh oh!

josephperrott commented May 7, 2018

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Uh oh!

Longfld commented Apr 5, 2018 •

edited

Loading