Merge blazor-wasm in to master #22296

pranavkm · 2020-05-28T00:10:55Z

No description provided.

* Build against the 3.1.0 AspNetCore The version of the runtime that projects compile against is stamped in to the runtimeconfig.json. In an earlier change, the AspNetCoreRef version was bumped up to 3.1.2 which causes running dotnet dev-serve to fail if you do not have the runtime installed. In addition, the template json allows roll-forwards to major version (5.0 versions) if that's the only version available. We do this with the razor compiler: https://github.com/dotnet/aspnetcore-tooling/blob/master/src/Razor/src/Microsoft.AspNetCore.Razor.Tools/runtimeconfig.template.json

…203.1 (#19017) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20103.1

…18935) Fixes #17316

…213.5 (#19034) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20113.5 - Microsoft.DotNet.GenAPI - 1.0.0-beta.20113.5 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.20113.5

…213.1 (#19039) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20113.1

* Add service worker * Add manifest * Bring back BaselineTest.cs * Add baselines for blazorwasm templates * Add publishing test for PWA template * Baseline fixes * Fix baseline test logic to allow for multi-project outputs * Remove non-blazorwasm baselines, since this branch now only covers blazorwasm * Add test for PWA publish output * Beginning generation of assets manifest * Generate assets manifest including blazor outputs * Tweaks * Write assets manifest in JSON form * Publish service worker * Better API * More resilience * Better API again * Make ComputeBlazorAssetsManifestItems public as people will need to customize the list * Exclude service worker files from assets manifest * Use web standard format for hash * Update project template * In assets manifest, only include items being published * Renames * Compute default assets manifest version by combining hashes * Emit sw manifest in .js form * Update service worker in project * Actually isolate browser instances when requested during E2E tests * E2E test for published PWA operating offline * Fix SWAM path in template * Clarify targets

when attempting to enable client debugging on blazor-wasm an attempt to provide a helpful message casues an ¨Unknown OS platform¨ exception relates to #16366 #12970

* Adds a Microsoft.AspNetCore.Components.WebAssembly.Authentication library for performing authentication in Blazor webassembly. * Includes a default implementation that supports OIDC capable IdPs using oidc-client.js * Includes multiple primitives to deal with authentication flows and supports acquiring access tokens to call APIs. * RemoteAuthenticatorView is responsible for handling authentication operations at the user interface level. * RemoteAuthenticatorService is responsible for handling the lower level authentication details by using JavaScript interop to interact with the underlying javascript library implementing the auth protocol. * SignOutSessionStateManager handles CSRF protection for the logout path. * IAccessTokenProvider handles provisioning access tokens to call APIs.

* [Blazor] Adds a project template option for individual auth * Handles hosted scenarios with Identity Server. * Handles non-hosted scenarios with oidc-client.js. * Handles AAD and B2C scenarios with an MSAL library (disabled for now).

Fixes #18384

* Adds additional scenarios to address #17011 * Include commit hash so we can track the build of Blazor WASM associated with a perf run * Port some infrastructure fixes from master Fixes #17011

* Make the dev-server log less * Allow loading a user configured settings file

* [Blazor] Move Blazor to use Static Web Assets * Plugs-in Blazor wasm through the static web assets infrastructure. * Avoids the need for a custom Blazor.config file. * Removes broken auto-rebuild and debug support. * Removes unnecessary server-side Blazor helpers.

* Rename Blazor.Mono -> Components.WebAssembly.Runtime

* Update launchSettings.json for BlazorWASM * Remove the `useWebAssemblyDebugging` setting as its no longer needed

…219.1 (#19167) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.1

…219.2 (#19169) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.2

Move to MapBlazorWebAssemblyApplication as the way to map blazor files into a hosted application.

…19119) * [Blazor][Wasm] Move HttpClient from default services to extension method (#16929) * Apply suggestions from code review Co-authored-by: Steve Sanderson <[email protected]>

…220.1 (#19210) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20120.1

* Add a scenario for measuring navigating between components * Apply suggestions from code review Co-authored-by: Steve Sanderson <[email protected]> Co-authored-by: Steve Sanderson <[email protected]>

…/merge-blazor-wasm

* Fixup JS * Avoid monkey patching

* Undo overzealous merge choices * Undo temporary changes applied when part of the repo was building in the blazor-wasm branch * Skip SPA template tests in 3.1

* Fix logging config and output redirection in DebugProxy * Log all messages from DebugProxy

* Cleanup bad merge * Update to dotnet-serve that supports arbitrary ports

pranavkm · 2020-05-29T01:50:06Z

592dfe1 has most of the master specific changes.

pranavkm · 2020-05-29T01:50:48Z

.config/dotnet-tools.json

@@ -3,7 +3,7 @@
  "isRoot": true,
  "tools": {
    "dotnet-serve": {
-      "version": "1.5.0",
+      "version": "1.7.125",


This version supports assigning dotnet-serve a random port.

pranavkm · 2020-05-29T01:51:10Z

global.json

@@ -11,6 +11,12 @@
      ],
      "dotnet/x86": [
        "$(MicrosoftNETCoreAppInternalPackageVersion)"
+      ],
+      "aspnetcore/x64": [


dotnet-serve doesn't roll forward to a 5.0 runtime.

pranavkm · 2020-05-29T01:52:49Z

src/ProjectTemplates/Shared/DevelopmentCertificate.cs

+{
+    public readonly struct DevelopmentCertificate
+    {
+        public DevelopmentCertificate(string certificatePath, string certificatePassword, string certificateThumbprint)


FYI @javiercn

pranavkm · 2020-05-29T01:53:25Z

...tes/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/.template.config/template.json

+    "09732173-2cef-46b7-83db-1334bcb079d3", // Tenant ID
+    "53bc9b9d-9d6a-45d4-8429-2a2761773502" // Client ID
+  ],
+  "identity": "Microsoft.Web.Blazor.Wasm.CSharp.5.0",


FYI @phenning

wtgodbe · 2020-05-29T17:26:17Z

eng/Baseline.xml

@@ -36,6 +37,12 @@ Update this list when preparing for a new patch.
  <Package Id="Microsoft.AspNetCore.Components.Authorization" Version="3.1.4" />
  <Package Id="Microsoft.AspNetCore.Components.Forms" Version="3.1.4" />
  <Package Id="Microsoft.AspNetCore.Components.Web" Version="3.1.4" />
+  <Package Id="Microsoft.AspNetCore.Components.WebAssembly" Version="3.2.0" />


Can the 3.2.0-preview1 versions above be removed?

Yes. Let me get this in and I'll follow up with a clean up

wtgodbe

Looks good other than the 1 question (which might also apply to the 3.1 PR)

dougbu · 2020-06-01T05:04:57Z

.azure/pipelines/blazor-daily-tests.yml

@@ -0,0 +1,59 @@
+# Uses Scheduled Triggers, which aren't supported in YAML yet.


Scheduled triggers are supported in YAML. Suggest folllowing up to move the configuration from AzDO to here and to explicitly exlude other executions of this pipeline e.g.

pr: none trigger: none schedules: - cron: "0 */12 * * *" branches: include: - master always: true

dougbu · 2020-06-01T05:16:21Z

eng/Version.Details.xml

@@ -9,9 +9,9 @@
 -->
 <Dependencies>
  <ProductDependencies>
-    <Dependency Name="Microsoft.AspNetCore.Blazor.Mono" Version="3.2.0-preview1.20067.1">
+    <Dependency Name="Microsoft.AspNetCore.Components.WebAssembly.Runtime" Version="3.2.0">
      <Uri>https://github.com/dotnet/blazor</Uri>


When will dotnet/blazor no longer be used?

dougbu · 2020-06-01T05:36:24Z

src/Components/Directory.Build.targets

+      the package with IncludeAssets="compile".
+    -->
+    <ItemGroup>
+      <_HttpHandlerAssembly Include="@(_BlazorUserRuntimeAssembly)"


What reads @(_HttpHandlerAssembly) items?

pranavkm and others added 30 commits February 12, 2020 14:20

Only update the dev-server

fd9f203

Update dependencies from https://github.com/dotnet/blazor build 20200…

074f8fa

…203.1 (#19017) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20103.1

No-op if ValidateComplexType is validated without the right context (#…

fb50111

…18935) Fixes #17316

Update dependencies from https://github.com/dotnet/arcade build 20200…

75ca750

…213.5 (#19034) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20113.5 - Microsoft.DotNet.GenAPI - 1.0.0-beta.20113.5 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.20113.5

Update dependencies from https://github.com/dotnet/blazor build 20200…

52f4636

…213.1 (#19039) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20113.1

allow valid error message to be displayed on linux (#18997)

8fb412e

when attempting to enable client debugging on blazor-wasm an attempt to provide a helpful message casues an ¨Unknown OS platform¨ exception relates to #16366 #12970

Remove ProjectTemplates ownership (#19066)

e0fe30c

Cache assemblies and wasm using content hashes (#18859)

4628dfb

Blazor WebAssembly package renames (#19026)

c935e9a

Fixes #18384

Rename Blazor.Mono -> Components.WebAssembly.Runtime

e521205

Add a perf scenario involing nested components + editing

31f63d9

* Adds additional scenarios to address #17011 * Include commit hash so we can track the build of Blazor WASM associated with a perf run * Port some infrastructure fixes from master Fixes #17011

Make the dev-server log less (#18971)

92409e2

* Make the dev-server log less * Allow loading a user configured settings file

Update WASM Runtime

d90f5ef

Fixup

52c4598

Fix token in PWA manifest

38f3267

Rename Blazor.Mono -> Components.WebAssembly.Runtime (#19124)

1dfbe75

* Rename Blazor.Mono -> Components.WebAssembly.Runtime

Use RTM version of the SDK (#19130)

ffc7279

Update launchSettings.json for BlazorWASM (#19136)

6342a81

* Update launchSettings.json for BlazorWASM * Remove the `useWebAssemblyDebugging` setting as its no longer needed

Update dependencies from https://github.com/dotnet/blazor build 20200…

2f6938e

…219.1 (#19167) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.1

Update dependencies from https://github.com/dotnet/blazor build 20200…

09ee6a7

…219.2 (#19169) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.2

[Blazor] Move to MapBlazorWebAssemblyApplication (#19147)

c39bc6a

Move to MapBlazorWebAssemblyApplication as the way to map blazor files into a hosted application.

Only the PWA template should produce ServiceWorkerAssetsManifest

e9ccd7f

[Blazor][Wasm] Move HttpClient from default services to Program.Main (#…

6a85855

…19119) * [Blazor][Wasm] Move HttpClient from default services to extension method (#16929) * Apply suggestions from code review Co-authored-by: Steve Sanderson <[email protected]>

Workaround CacheStorage API bug

06def5c

Update dependencies from https://github.com/dotnet/blazor build 20200…

c5f5325

…220.1 (#19210) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20120.1

pranavkm and others added 10 commits May 11, 2020 10:46

Add a scenario with timers (#19626)

158126c

* Add a scenario for measuring navigating between components * Apply suggestions from code review Co-authored-by: Steve Sanderson <[email protected]> Co-authored-by: Steve Sanderson <[email protected]>

Merge commit 'bbafecc0535e1de3264845e51ea8b3d18eb3ca61' into prkrishn…

8966415

…/merge-blazor-wasm

Merge commit '96db48550802b5db8f32bdc05ed0b805a9e66ef7' into prkrishn…

bb0f54f

…/merge-blazor-wasm

Merge branch 'blazor-wasm' into prkrishn/merge-blazor-wasm

8efeefb

Fixup JS (#21922)

9949ab4

* Fixup JS * Avoid monkey patching

Changes to allow building in 3.1 branch

ae2017f

* Undo overzealous merge choices * Undo temporary changes applied when part of the repo was building in the blazor-wasm branch * Skip SPA template tests in 3.1

Quality of life improvements

8100720

Listen to the internet

53edc76

Fix logging config and output redirection in DebugProxy (#22157)

0394a45

* Fix logging config and output redirection in DebugProxy * Log all messages from DebugProxy

Merge blazor-wasm in to master

4c50b6c

pranavkm force-pushed the prkrishn/merge-into-master branch 3 times, most recently from 6299a84 to b3292fe Compare May 28, 2020 17:21

Pilchie added the area-blazor Includes: Blazor, Razor Components label May 28, 2020

pranavkm force-pushed the prkrishn/merge-into-master branch from b3292fe to 276b6eb Compare May 28, 2020 19:50

Changes to build in master

592dfe1

* Cleanup bad merge * Update to dotnet-serve that supports arbitrary ports

pranavkm force-pushed the prkrishn/merge-into-master branch from 276b6eb to 592dfe1 Compare May 28, 2020 22:44

pranavkm marked this pull request as ready for review May 29, 2020 01:45

pranavkm requested review from dougbu and SteveSandersonMS as code owners May 29, 2020 01:45

pranavkm requested a review from a team May 29, 2020 01:45

pranavkm commented May 29, 2020

View reviewed changes

wtgodbe reviewed May 29, 2020

View reviewed changes

wtgodbe approved these changes May 29, 2020

View reviewed changes

pranavkm merged commit 78d6ce2 into master May 29, 2020

pranavkm deleted the prkrishn/merge-into-master branch May 29, 2020 17:37

pranavkm mentioned this pull request May 29, 2020

Change the identity of the BlazorWasm template when merging in to master #21597

Closed

dougbu mentioned this pull request Jun 6, 2020

Fix warning "Component Governance detected 5 security related alerts at or above 'High' severity." #22252

Closed

dougbu reviewed Jun 7, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge blazor-wasm in to master #22296

Merge blazor-wasm in to master #22296

Uh oh!

pranavkm commented May 28, 2020

Uh oh!

pranavkm commented May 29, 2020

Uh oh!

pranavkm May 29, 2020

Uh oh!

pranavkm May 29, 2020

Uh oh!

pranavkm May 29, 2020

Uh oh!

javiercn May 29, 2020

Uh oh!

pranavkm May 29, 2020

Uh oh!

wtgodbe May 29, 2020

Uh oh!

pranavkm May 29, 2020

Uh oh!

wtgodbe left a comment

Uh oh!

dougbu Jun 1, 2020

Uh oh!

dougbu Jun 1, 2020

Uh oh!

dougbu Jun 1, 2020

Uh oh!

Uh oh!

		@@ -0,0 +1,59 @@
		# Uses Scheduled Triggers, which aren't supported in YAML yet.

Merge blazor-wasm in to master #22296

Merge blazor-wasm in to master #22296

Uh oh!

Conversation

pranavkm commented May 28, 2020

Uh oh!

pranavkm commented May 29, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wtgodbe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!