Merge release/2.1 #8448
Merged
Merge release/2.1 #8448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add some additional logging to ErrorPageMiddlewareWebSite DeveloperExceptionMiddleware will log an error if rendering the exception page throws. The test failure in https://github.com/aspnet/AspNetCore-Internal/issues/1730 suggests that we encountered an error like so but do not have anything further to go by. This change adds logging to the test so we could identify possible issues
* Restore testassets during build to prevent timeouts Fixes https://github.com/aspnet/AspNetCore-Internal/issues/1695
Possible fix to #7313 One of the characteristics of these failures were that the test took long to run. The build log has warnings for several long running tests. This might be a result of CPU contention since mondo-ification that make MVC's functional tests run with nearly every other test project in the solution
- shipped in the past patch
dougbu
suggested changes
Mar 12, 2019
There was a problem hiding this comment.
Please hold off on this until I get the queue changes into release/2.2. You're backing those changes out while making it seem as if they're already in this branch.
I'll be updating #7920 to install Chrome and that one working after lunch.
pranavkm
force-pushed
the
prkrishn/merge/2.1
branch
2 times, most recently
from
499cc96 to
47698fe
Compare
pranavkm
force-pushed
the
prkrishn/merge/2.1
branch
from
47698fe to
7557cb9
Compare
|
:update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.