Merge version-2.0.0-dev into master #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update support lib
Signed-off-by: Alex Saveau <[email protected]>
Update dependencies
Finish the KickOffActivity on dialog tap outside
Signed-off-by: Alex Saveau <[email protected]>
…Changed # Conflicts: # database/src/main/java/com/firebase/ui/database/FirebaseIndexArray.java
Support Facebook Login without email
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Logout of Twitter
Fix NPE if status message is null in SignInDelegate
Change-Id: I1b07ed83741832730b4277dd65934cdf11d658db
Change-Id: I20b9ee9c24180f8de19f030371541922d0f10104
Change-Id: I9928978e188599c852f675453f59ce624bc9602d
Change-Id: I6d2bedb15d96f39e3d3e71682e33388fa41f3439
We upgrade to twitter kit 3.0 and achieve the following 1. No more fabric deps. This shaves our sdk down even more and clears related bugs. 2. We use only twitter core and not other deps. Shaves even more. Total savings: 0.6 MB Change-Id: I64ae5b6c7e2f238c35e25d6b2a2b7089431a3a0a
Change-Id: I57574ae9e376e3c576218b4e18e16ad914a6c496
Problem: Apps are currently required to add the facebook and twitter dependency even if they do not require these login methods to be supported. Solution: In this change, we assume a provided scope dependency on facebook and twitter sdks and expect that the apps provide these dependencies. If these dependencies are not found, we fail early with an actionable error. Also, the size of the resulting apk reduces by about 2MB. Change-Id: I5979039c281dd6daca265f60f9c9dcf59596ced1
Bug: 62309027 Change-Id: Iccbdb2a34e8c0b14c6fcf186005e0f1a68ea180e
Change-Id: Ib18e49c565e39c30bba83333aa8188fc853e1775
Change-Id: I5ff1752f718b91602020147a91fe56691b09318f
Change-Id: I0b884bdbe5e62713dc3a4edca8539cace74f3f18
Change-Id: If1686bde8906f2e06d87c51fb8399be0b960028d
Change-Id: I6eac4c2e92c13b1e5ad9a2953441566ad2d7c29e
Merge phone auth into version-2.0.0
Change-Id: Ib65f67b63052ee3a0cf542a38931610208abbd9f
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting this now to make sure the build is OK. This can be amended if #448 gets included.