Skip to content

devbox.findPackagesByName should be constructed from Config packages #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

savil
Copy link
Collaborator

@savil savil commented Aug 10, 2023

Summary

This PR refactors devbox.findPackagesByName to be constructed from devconfig.Package.

Motivation
devbox.Update calls findPackageByName and needs to call devbox.Add again with the Platform and ExcludedPlatforms. (see #1370)

How was it tested?

compiles

@savil savil force-pushed the savil/findPackagesByName branch from 7442274 to 6e0b77c Compare August 11, 2023 22:18
@savil savil force-pushed the savil/config-pkg-to-devpkg branch from 9bbc3dc to 3ba264f Compare August 11, 2023 22:36
@savil savil force-pushed the savil/findPackagesByName branch 2 times, most recently from ff1c36e to 7e4cebf Compare August 11, 2023 22:46
@savil
Copy link
Collaborator Author

savil commented Aug 11, 2023

All tests pass. Going to land the parent PR, rebase and force-land.

Base automatically changed from savil/config-pkg-to-devpkg to main August 11, 2023 23:05
@savil savil force-pushed the savil/findPackagesByName branch from 7e4cebf to ea87c15 Compare August 11, 2023 23:05
@savil savil merged commit dd6d815 into main Aug 11, 2023
@savil savil deleted the savil/findPackagesByName branch August 11, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants