-
Notifications
You must be signed in to change notification settings - Fork 249
[per-OS Packages] fix devbox update for unversioned packages with platform/excluded-platform #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
mikeland73
approved these changes
Aug 11, 2023
c15183c
to
5191dfb
Compare
7b8aeb4
to
0b85c46
Compare
5191dfb
to
f69b9f3
Compare
0b85c46
to
2bd855b
Compare
f69b9f3
to
b54fd8e
Compare
2bd855b
to
7a0c8d5
Compare
b54fd8e
to
7866592
Compare
7a0c8d5
to
44a9518
Compare
7866592
to
19fb40c
Compare
44a9518
to
7e8866b
Compare
19fb40c
to
b6e2aca
Compare
7e8866b
to
a6e4c41
Compare
b6e2aca
to
e216027
Compare
a6e4c41
to
f4f1e5f
Compare
e216027
to
e5d2bfa
Compare
f4f1e5f
to
c5d63c9
Compare
e5d2bfa
to
3fc324b
Compare
c5d63c9
to
d0b96db
Compare
3fc324b
to
4037aa2
Compare
d0b96db
to
ecf3d2c
Compare
4037aa2
to
fc76ec0
Compare
ecf3d2c
to
02b4ab8
Compare
…tform/excluded-platform
02b4ab8
to
5e7b6fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a slightly edge-casey workflow:
devbox shell
withglibcLocales
in devbox.json. Note: unversioned package.devbox add glibcLocales --exclude-platforms x86_64-darwin
devbox update
.devbox update
.This should work, but was previously broken for two reasons:
update.go
, we were callingdevbox.Add
withnil
for platforms and excluded_platforms.devbox.Add
, we checkversionedPkg.ValidateExists()
prior to converting the raw package name to the versioned-name.Both are now fixed.
How was it tested?
Ran the workflow described above. It's hard to write a testscript unit-test, since
some packages build may or may not build on whichever system is running the unit-test. And mocking is too complicated here.