[per-OS Packages] in devbox add, allow multiple --platform/--exclude-platform flag values #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
2 tasks
savil
requested review from
mikeland73 and
gcurtis
and removed request for
mikeland73
savil
changed the title
mikeland73
approved these changes
Aug 11, 2023
internal/devconfig/packages.go
Outdated
| if len(platforms) == 0 { | ||
| return nil | ||
| } | ||
| for _, platform := range platforms { |
There was a problem hiding this comment.
Make nix.EnsureValidPlatform take ...string ?
internal/devconfig/packages.go
Outdated
Comment on lines
78
to
81
| for _, platform := range platforms { | ||
| // Append if the platform is not already present | ||
| if !lo.SomeBy(pkg.Platforms, func(p string) bool { return p == platform }) { | ||
| pkg.Platforms = append(pkg.Platforms, platform) |
There was a problem hiding this comment.
pkg.Platforms = lo.Uniq(append(pkg.Platforms, platforms...))
internal/devconfig/packages.go
Outdated
| if existing == platform { | ||
| alreadyPresent = true | ||
| break | ||
| for _, platform := range platforms { |
| @@ -34,7 +34,7 @@ func (d *Devbox) Update(ctx context.Context, pkgs ...string) error { | |||
| // Calling Add function with the original package names, since | |||
| // Add will automatically append @latest if search is able to handle that. | |||
| // If not, it will fallback to the nixpkg format. | |||
| if err := d.Add(ctx, "" /*platform*/, "" /*excludePlatform*/, pkg.Raw); err != nil { | |||
| if err := d.Add(ctx, nil /*platforms*/, nil /*excludePlatforms*/, pkg.Raw); err != nil { | |||
There was a problem hiding this comment.
we fill these in next PR
savil
force-pushed
the
savil/config-packages-2
branch
from
81606cd to
0dbee1d
Compare
savil
force-pushed
the
savil/config-packages-3
branch
from
f65133a to
8790b47
Compare
savil
force-pushed
the
savil/config-packages-2
branch
from
0dbee1d to
25122b6
Compare
savil
force-pushed
the
savil/config-packages-3
branch
from
8790b47 to
1453300
Compare
savil
force-pushed
the
savil/config-packages-2
branch
from
25122b6 to
7f2bc7a
Compare
savil
force-pushed
the
savil/config-packages-3
branch
from
1453300 to
af97428
Compare
savil
force-pushed
the
savil/config-packages-2
branch
from
7f2bc7a to
fbba263
Compare
savil
force-pushed
the
savil/config-packages-3
branch
from
af97428 to
d8304fd
Compare
savil
force-pushed
the
savil/config-packages-2
branch
from
fbba263 to
8bf71ad
Compare
savil
force-pushed
the
savil/config-packages-3
branch
3 times, most recently
from
e0f4a8b to
a9bec28
Compare
…platform flag values
… for this package
savil
force-pushed
the
savil/config-packages-3
branch
from
a9bec28 to
fe32133
Compare
savil
commented
Aug 18, 2023
| @@ -34,7 +34,7 @@ func (d *Devbox) Update(ctx context.Context, pkgs ...string) error { | |||
| // Calling Add function with the original package names, since | |||
| // Add will automatically append @latest if search is able to handle that. | |||
| // If not, it will fallback to the nixpkg format. | |||
| if err := d.Add(ctx, "" /*platform*/, "" /*excludePlatform*/, pkg.Raw); err != nil { | |||
| if err := d.Add(ctx, nil /*platforms*/, nil /*excludePlatforms*/, pkg.Raw); err != nil { | |||
There was a problem hiding this comment.
we fill these in next PR
internal/devconfig/packages.go
Outdated
| if len(platforms) == 0 { | ||
| return nil | ||
| } | ||
| for _, platform := range platforms { |
internal/devconfig/packages.go
Outdated
Comment on lines
78
to
81
| for _, platform := range platforms { | ||
| // Append if the platform is not already present | ||
| if !lo.SomeBy(pkg.Platforms, func(p string) bool { return p == platform }) { | ||
| pkg.Platforms = append(pkg.Platforms, platform) |
internal/devconfig/packages.go
Outdated
| if existing == platform { | ||
| alreadyPresent = true | ||
| break | ||
| for _, platform := range platforms { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables calling
--platformwith multiple values withdevbox add.It gives the user an option to user either or both (1) comma-separated flag values (2) multiple flag invocations. Like:
--platform <platform>,<platform>...,<platform> --platform <platform> --platform <platform>Ditto for
--exclude-platformHow was it tested?
Augmented testscript unit test