Prepare v0.6.2 #1094
Merged
Prepare v0.6.2 #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vince Prignano <[email protected]>
* better UserAgent for leader-election client * fixup
As a part of cleaning up inactive members (who haven't been active since the release of v1.11) from OWNERS, this commit removes totherme from the OWNERS_ALIASES file.
🏃 Run tests with race detector enabled
Remove inactive members from OWNERS_ALIASES
Co-authored-by: david.benque <[email protected]>
✨ optionally override leader election client config
✨ pkg/predicate.go: add And and Or predicates
According to onsi/ginkgo#280 this doesn't seem to be properly supported. If we want parallelization, we should use ginkgos built-in mechanism for that.
🏃 Disable golangs parallel testing
Signed-off-by: Vince Prignano <[email protected]>
✨ Add IsZero method to reconcile.Result
✨ Implement graceful shutdown
🐛 Prefer reconciler from controller.Options
Signed-off-by: Vince Prignano <[email protected]>
🌱 Remove -parallel flag from test coverage
🏃 Make alvaroaleman approver
✨ Implement NewPredicateFuncs to create predicate functions from a filter function
…vels (#991) * Fix zap levels to align with logr * Fix sampling logic for debug levels
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
Remove coverage when running tests
Mark leak goroutine tests as pending
k8s-ci-robot
added
size/XXL
|
/retest |
|
/lgtm Feel free to cancel the hold when this is complete already |
k8s-ci-robot
added
the
lgtm
✨ Add ability to set/get logger in/from a context.Context
k8s-ci-robot
removed
the
lgtm
🏃 Generate junit in CI
Signed-off-by: Vince Prignano <[email protected]>
✨ Add options to configure a logger for manager and controllers
Signed-off-by: Vince Prignano <[email protected]>
Update dependencies to Kubernetes v1.18.6
Currently every webhook requests ended up logging this in debug:
```
2020-06-10T16:04:20.883+0200 DEBUG controller-runtime.webhook.webhooks wrote response {"webhook": "/validate-some-resource", "UID": "e5d00608-7f47-4d00-bd91-b1a8955dc5a7", "allowed": true, "result": {}, "resultError": "got runtime.Object without object metadata: &Status{ListMeta:ListMeta{SelfLink:,ResourceVersion:,Continue:,RemainingItemCount:nil,},Status:,Message:,Reason:,Details:nil,Code:200,}"}
```
The problem is that a `Status` Object is a runtime.Object but which has no metadata which is not well received the `KubeAwareEncoder`.
Signed-off-by: Fabian Ruff <[email protected]>
When a named readiness/liveness check is registered it should be available under /readyz/<name>.
✨ Make individual readiness and liveness checks accessible
🐛 Avoid marshalling error in debug log line
|
/test pull-controller-runtime-apidiff-release-0-6 |
🏃 hack/setup-envtest.sh: follow-up from #1092
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Change other/minor emoji for PRs to 🌱
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.