[AMDGPU] Correct pass dependencies for SILowerSGPRSpills

[optimisan]

Replace unused analysis (VirtRegMap) dependency with the used one (SlotIndexes)
Initializes SlotIndexesWrapperPass which is used by SILowerSGPRSpills to ensure that legacy pass manager finds it.
Removes the initialization for VirtRegMapWrapperPass since it is not requested in this pass.

[optimisan]

• [NewPM][AMDGPU] Port SIPreAllocateWWMRegs to NPM #109939
• [AMDGPU] Add tests for SIPreAllocateWWMRegs #109963
• [NewPM][CodeGen] Port LiveRegMatrix to NPM #109938
• [CodeGen] LiveIntervalUnions::Array Implement move constructor #111357
• [AMDGPU] Correct pass dependencies for SILowerSGPRSpills #109937 👈
• [NewPM][CodeGen] Port VirtRegMap to NPM #109936
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @optimisan and the rest of your teammates on Graphite

[llvmbot]

@llvm/pr-subscribers-backend-amdgpu

Author: Akshat Oke (Akshat-Oke)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/109937.diff

1 Files Affected:

• (modified) llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp (+1-1)

diff --git a/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp b/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
index d385261184e718..dcdac5a0942ab4 100644
--- a/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
+++ b/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
@@ -83,7 +83,7 @@ char SILowerSGPRSpillsLegacy::ID = 0;
 INITIALIZE_PASS_BEGIN(SILowerSGPRSpillsLegacy, DEBUG_TYPE,
                       "SI lower SGPR spill instructions", false, false)
 INITIALIZE_PASS_DEPENDENCY(LiveIntervalsWrapperPass)
-INITIALIZE_PASS_DEPENDENCY(VirtRegMapWrapperPass)
+INITIALIZE_PASS_DEPENDENCY(SlotIndexesWrapperPass)
 INITIALIZE_PASS_END(SILowerSGPRSpillsLegacy, DEBUG_TYPE,
                     "SI lower SGPR spill instructions", false, false)
 

[arsenm]

Description needs to be more specific

[arsenm]

Description needs to be more specific

Bump

[optimisan]

ping

[arsenm]

ping

Fix the description

[optimisan]

Also updated in PR.
Initializes correct dependency as VirtRegMapWrapper is unused here

[arsenm]

Description still not fixed

[optimisan]

I think this describes it better?

[optimisan]

Merge activity

• Oct 22, 5:41 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Oct 22, 5:48 AM EDT: Graphite rebased this pull request as part of a merge.
• Oct 22, 5:50 AM EDT: A user merged this pull request with Graphite.