Fix spacing in tarfile docs #20601

HarshaLaxman · 2020-06-02T22:34:54Z

Before

content.txt is 42 bytes in size and isa regular file.
folder is 420 bytes in size and isa directory.
magic is 4200 bytes in size and issomething else.

After:

content.txt is 42 bytes in size and is a regular file.
folder is 420 bytes in size and is a directory.
magic is 4200 bytes in size and is something else.

GH- [bpo-39128](https://bugs.python.org/issue39128): happy eyeballs description GH- [3.9] 39128 - happy eyeballs description (GH-18624) GH- [3.8] 39128 - happy eyeballs description (GH-18624) https://bugs.python.org/issue39128 (cherry picked from commit 8af4712) Co-authored-by: idomic <[email protected]>

Trying to decode an invalid string with the punycode codec shoud raise UnicodeError. (cherry picked from commit ba22e8f) Co-authored-by: Berker Peksag <[email protected]>

Python 3.8.2

…GH-18657) (cherry picked from commit d644891) Co-authored-by: Steve Dower <[email protected]>

(cherry picked from commit 57c7a0b) Co-authored-by: Inada Naoki <[email protected]>

Co-authored-by: Ammar Askar <[email protected]>

Previously, the button-up part of selecting with a mouse was treated as a click that meant 'jump' to this line, which modified the context and undid the selection (cherry picked from commit c705fd1) Co-authored-by: Terry Jan Reedy <[email protected]>

(cherry picked from commit 916895f) Co-authored-by: Terry Jan Reedy <[email protected]>

…8598) (cherry picked from commit c2f7eb2) Co-authored-by: Shantanu <[email protected]>

Also fixes some potential Nuget build issues. (cherry picked from commit 03153dd) Co-authored-by: Steve Dower <[email protected]>

…H-18338) * bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest authentication - The 'qop' value in the 'WWW-Authenticate' header is optional. The presence of 'qop' in the header should be checked before its value is parsed with 'split'. Signed-off-by: Stephen Balousek <[email protected]> * bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest authentication - Add NEWS item Signed-off-by: Stephen Balousek <[email protected]> * Update Misc/NEWS.d/next/Library/2020-02-06-05-33-52.bpo-39548.DF4FFe.rst Co-Authored-By: Brandt Bucher <[email protected]> Co-authored-by: Brandt Bucher <[email protected]> (cherry picked from commit 5e260e0) Co-authored-by: Stephen Balousek <[email protected]>

(cherry picked from commit 815280e)

Fix compileall.compile_dir() ddir= behavior on sub-packages. Fixes compileall.compile_dir's ddir parameter and compileall command line flag `-d` to no longer write the wrong pathname to the generated pyc file for submodules beneath the root of the directory tree being compiled. This fixes a regression introduced with Python 3.5. Tests backported from GH 0267335, the implementation is different due to intervening code changes. But still quiet simple. Why was the bug ever introduced? The refactoring to add parallel execution kept the ddir -> dfile computations but discarded the results instead of sending them to compile_file(). This fixes that. Lack of tests meant this went unnoticed.

@pablogsal

Automerge-Triggered-By: @pablogsal. (cherry picked from commit 217dce9) Co-authored-by: Hakan Çelik <[email protected]>

(cherry picked from commit 1f577ce) Co-authored-by: Hai Shi <[email protected]>

…ered with exception raised. (GH-18656). (GH-18732) (cherry picked from commit 28d0bca)

_PyEval_SetAsyncGenFinalizer() and _PyEval_SetAsyncGenFirstiter() didn't include proper error handling for their PySys_Audit() calls. Co-authored-by: Zackery Spytz <[email protected]>

…-17666) Open issue in the BPO indicated a desire to make the implementation of codecs.open() at parity with io.open(), which implements a try/except to assure file stream gets closed before an exception is raised. (cherry picked from commit 2565ede) Co-authored-by: Chris A <[email protected]>

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 4482337) Co-authored-by: Lidi Zheng <[email protected]>

@zooba

Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <[email protected]>

…_traverse and tp_clear (GH-18749) (GH-18756) Objects do not own weak references to them directly through the __weakref__ list so these do not need to be traversed by the GC. (cherry picked from commit 0c2b509)

…dows (GH-18724) (cherry picked from commit ce3a498) Co-authored-by: Steve Dower <[email protected]>

…H-18761) (cherry picked from commit 2d2f855) Co-authored-by: Serhiy Storchaka <[email protected]>

@pablogsal

Automerge-Triggered-By: @pablogsal (cherry picked from commit 6df421f) Co-authored-by: Pablo Galindo <[email protected]>

…#18752) - Threads created by PyGILState_Ensure() could have a duplicate tstate->id. (cherry picked from commit b3b9ade)

…) (GH-20092) Backporting to 3.8 and adding a NEWS item (I should have added one to the master branch -- oh well).

(cherry picked from commit c610d97) Co-authored-by: Erlend Egeberg Aasland <[email protected]>

Leave selection when right click within. This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d. I did not realize that this completely disabled the context menu entries, and I should have merged a minimal fix immediately. An automated test should follow. (cherry picked from commit 97e4e0f) Co-authored-by: Terry Jan Reedy <[email protected]>

…GH-20149) Reference to PySide has been removed has it is for Qt 4, which has reached end of life. (cherry picked from commit 4649202) Co-authored-by: Samuel Gaist <[email protected]>

…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <[email protected]>

Fix :mod:`ssl`` code to be compatible with OpenSSL 1.1.x builds that use ``no-deprecated`` and ``--api=1.1.0``. Note: Tests assume full OpenSSL API and fail with limited API. Signed-off-by: Christian Heimes <[email protected]> Co-authored-by: Mark Wright <[email protected]> (cherry picked from commit a871f69) Co-authored-by: Christian Heimes <[email protected]>

(cherry picked from commit c896666) Co-authored-by: Zackery Spytz <[email protected]>

(cherry picked from commit fe5dd78) Co-authored-by: Steve Dower <[email protected]>

Before ``` content.txt is 42 bytes in size and isa regular file. folder is 420 bytes in size and isa directory. magic is 4200 bytes in size and issomething else. ``` After: ``` content.txt is 42 bytes in size and is a regular file. folder is 420 bytes in size and is a directory. magic is 4200 bytes in size and is something else. ```

the-knights-who-say-ni · 2020-06-02T22:34:58Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@HarshaLaxman

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

remilapeyre

Hi @HarshaLaxman, thanks for contributing to Python!

Like @the-knights-who-say-ni said, you will need to sign the CLA so that this contribution can be accepted in Python. You can follow the steps given in the Python Dev Guide.

You will also need to change the target branch of your Pull Request, all PR are made against master and your fix will be backported to the maintenance branches once it's accepted.

remilapeyre · 2020-06-03T07:22:24Z

Doc/library/tarfile.rst

@@ -784,7 +784,7 @@ How to read a gzip compressed tar archive and display some member information::
   import tarfile
   tar = tarfile.open("sample.tar.gz", "r:gz")
   for tarinfo in tar:
-       print(tarinfo.name, "is", tarinfo.size, "bytes in size and is", end="")
+       print(tarinfo.name, "is", tarinfo.size, "bytes in size and is ", end="")


Maybe this statement could use an f-string?

Ack. Still this functional improvement is valuable.

orsenthil

LGTM.

orsenthil · 2020-06-03T12:01:56Z

@HarshaLaxman , please sign the CLA

HarshaLaxman · 2020-06-03T15:34:38Z

I changed the target branch to Master as requested.

I did sign the CLA yesterday with bugs.python.org username harshalaxman and GitHub name HarshaLaxman... maybe it takes some time to register?

remilapeyre · 2020-06-03T15:40:16Z

I changed the target branch to Master as requested.

I did sign the CLA yesterday with bugs.python.org username harshalaxman and GitHub name HarshaLaxman... maybe it takes some time to register?

Please make sure your GitHub username is listed in the “Your Details” section at b.p.o: https://cloud.githubusercontent.com/assets/2680980/23276970/d14a380c-f9d1-11e6-883d-e13b6b211239.png

Also, thanks for changing the target branch but there should be only one commit in the PR, it took all changes that were in the branch.

HarshaLaxman · 2020-06-03T15:54:06Z

I changed the target branch to Master as requested.
I did sign the CLA yesterday with bugs.python.org username harshalaxman and GitHub name HarshaLaxman... maybe it takes some time to register?

Please make sure your GitHub username is listed in the “Your Details” section at b.p.o: https://cloud.githubusercontent.com/assets/2680980/23276970/d14a380c-f9d1-11e6-883d-e13b6b211239.png

Also, thanks for changing the target branch but there should be only one commit in the PR, it took all changes that were in the branch.

My GitHub username is in the "Your Details" section, but even b.p.o doesn't recognize that I signed the CLA. Comparing to the screenshot you shared, my page does not include "Contributor Form Received", although I got email confirmation and ewa was cc'd.

For changing the target branch, I can create a new PR against master once I figure out this CLA stuff?

orsenthil · 2020-06-03T15:57:52Z

For changing the target branch, I can create a new PR against master

Something is wrong with this PR. I suggest, pushing (force pushing) a clean version, or dropping this to create a new PR. Only one PR against master branch is enough.

HarshaLaxman · 2020-06-04T19:50:51Z

Looks like my CLA is acknowledged now.
Created a PR against master here: #20629

This can be closed, thanks for the assistance :)

miss-islington and others added 30 commits February 24, 2020 07:06

Python 3.8.2

7b3ab59

bpo-30566: Fix IndexError when using punycode codec (GH-18632)

daef21c

Trying to decode an invalid string with the punycode codec shoud raise UnicodeError. (cherry picked from commit ba22e8f) Co-authored-by: Berker Peksag <[email protected]>

Merge tag 'v3.8.2' into 3.8

a0e59d3

Python 3.8.2

Post 3.8.2

eb4a3df

bpo-38403: Update nuspec file for deprecated field and git repository (…

1bbb81b

…GH-18657) (cherry picked from commit d644891) Co-authored-by: Steve Dower <[email protected]>

Doc: int -> int or Py_ssize_t (GH-18663)

c3536b7

(cherry picked from commit 57c7a0b) Co-authored-by: Inada Naoki <[email protected]>

bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)

343bc06

Co-authored-by: Ammar Askar <[email protected]>

bpo-13790: Change 'string' to 'specification' in format doc (GH-18690)

445152e

(cherry picked from commit 916895f) Co-authored-by: Terry Jan Reedy <[email protected]>

bpo-39718: add TYPE_IGNORE, COLONEQUAL to py38 changes in token (GH-1…

7f53d87

…8598) (cherry picked from commit c2f7eb2) Co-authored-by: Shantanu <[email protected]>

bpo-39789: Update Windows release build machines to VS 2019 (GH-18695)

45c4112

Also fixes some potential Nuget build issues. (cherry picked from commit 03153dd) Co-authored-by: Steve Dower <[email protected]>

[3.8] bpo-39794: Add --without-decimal-contextvar (GH-18702)

4d70124

(cherry picked from commit 815280e)

[3.8] Fix syntax (GH-18716)

70d7a62

[3.8] Explicitly initialize like the surrounding code (GH-18717)

fec6681

[3.8] bpo-39815: add cached_property to all (GH-18726) (GH-18728)

12b7143

Automerge-Triggered-By: @pablogsal. (cherry picked from commit 217dce9) Co-authored-by: Hakan Çelik <[email protected]>

bpo-39378: partial of PickleState struct should be traversed. (GH-18046)

5f2ade2

(cherry picked from commit 1f577ce) Co-authored-by: Hai Shi <[email protected]>

[3.8] bpo-38913: Fix segfault in Py_BuildValue("(sGH-O)", ...) if ent…

a7b8a96

…ered with exception raised. (GH-18656). (GH-18732) (cherry picked from commit 28d0bca)

bpo-38410: Properly handle PySys_Audit() failures (GH-18658)

87a4cd5

_PyEval_SetAsyncGenFinalizer() and _PyEval_SetAsyncGenFirstiter() didn't include proper error handling for their PySys_Audit() calls. Co-authored-by: Zackery Spytz <[email protected]>

bpo-39764: Make Task.get_stack accept ag_frame (GH-18669)

43932dc

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 4482337) Co-authored-by: Lidi Zheng <[email protected]>

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678)

7ad9982

Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bpo-38597: Never statically link extension initialization code on Win…

0d20364

…dows (GH-18724) (cherry picked from commit ce3a498) Co-authored-by: Steve Dower <[email protected]>

[3.8] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750) (G…

394dc0d

…H-18761) (cherry picked from commit 2d2f855) Co-authored-by: Serhiy Storchaka <[email protected]>

bpo-39778: Add clarification about tp_traverse and ownership (GH-18754)

1827fc3

Automerge-Triggered-By: @pablogsal (cherry picked from commit 6df421f) Co-authored-by: Pablo Galindo <[email protected]>

bpo-39776: Lock ++interp->tstate_next_unique_id. (GH-18746) (#18746) (…

5a92f42

…#18752) - Threads created by PyGILState_Ensure() could have a duplicate tstate->id. (cherry picked from commit b3b9ade)

bpo-39674: Update collections ABC deprecation doc (GH-18748)

2aa694d

akuchling and others added 9 commits May 29, 2020 04:59

[3.8] bpo-25872: Fix KeyError in linecache when multithreaded (GH-18007…

b86636b

…) (GH-20092) Backporting to 3.8 and adding a NEWS item (I should have added one to the master branch -- oh well).

bpo-40784: Fix sqlite3 deterministic test (GH-20448)

00a240b

(cherry picked from commit c610d97) Co-authored-by: Erlend Egeberg Aasland <[email protected]>

closes bpo-29017: Update the bindings for Qt information with PySide2 (…

ef2f9ac

…GH-20149) Reference to PySide has been removed has it is for Qt 4, which has reached end of life. (cherry picked from commit 4649202) Co-authored-by: Samuel Gaist <[email protected]>

bpo-40798: Generate a different message for already removed elements (G…

ba1c2c8

…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <[email protected]>

bpo-40831: Remove an incorrect statement in the Windows docs (GH-20570)

d0dc369

(cherry picked from commit c896666) Co-authored-by: Zackery Spytz <[email protected]>

Ensure correct version of Sphinx is used for Windows builds (GH-20582)

139f1ba

(cherry picked from commit fe5dd78) Co-authored-by: Steve Dower <[email protected]>

the-knights-who-say-ni added the CLA not signed label Jun 2, 2020

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 2, 2020

remilapeyre suggested changes Jun 3, 2020

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Jun 3, 2020

orsenthil approved these changes Jun 3, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jun 3, 2020

orsenthil self-requested a review June 3, 2020 12:01

HarshaLaxman changed the base branch from 3.8 to master June 3, 2020 15:30

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jun 4, 2020

orsenthil closed this Jun 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix spacing in tarfile docs #20601

Fix spacing in tarfile docs #20601

Uh oh!

HarshaLaxman commented Jun 2, 2020

Uh oh!

the-knights-who-say-ni commented Jun 2, 2020

Uh oh!

remilapeyre left a comment

Uh oh!

remilapeyre Jun 3, 2020

Uh oh!

orsenthil Jun 3, 2020

Uh oh!

orsenthil left a comment

Uh oh!

orsenthil commented Jun 3, 2020

Uh oh!

HarshaLaxman commented Jun 3, 2020

Uh oh!

remilapeyre commented Jun 3, 2020 •

edited

Loading

Uh oh!

HarshaLaxman commented Jun 3, 2020

Uh oh!

orsenthil commented Jun 3, 2020

Uh oh!

HarshaLaxman commented Jun 4, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Fix spacing in tarfile docs #20601

Fix spacing in tarfile docs #20601

Uh oh!

Conversation

HarshaLaxman commented Jun 2, 2020

Uh oh!

the-knights-who-say-ni commented Jun 2, 2020

Recognized GitHub username

Uh oh!

remilapeyre left a comment

Choose a reason for hiding this comment

Uh oh!

remilapeyre Jun 3, 2020

Choose a reason for hiding this comment

Uh oh!

orsenthil Jun 3, 2020

Choose a reason for hiding this comment

Uh oh!

orsenthil left a comment

Choose a reason for hiding this comment

Uh oh!

orsenthil commented Jun 3, 2020

Uh oh!

HarshaLaxman commented Jun 3, 2020

Uh oh!

remilapeyre commented Jun 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HarshaLaxman commented Jun 3, 2020

Uh oh!

orsenthil commented Jun 3, 2020

Uh oh!

HarshaLaxman commented Jun 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

remilapeyre commented Jun 3, 2020 •

edited

Loading

HarshaLaxman commented Jun 4, 2020 •

edited

Loading