Merging swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a into tensorflow #25376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt assignment Addresses SR-6340
…e variable to allow users to specify a subset of architectures they wish to build.
…wift_target_library to export targets for all the defined archs rather than _just_ the last one processed in the foreach loop above.
…ariable which allows users to specify architectures they wish to configure and build _just_ the .swiftmodule content, even if they are not 'supported' via SWIFT_DARWIN_SUPPORTED_ARCHS.
…DARWIN_MODULE_ARCHS into semicolon-separated lists rather than space-separated.
…le architectures lists are mutually exclusive.
…supported architectures and module-only architectures on Darwin platforms.
Improve a little the build script to not have to change the version in two places of the URL.
…the global exports.
…cess level does not match rdar://50554717
The embedded shell script in the RUN command for lit is problematic for non-sh shell environments (i.e. Windows). This adjusts the tests to uniformly build the code for the ObjC runtime. However, the Objective-C code is only built under the same circumstances that it is currently enabled - the availability of the needed frameworks. The empty object on other runtimes will have no material impact. The swift side of it checks whether the runtime is built with ObjC interop. This allows us to largely use the same command line for all the targets. The last missing piece is that the `-fobjc-runtime` requires that we run a modern ObjC runtime. We enable this unconditionally in lit for the non-Apple targets. This improves the validation test coverage for the standard library on Windows.
The `rth` tool is a python script and relied on the execution via the shebang. However, not all targets support the shebang to invoke the interpreter. Explicitly launch the resilience test helper with the interpreter (python). Ideally, we would use the `%rth` substitution, but that does not seem to function for the nested case here.
Add a llvm_unreachable to indicate to MSVC that the switch is covered.
Split up the commands into multiple RUN lines. Use a temporary to actually capture the output of multiple invocations to compose them into a single stream. Replace the `export` usage with `env` which the lit interpreter is able to process even on Windows. This makes HashingRandomization pass on Windows.
…13, and watchOS 6 SDKs
Simplify the implementation of ClusteredBitVector by using an APInt to represent the raw bits. This simplification will make it easier to incrementally move to a representation of bit vectors that works on both big- and little-endian machines. This commit also removes reserve and reserveExtra from the API since they were only used in one place and no longer have any effect because memory allocation is now handled by the APInt class.
…eFieldType IRGen: getSingletonAggregateFieldType must not return field if its ac…
validation-test: avoid shell in HashingRandomization
Windows does not support the concept of RPATH. As a result, we must change the working directory for the test. This extends the support for the tests to work with PE/COFF on Windows. Use the newly minted `self.triple` property to drive the host detection. This means that the test coverage on Windows is able to test most of the resilience functionality.
The scale-test utility is a python script which was relying on the shebang to invoke the interpreter. However, not all targets support such an invocation mechanism (i.e. Windows doesn't support this). Explicitly invoke the interpreter to ensure that the tool is executed properly.
The C library functions used here do not appear without the C runtime being imported (ucrt or MSVCRT). Adjust the test as such. This exposes a stack corruption in the test which needs to be resolved.
…e-compatibility-autolink Reinstate "Use autolinking to pull in compatibility libraries."
This just uses the `%target-build-swift-dylib` instead of `%target-build-swift` substitution along with `%target-library-name` to ensure that we are target independent.
test: add a workaround for `rth` invocation
Android Intel 32/64 bit (i.e. Android Simulator) support.
Convert ObjectLiteralExpr to not use tc.callWitness() or generate a SemanticExpr
[Foundation] Bridge difference APIs between Foundation and swift stdlib
…t assignment While trying to fetch owner type for generic requirement failures anchored at assignment expression, use assignment source as an anchor because that's where requirements come from - conversion from source type to destination. Resolves: rdar://problem/51587755
SourceKit/Indentation: avoid indenting the end of subscript expressions in call chain.
Add missing newlines
…ror conformers" This reverts commit 712927c.
…ror, POSIXError and MachError
…ter trailing closure
[TSan] Add positive test for TSan + Dispatch on Linux
[Diagnostics] Clarify requirement failure source when it's anchored a…
…ak-fix Simpler fix for Foundation overlay ABI break
[Runtime] swift_demangle: Update buffer size after copying
…erge Tag build swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a
Sourcekit/Indentation: avoid indenting dot member access appearing after trailing closure
dan-zheng
force-pushed
the
tensorflow-merge
branch
from
5714cbc to
6f72f29
Compare
|
Current status:
@marcrasi: could you please help look into the lldb failures? |
dan-zheng
force-pushed
the
tensorflow-merge
branch
from
d82aa2c to
e2b06ef
Compare
|
All LLDB tests pass for me (and in fact, all toolchain tests pass for me) at commit e2b06ef. Maybe you were getting flakiness? Or maybe it's that the LLDB tests are very sensitive to the python version that you have on your system. |
Thank you for verifying that LLDB tests pass! I assume the failures I encountered are environment-related. Running tests now, then merging. |
- Remove deprecated `TARGET_SDKS ALL_POSIX_PLATFORMS`. - Specify DARWIN_INSTALL_NAME_DIR.
|
@swift-ci Please clean test tensorflow |
|
Tested manually on macOS. There's only one failure, which is known. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
apple/swift: merge 58827bb (from 2019-06-11).For all other repositories: merge
swift-DEVELOPMENT-SNAPSHOT-2019-06-06-a.