feat: Bump to NGO 1.1.1 #773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…everting MaxPayloadSize to default
* develop: (60 commits) fix: removing FindObjectOfType for a serialized reference (#754) fix: can click through loading screen [MTT-4753] (#760) Update CHANGELOG.md (#765) feat: Architecture.md update (MTT-2637) (#763) Update README.md (#759) Updating utilities package for release (#764) Version bumps (#761) Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758) adding components refs to index (#757) Adding link to feedback form at the top (#756) chore: adding details to changelog (#746) Updating readme with Typeform for feedback (#755) made arrow trails smaller (#750) Fixed up some layer settings on some archer VFX so that they show up properly! (#739) fix: lobby UI unblocking before it should [MTT-4579] (#748) feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612) Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753) fix: Moving utp to component instead of child GameObject (#752) Adding TOC and index to readme [MTT-4617] (#736) Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751) ... # Conflicts: # Assets/Prefabs/NetworkingManager.prefab
…this now only applies to unreliable messages. With how little NGO uses unreliable messages, this shouldn't need any tweaking anymore. reserializing NetworkingManager, this removes the old max send queue size value as well.
…pretty short for a connection. If there's any packet drops or temporary lag spike, this could timeout the connection when it was actually fine. Still lower than the default 10 seconds.
update required NGO package version for utilities
…ies/com.unity.multiplayer.samples.coop into sam/feat/bump-NGO-to-1.1 * 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop: adding missing PR ID adding missing PR ID Fix: Moved Clipping Torch (#768)
…ies/com.unity.multiplayer.samples.coop into sam/feat/bump-NGO-to-1.1 * 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop: initializing number of reconnect attempts before starting the reconnect coroutine
With latest develop fixes (see PR Unity-Technologies/com.unity.netcode.gameobjects#2275 ) this workaround shouldn't be needed anymore
SamuelBellomo
commented
Oct 24, 2022
| @@ -149,7 +149,6 @@ public IEnumerator NetworkedMessagesAreStillReceivedAfterNetworkManagerShutsDown | |||
|
|
|||
| m_NbMessagesReceived = 0; | |||
|
|
|||
There was a problem hiding this comment.
opening temporary thread to block this PR from being merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest develop fixes (see PR Unity-Technologies/com.unity.netcode.gameobjects#2275 ) this workaround shouldn't be needed anymore
Description
tmp branch while waiting for next NGO update.
Issue Number(s)
Contribution checklist