Skip to content

Use gzip #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

Use gzip #3316

merged 3 commits into from
Jan 26, 2022

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-common

    TypeBase (f69f4f4)Merge (69c986f)Diff
    aar47.3 kB47.5 kB+192 B (+0.4%)

Test Logs

Notes

  • Commit (69c986f) is created by Prow via merging PR base commit (f69f4f4) and head commit (c6b8cec).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LOENMxJQEN.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-common

    Overall coverage changed from 64.96% (f69f4f4) to 65.16% (69c986f) by +0.20%.

    FilenameBase (f69f4f4)Merge (69c986f)Diff
    DefaultHeartBeatController.java93.65%94.03%+0.38%

Test Logs

Notes

  • Commit (69c986f) is created by Prow via merging PR base commit (f69f4f4) and head commit (c6b8cec).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KEcQbhUaco.html

@VinayGuthal VinayGuthal requested a review from vkryachko January 20, 2022 17:34
@VinayGuthal
Copy link
Contributor Author

/test check-changed

1 similar comment
@VinayGuthal
Copy link
Contributor Author

/test check-changed

@VinayGuthal
Copy link
Contributor Author

/test device-check-changed

@google-oss-bot
Copy link
Contributor

@VinayGuthal: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests c6b8cec link /test smoke-tests
device-check-changed c6b8cec link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VinayGuthal VinayGuthal merged commit 2df8148 into platform_logging_main_branch Jan 26, 2022
@VinayGuthal VinayGuthal deleted the use_gzip branch January 26, 2022 17:25
VinayGuthal added a commit that referenced this pull request Jan 26, 2022
@VinayGuthal
Platform logging main branch (#3347)
dcf82a5 
* Collect heartbeat in android (#3120)

* add heart beat

* update

* update according to comments

* update

* update

* update comments

* update

* gjf

* address comments

* Synchronize old and new heartbeats (#3177)

* synchronize heartbeats

* update

* gJF

* update

* update

* make synchornized

* update

* update

* Set fis as an unloader (#3222)

* update

* add gmp app id

* update

* gJF

* update

* update fix

* update

* Use gzip (#3316)

* update

* gJF

* delete default heartbeat info
@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlonzo carlonzo carlonzo left review comments

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VinayGuthal @google-oss-bot @vkryachko @carlonzo