Skip to content

Platform logging main branch #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 26, 2022
Merged

Platform logging main branch #3347

merged 6 commits into from
Jan 26, 2022

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@VinayGuthal
Collect heartbeat in android (#3120)
feb69dd 
* add heart beat

* update

* update according to comments

* update

* update

* update comments

* update

* gjf

* address comments
@VinayGuthal
Synchronize old and new heartbeats (#3177)
2dd41ce 
* synchronize heartbeats

* update

* gJF

* update

* update

* make synchornized

* update

* update
@VinayGuthal
Set fis as an unloader (#3222)
f69f4f4 
* update

* add gmp app id

* update

* gJF

* update

* update fix

* update
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 26, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-installations

    Overall coverage changed from 60.21% (f25efea) to 59.96% (3c1126b) by -0.25%.

    FilenameBase (f25efea)Merge (3c1126b)Diff
    FirebaseInstallationServiceClient.java5.26%4.80%-0.46%

Test Logs

Notes

  • Commit (3c1126b) is created by Prow via merging PR base commit (f25efea) and head commit (ef04aee).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1BZ11AcgOt.html

@VinayGuthal VinayGuthal requested a review from vkryachko January 26, 2022 18:45
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-common

    TypeBase (f25efea)Merge (3c1126b)Diff
    aar44.3 kB47.5 kB+3.19 kB (+7.2%)
    apk (aggressive)77.8 kB80.3 kB+2.47 kB (+3.2%)
    apk (release)635 kB637 kB+1.67 kB (+0.3%)

  • firebase-installations

    TypeBase (f25efea)Merge (3c1126b)Diff
    aar54.7 kB54.7 kB-33 B (-0.1%)
    apk (aggressive)79.3 kB81.7 kB+2.44 kB (+3.1%)
    apk (release)657 kB658 kB+1.23 kB (+0.2%)

Test Logs

Notes

  • Commit (3c1126b) is created by Prow via merging PR base commit (f25efea) and head commit (ef04aee).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UO7Rro5Zy6.html

@VinayGuthal VinayGuthal merged commit dcf82a5 into master Jan 26, 2022
@VinayGuthal VinayGuthal deleted the platform_logging_main_branch branch January 26, 2022 19:08
@google-oss-bot
Copy link
Contributor

@VinayGuthal: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests ef04aee link /test smoke-tests
device-check-changed ef04aee link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinayGuthal @google-oss-bot @vkryachko