Do not attempt to parse empty json files in MetaDataStore #3735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
mrichards
approved these changes
May 18, 2022
qdpham13
pushed a commit
that referenced
this pull request
May 19, 2022
* Do not attempt to parse empty json files in MetaDataStore * Safely delete corrupt files in MetaDataStore
qdpham13
added a commit
that referenced
this pull request
May 23, 2022
* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Update stream name * Add copyright info to top of file. * Update comments * Format file. * Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Update stream name * Add copyright info to top of file. * Update comments * Format file. * Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level. * Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level. * Format and update comments * Uodate api.txt * Add nonnull and nullable to params * Change registration to interface. * Add author * Update api.txt * Dependabot High severity alerts (#3734) * Dependency updates for `smoke-tests` * Do not attempt to parse empty json files in MetaDataStore (#3735) * Do not attempt to parse empty json files in MetaDataStore * Safely delete corrupt files in MetaDataStore * Disable javadoc for undocumented sdks. (#3738) * Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Reupdate files. * Make changes based on PR comments; Make internal ConfigUpdateListenerRegistration non-static to access private listener removal method from outer class. Add synchonization to listeners set. * Remove synchronized set and add explicit synchonized to methods. Co-authored-by: Daymon <[email protected]> Co-authored-by: Matthew Robertson <[email protected]> Co-authored-by: Vladimir Kryachko <[email protected]>
qdpham13
added a commit
that referenced
this pull request
Jun 13, 2022
* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Update stream name * Add copyright info to top of file. * Update comments * Format file. * Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Update stream name * Add copyright info to top of file. * Update comments * Format file. * Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level. * Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level. * Format and update comments * Uodate api.txt * Add nonnull and nullable to params * Change registration to interface. * Add author * Update api.txt * Dependabot High severity alerts (#3734) * Dependency updates for `smoke-tests` * Do not attempt to parse empty json files in MetaDataStore (#3735) * Do not attempt to parse empty json files in MetaDataStore * Safely delete corrupt files in MetaDataStore * Disable javadoc for undocumented sdks. (#3738) * Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file. * Reupdate files. * Make changes based on PR comments; Make internal ConfigUpdateListenerRegistration non-static to access private listener removal method from outer class. Add synchonization to listeners set. * Remove synchronized set and add explicit synchonized to methods. * Add http connection logic * Add autofetch logic * Add http stream connection and async autofetching. Also add template version number to cache. * Add message decoding * add unit tests and Realtime based exceptions * Update api.txt * Fix check failures * Format files * Update changes based on PR comments * Add back template version number check * Alter template version number comment to reflect changes * Revert template version number extraction * Update template version number comment * Add thread safe for autofetch listeners * Add thread safe for autofetch listeners * add stream unit tests and thread safe for http connection object * finish autofetch testing * Post release version updates (#3752) * Ignore appdistro-api since it's still in beta. (#3751) * Upgrade Gradle to 6.9 (#3744) * Migrate from deprecated api usage in Coverage script * Fix bugs preventing 6.9 upgrade * oops, that shouldn't have been there still * Fixed old usage of Gradle BOM support (or lack-there-of) * Fixed some minor gradle consistencies, and added firehorn to gitignore * Added distribution versioning back * Explicitly depend on appdistribution-api Co-authored-by: Yifan Yang <[email protected]> * Upgrade kotlin version to 1.6.20 (#3762) * Upgrade kotlin version to 1.6.20 * Upgrade dagger in protoc-gen-firebase-encoders. * Filter out only release component. * Add explanation. * Remove extra log Co-authored-by: Daymon <[email protected]> Co-authored-by: Matthew Robertson <[email protected]> Co-authored-by: Vladimir Kryachko <[email protected]> Co-authored-by: Yifan Yang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.