Skip to content

Upgrade Gradle to 6.9 #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 30, 2022

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented May 24, 2022

We're currently utilizing a very old version of Gradle (5.4), wheres the current LTS for Gradle is 7.4.2

In an effort to get the SDK up-to-date, this PR gets Gradle up to 6.9
Moving to 7.x will require some additional work, but this is the first step.

Buganizer tickets: 233146890, 233139769, 233146881

233146878 as well, but that's associated with a different PR that has already been merged.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 24, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (7355e88) to 50.18% (0452597) by +0.02%.

    FilenameBase (7355e88)Merge (0452597)Diff
    DoubleNode.java88.24%100.00%+11.76%
  • firebase-firestore

    Overall coverage changed from 46.18% (7355e88) to 46.16% (0452597) by -0.02%.

    FilenameBase (7355e88)Merge (0452597)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    GrpcCallProvider.java58.82%55.29%-3.53%
  • firebase-messaging

    Overall coverage changed from 84.91% (7355e88) to 85.03% (0452597) by +0.12%.

    FilenameBase (7355e88)Merge (0452597)Diff
    Metadata.java57.14%61.90%+4.76%
  • firebase-storage

    Overall coverage changed from 85.94% (7355e88) to 85.85% (0452597) by -0.09%.

    FilenameBase (7355e88)Merge (0452597)Diff
    UploadTask.java81.29%80.58%-0.72%

Test Logs

Notes

  • Commit (0452597) is created by Prow via merging PR base commit (7355e88) and head commit (96e28a3).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yMWZTHeIBb.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 24, 2022

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)85.3 kB85.5 kB+195 B (+0.2%)
    apk (release)686 kB695 kB+9.64 kB (+1.4%)
  • firebase-appcheck

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)330 kB330 kB+199 B (+0.1%)
    apk (release)974 kB983 kB+9.72 kB (+1.0%)
  • firebase-appcheck-debug

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)330 kB330 kB+199 B (+0.1%)
    apk (release)976 kB987 kB+10.2 kB (+1.0%)
  • firebase-appcheck-debug-testing

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)332 kB332 kB+199 B (+0.1%)
    apk (release)1.01 MB1.02 MB+11.5 kB (+1.1%)
  • firebase-appcheck-interop

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)327 kB327 kB+195 B (+0.1%)
    apk (release)962 kB972 kB+9.62 kB (+1.0%)
  • firebase-appcheck-playintegrity

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)330 kB331 kB+199 B (+0.1%)
    apk (release)986 kB997 kB+11.0 kB (+1.1%)
  • firebase-appcheck-safetynet

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)330 kB331 kB+195 B (+0.1%)
    apk (release)987 kB998 kB+11.1 kB (+1.1%)
  • firebase-appdistribution

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)747 kB751 kB+4.29 kB (+0.6%)
    apk (release)1.58 MB1.59 MB+10.4 kB (+0.7%)
  • firebase-appdistribution-api

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)85.2 kB85.4 kB+199 B (+0.2%)
    apk (release)687 kB697 kB+10.4 kB (+1.5%)
  • firebase-appdistribution-api-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)101 kB101 kB+195 B (+0.2%)
    apk (release)1.17 MB1.18 MB+9.52 kB (+0.8%)
  • firebase-common

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)84.6 kB84.8 kB+195 B (+0.2%)
    apk (release)681 kB689 kB+8.58 kB (+1.3%)
  • firebase-common-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)100 kB100 kB+199 B (+0.2%)
    apk (release)1.16 MB1.17 MB+10.4 kB (+0.9%)
  • firebase-config

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)93.8 kB94.0 kB+195 B (+0.2%)
    apk (release)733 kB743 kB+10.3 kB (+1.4%)
  • firebase-config-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)114 kB114 kB+199 B (+0.2%)
    apk (release)1.21 MB1.22 MB+9.04 kB (+0.7%)
  • firebase-crashlytics

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)216 kB216 kB+199 B (+0.1%)
    apk (release)892 kB902 kB+9.50 kB (+1.1%)
  • firebase-crashlytics-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)232 kB232 kB+199 B (+0.1%)
    apk (release)1.37 MB1.38 MB+10.1 kB (+0.7%)
  • firebase-crashlytics-ndk

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive / arm64-v8a)1.34 MB1.34 MB+195 B (+0.0%)
    apk (aggressive / armeabi-v7a)842 kB842 kB+195 B (+0.0%)
    apk (aggressive / x86)1.38 MB1.38 MB+195 B (+0.0%)
    apk (aggressive / x86_64)1.44 MB1.44 MB+195 B (+0.0%)
    apk (release / arm64-v8a)2.01 MB2.02 MB+12.5 kB (+0.6%)
    apk (release / armeabi-v7a)1.51 MB1.53 MB+12.5 kB (+0.8%)
    apk (release / x86)2.05 MB2.07 MB+12.5 kB (+0.6%)
    apk (release / x86_64)2.12 MB2.13 MB+12.5 kB (+0.6%)
  • firebase-database

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)328 kB329 kB+195 B (+0.1%)
    apk (release)1.14 MB1.15 MB+11.5 kB (+1.0%)
  • firebase-database-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)348 kB349 kB+195 B (+0.1%)
    apk (release)1.62 MB1.63 MB+9.86 kB (+0.6%)
  • firebase-datatransport

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)131 kB131 kB+195 B (+0.1%)
    apk (release)767 kB778 kB+10.7 kB (+1.4%)
  • firebase-dynamic-links

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)329 kB329 kB+195 B (+0.1%)
    apk (release)976 kB985 kB+9.38 kB (+1.0%)
  • firebase-dynamic-links-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)349 kB349 kB+195 B (+0.1%)
    apk (release)1.46 MB1.47 MB+9.65 kB (+0.7%)
  • firebase-dynamic-module-support

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)145 kB145 kB+199 B (+0.1%)
    apk (release)791 kB801 kB+10.3 kB (+1.3%)
  • firebase-firestore

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)489 kB489 kB+199 B (+0.0%)
    apk (release)3.38 MB3.39 MB+10.4 kB (+0.3%)
  • firebase-firestore-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)505 kB505 kB+195 B (+0.0%)
    apk (release)3.87 MB3.87 MB+3.47 kB (+0.1%)
  • firebase-functions

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)393 kB397 kB+4.30 kB (+1.1%)
    apk (release)1.21 MB1.22 MB+10.8 kB (+0.9%)
  • firebase-functions-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)412 kB413 kB+195 B (+0.0%)
    apk (release)1.69 MB1.70 MB+8.78 kB (+0.5%)
  • firebase-inappmessaging

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)664 kB664 kB+199 B (+0.0%)
    apk (release)3.42 MB3.42 MB+9.36 kB (+0.3%)
  • firebase-inappmessaging-display

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)1.50 MB1.50 MB+195 B (+0.0%)
    apk (release)4.68 MB4.69 MB+9.84 kB (+0.2%)
  • firebase-inappmessaging-display-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)1.51 MB1.51 MB+199 B (+0.0%)
    apk (release)5.17 MB5.18 MB+10.4 kB (+0.2%)
  • firebase-inappmessaging-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)680 kB680 kB+199 B (+0.0%)
    apk (release)3.90 MB3.91 MB+8.47 kB (+0.2%)
  • firebase-installations

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)86.1 kB86.3 kB+199 B (+0.2%)
    apk (release)703 kB712 kB+9.57 kB (+1.4%)
  • firebase-installations-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)102 kB102 kB+195 B (+0.2%)
    apk (release)1.18 MB1.19 MB+11.0 kB (+0.9%)
  • firebase-messaging

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)437 kB438 kB+195 B (+0.0%)
    apk (release)1.14 MB1.15 MB+11.8 kB (+1.0%)
  • firebase-messaging-directboot

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)415 kB415 kB+199 B (+0.0%)
    apk (release)1.10 MB1.11 MB+9.86 kB (+0.9%)
  • firebase-messaging-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)453 kB453 kB+195 B (+0.0%)
    apk (release)1.62 MB1.63 MB+8.52 kB (+0.5%)
  • firebase-ml-modeldownloader

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)143 kB143 kB+199 B (+0.1%)
    apk (release)819 kB830 kB+10.5 kB (+1.3%)
  • firebase-ml-modeldownloader-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)159 kB159 kB+199 B (+0.1%)
    apk (release)1.30 MB1.31 MB+11.1 kB (+0.9%)
  • firebase-perf

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)1.03 MB1.03 MB+195 B (+0.0%)
    apk (release)2.47 MB2.48 MB+9.55 kB (+0.4%)
  • firebase-perf-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)1.04 MB1.04 MB+199 B (+0.0%)
    apk (release)2.95 MB2.96 MB+11.3 kB (+0.4%)
  • firebase-segmentation

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)86.6 kB86.8 kB+195 B (+0.2%)
    apk (release)709 kB719 kB+9.68 kB (+1.4%)
  • firebase-storage

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)328 kB328 kB+199 B (+0.1%)
    apk (release)1.00 MB1.01 MB+9.25 kB (+0.9%)
  • firebase-storage-ktx

    TypeBase (7355e88)Merge (0452597)Diff
    apk (aggressive)348 kB348 kB+195 B (+0.1%)
    apk (release)1.48 MB1.50 MB+11.2 kB (+0.8%)

Test Logs

Notes

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/phJpRlSb3c.html

@daymxn daymxn assigned daymxn and unassigned rlazo May 24, 2022
@rlazo
Copy link
Collaborator

rlazo commented May 24, 2022

@yifanyang FYI

@yifanyang
Copy link
Contributor

/test smoke-tests

@yifanyang
Copy link
Contributor

/retest

1 similar comment
@vkryachko
Copy link
Member

/retest

@google-oss-bot
Copy link
Contributor

@daymxn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 96e28a3 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@daymxn daymxn requested a review from rlazo May 27, 2022 18:08
@daymxn daymxn assigned rlazo and unassigned daymxn May 27, 2022
@rlazo rlazo merged commit fd27d8b into firebase:master May 30, 2022
qdpham13 pushed a commit that referenced this pull request May 31, 2022
* Migrate from deprecated api usage in Coverage script

* Fix bugs preventing 6.9 upgrade

* oops, that shouldn't have been there still

* Fixed old usage of Gradle BOM support (or lack-there-of)

* Fixed some minor gradle consistencies, and added firehorn to gitignore

* Added distribution versioning back

* Explicitly depend on appdistribution-api

Co-authored-by: Yifan Yang <[email protected]>
qdpham13 added a commit that referenced this pull request Jun 13, 2022
* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Format and update comments

* Uodate api.txt

* Add nonnull and nullable to params

* Change registration to interface.

* Add author

* Update api.txt

* Dependabot High severity alerts (#3734)

* Dependency updates for `smoke-tests`

* Do not attempt to parse empty json files in MetaDataStore (#3735)

* Do not attempt to parse empty json files in MetaDataStore

* Safely delete corrupt files in MetaDataStore

* Disable javadoc for undocumented sdks. (#3738)

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Reupdate files.

* Make changes based on PR comments;
Make internal ConfigUpdateListenerRegistration non-static to access private listener removal method from outer class.
Add synchonization to listeners set.

* Remove synchronized set and add explicit synchonized to methods.

* Add http connection logic

* Add autofetch logic

* Add http stream connection and async autofetching. Also add template version number to cache.

* Add message decoding

* add unit tests and Realtime based exceptions

* Update api.txt

* Fix check failures

* Format files

* Update changes based on PR comments

* Add back template version number check

* Alter template version number comment to reflect changes

* Revert template version number extraction

* Update template version number comment

* Add thread safe for autofetch listeners

* Add thread safe for autofetch listeners

* add stream unit tests and thread safe for http connection object

* finish autofetch testing

* Post release version updates (#3752)

* Ignore appdistro-api since it's still in beta. (#3751)

* Upgrade Gradle to 6.9 (#3744)

* Migrate from deprecated api usage in Coverage script

* Fix bugs preventing 6.9 upgrade

* oops, that shouldn't have been there still

* Fixed old usage of Gradle BOM support (or lack-there-of)

* Fixed some minor gradle consistencies, and added firehorn to gitignore

* Added distribution versioning back

* Explicitly depend on appdistribution-api

Co-authored-by: Yifan Yang <[email protected]>

* Upgrade kotlin version to 1.6.20 (#3762)

* Upgrade kotlin version to 1.6.20

* Upgrade dagger in protoc-gen-firebase-encoders.

* Filter out only release component.

* Add explanation.

* Remove extra log

Co-authored-by: Daymon <[email protected]>
Co-authored-by: Matthew Robertson <[email protected]>
Co-authored-by: Vladimir Kryachko <[email protected]>
Co-authored-by: Yifan Yang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants