-
Notifications
You must be signed in to change notification settings - Fork 624
Rc realtime dev #3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rc realtime dev #3743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egistration. Also exposes methods to be used by public RC file.
…egistration. Also exposes methods to be used by public RC file.
…egistration. Also exposes methods to be used by public RC file.
* Dependency updates for `smoke-tests`
* Do not attempt to parse empty json files in MetaDataStore * Safely delete corrupt files in MetaDataStore
…egistration. Also exposes methods to be used by public RC file.
Make internal ConfigUpdateListenerRegistration non-static to access private listener removal method from outer class. Add synchonization to listeners set.
* Migrate from deprecated api usage in Coverage script * Fix bugs preventing 6.9 upgrade * oops, that shouldn't have been there still * Fixed old usage of Gradle BOM support (or lack-there-of) * Fixed some minor gradle consistencies, and added firehorn to gitignore * Added distribution versioning back * Explicitly depend on appdistribution-api Co-authored-by: Yifan Yang <[email protected]>
* Upgrade kotlin version to 1.6.20 * Upgrade dagger in protoc-gen-firebase-encoders. * Filter out only release component. * Add explanation.
/test smoke-tests |
Please review when you get the chance, @vkryachko. Thanks! |
/test smoke-tests |
Hey everyone, please take a look at the PR and give a review when you get the chance. If everyone feels like it would be easier to go over it in a meeting we can do that too. Thanks! @vkryachko |
vkryachko
approved these changes
Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
Realtime RC based exceptions
Http stream connection via HttpUrlConnection
Http helper methods that creates request and fills in headers (Taken from ConfigFetchHttpClient)
Template Version Number to ConfigContainer
Unit tests
Auto fetch file - Fetch until we receive new template version or we run out of attempts