Skip to content

Upgrade kotlin version to 1.6.20 #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2022
Merged

Upgrade kotlin version to 1.6.20 #3762

merged 4 commits into from
May 30, 2022

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from rlazo May 30, 2022 18:40
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 30, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (fd27d8b) to 50.21% (e2573ac) by +0.03%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    ViewProcessor.java92.10%91.79%-0.30%
    WebsocketConnection.java32.77%35.03%+2.26%
  • firebase-database-ktx

    Overall coverage changed from 75.00% (fd27d8b) to 77.78% (e2573ac) by +2.78%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    Database.kt75.00%77.78%+2.78%
  • firebase-dynamic-links-ktx

    Overall coverage changed from 80.39% (fd27d8b) to 80.77% (e2573ac) by +0.38%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    FirebaseDynamicLinks.kt80.39%80.77%+0.38%
  • firebase-firestore

    Overall coverage changed from 46.18% (fd27d8b) to 45.99% (e2573ac) by -0.19%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    AsyncQueue.java77.61%77.11%-0.50%
    Datastore.java32.14%29.76%-2.38%
    DeleteMutation.java95.24%90.48%-4.76%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.24%30.88%-7.35%
    GrpcCallProvider.java58.82%48.24%-10.59%
    IndexBackfiller.java93.44%78.69%-14.75%
    LruGarbageCollector.java93.46%84.11%-9.35%
    SetMutation.java97.22%94.44%-2.78%
  • firebase-messaging

    Overall coverage changed from 84.95% (fd27d8b) to 84.68% (e2573ac) by -0.27%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    FirebaseMessaging.java75.33%74.89%-0.44%
    RequestDeduplicator.java90.00%80.00%-10.00%
    TopicsSubscriber.java89.47%88.60%-0.88%
    TopicsSyncTask.java53.33%49.33%-4.00%
  • firebase-perf

    Overall coverage changed from 71.40% (fd27d8b) to 71.41% (e2573ac) by +0.02%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    TransportManager.java94.88%95.35%+0.47%
  • firebase-perf-ktx

    Overall coverage changed from 21.43% (fd27d8b) to 26.67% (e2573ac) by +5.24%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    Performance.kt21.43%26.67%+5.24%
  • firebase-storage

    Overall coverage changed from 85.85% (fd27d8b) to 85.81% (e2573ac) by -0.04%.

    FilenameBase (fd27d8b)Merge (e2573ac)Diff
    UploadTask.java80.58%80.22%-0.36%

Test Logs

Notes

  • Commit (e2573ac) is created by Prow via merging PR base commit (fd27d8b) and head commit (fc8a258).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VdVdtZm4wE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 30, 2022

Size Report 1

Affected Products

  • firebase-appdistribution-api-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar6.13 kB6.11 kB-20 B (-0.3%)
    apk (aggressive)101 kB101 kB-13 B (-0.0%)
    apk (release)1.18 MB1.26 MB+81.8 kB (+7.0%)
  • firebase-common-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar6.28 kB6.30 kB+27 B (+0.4%)
    apk (aggressive)100 kB100 kB-280 B (-0.3%)
    apk (release)1.17 MB1.24 MB+70.8 kB (+6.1%)
  • firebase-config-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar5.84 kB5.84 kB+4 B (+0.1%)
    apk (aggressive)114 kB114 kB-37 B (-0.0%)
    apk (release)1.22 MB1.30 MB+82.3 kB (+6.7%)
  • firebase-crashlytics-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar6.85 kB6.87 kB+20 B (+0.3%)
    apk (aggressive)232 kB232 kB+7 B (+0.0%)
    apk (release)1.38 MB1.46 MB+80.2 kB (+5.8%)
  • firebase-database-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar7.70 kB7.65 kB-51 B (-0.7%)
    apk (aggressive)349 kB349 kB-5 B (-0.0%)
    apk (release)1.63 MB1.71 MB+79.2 kB (+4.9%)
  • firebase-dynamic-links-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar8.78 kB8.72 kB-66 B (-0.8%)
    apk (aggressive)349 kB349 kB-21 B (-0.0%)
    apk (release)1.47 MB1.55 MB+79.2 kB (+5.4%)
  • firebase-firestore-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar7.45 kB7.43 kB-26 B (-0.3%)
    apk (aggressive)505 kB505 kB-25 B (-0.0%)
    apk (release)3.87 MB3.95 MB+81.1 kB (+2.1%)
  • firebase-functions-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar6.13 kB6.12 kB-3 B (-0.0%)
    apk (aggressive)413 kB413 kB-9 B (-0.0%)
    apk (release)1.70 MB1.78 MB+81.2 kB (+4.8%)
  • firebase-inappmessaging-display-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar22.2 kB22.2 kB+16 B (+0.1%)
    apk (aggressive)1.51 MB1.51 MB-73 B (-0.0%)
    apk (release)5.18 MB5.26 MB+79.8 kB (+1.5%)
  • firebase-inappmessaging-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar5.29 kB5.31 kB+17 B (+0.3%)
    apk (aggressive)680 kB680 kB-53 B (-0.0%)
    apk (release)3.91 MB3.99 MB+81.4 kB (+2.1%)
  • firebase-installations-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar5.28 kB5.28 kB+2 B (+0.0%)
    apk (aggressive)102 kB102 kB-29 B (-0.0%)
    apk (release)1.19 MB1.27 MB+80.5 kB (+6.7%)
  • firebase-messaging-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar6.52 kB6.54 kB+18 B (+0.3%)
    apk (aggressive)453 kB453 kB+27 B (+0.0%)
    apk (release)1.63 MB1.71 MB+82.4 kB (+5.1%)
  • firebase-ml-modeldownloader-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar6.39 kB6.37 kB-27 B (-0.4%)
    apk (aggressive)159 kB159 kB-45 B (-0.0%)
    apk (release)1.31 MB1.39 MB+79.3 kB (+6.0%)
  • firebase-perf-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar19.5 kB19.5 kB+23 B (+0.1%)
    apk (aggressive)1.04 MB1.04 MB-9 B (-0.0%)
    apk (release)2.96 MB3.04 MB+80.3 kB (+2.7%)
  • firebase-storage-ktx

    TypeBase (fd27d8b)Merge (e2573ac)Diff
    aar7.28 kB7.25 kB-26 B (-0.4%)
    apk (aggressive)348 kB348 kB-37 B (-0.0%)
    apk (release)1.50 MB1.58 MB+79.3 kB (+5.3%)

Test Logs

Notes

  • Commit (e2573ac) is created by Prow via merging PR base commit (fd27d8b) and head commit (fc8a258).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nCmT5EYrVl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 30, 2022

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed fc8a258 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator

rlazo commented May 30, 2022

/test check-changed

@rlazo rlazo merged commit fd109a8 into master May 30, 2022
@rlazo rlazo deleted the vk.kotlin_upgrade branch May 30, 2022 23:16
qdpham13 pushed a commit that referenced this pull request May 31, 2022
* Upgrade kotlin version to 1.6.20

* Upgrade dagger in protoc-gen-firebase-encoders.

* Filter out only release component.

* Add explanation.
vkryachko added a commit that referenced this pull request Jun 1, 2022
This reverts commit fd109a8.

This change broke kotlindoc generation, will have to fix it before
upgrading again.
vkryachko added a commit that referenced this pull request Jun 1, 2022
This reverts commit fd109a8.

This change broke kotlindoc generation, will have to fix it before
upgrading again.
qdpham13 added a commit that referenced this pull request Jun 13, 2022
* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Format and update comments

* Uodate api.txt

* Add nonnull and nullable to params

* Change registration to interface.

* Add author

* Update api.txt

* Dependabot High severity alerts (#3734)

* Dependency updates for `smoke-tests`

* Do not attempt to parse empty json files in MetaDataStore (#3735)

* Do not attempt to parse empty json files in MetaDataStore

* Safely delete corrupt files in MetaDataStore

* Disable javadoc for undocumented sdks. (#3738)

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Reupdate files.

* Make changes based on PR comments;
Make internal ConfigUpdateListenerRegistration non-static to access private listener removal method from outer class.
Add synchonization to listeners set.

* Remove synchronized set and add explicit synchonized to methods.

* Add http connection logic

* Add autofetch logic

* Add http stream connection and async autofetching. Also add template version number to cache.

* Add message decoding

* add unit tests and Realtime based exceptions

* Update api.txt

* Fix check failures

* Format files

* Update changes based on PR comments

* Add back template version number check

* Alter template version number comment to reflect changes

* Revert template version number extraction

* Update template version number comment

* Add thread safe for autofetch listeners

* Add thread safe for autofetch listeners

* add stream unit tests and thread safe for http connection object

* finish autofetch testing

* Post release version updates (#3752)

* Ignore appdistro-api since it's still in beta. (#3751)

* Upgrade Gradle to 6.9 (#3744)

* Migrate from deprecated api usage in Coverage script

* Fix bugs preventing 6.9 upgrade

* oops, that shouldn't have been there still

* Fixed old usage of Gradle BOM support (or lack-there-of)

* Fixed some minor gradle consistencies, and added firehorn to gitignore

* Added distribution versioning back

* Explicitly depend on appdistribution-api

Co-authored-by: Yifan Yang <[email protected]>

* Upgrade kotlin version to 1.6.20 (#3762)

* Upgrade kotlin version to 1.6.20

* Upgrade dagger in protoc-gen-firebase-encoders.

* Filter out only release component.

* Add explanation.

* Remove extra log

Co-authored-by: Daymon <[email protected]>
Co-authored-by: Matthew Robertson <[email protected]>
Co-authored-by: Vladimir Kryachko <[email protected]>
Co-authored-by: Yifan Yang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants