Skip to content

Disable javadoc for undocumented sdks. #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

Disable javadoc for undocumented sdks. #3738

merged 1 commit into from
May 19, 2022

Conversation

vkryachko
Copy link
Member

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (d06d7c5) and merge commit (323f67e).

Test Logs

Notes

  • Commit (323f67e) is created by Prow via merging PR base commit (d06d7c5) and head commit (3976860).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nTLRHNWxrx.html

@google-oss-bot
Copy link
Contributor

@vkryachko vkryachko requested review from rlazo and davidmotson May 19, 2022 17:11
@rlazo rlazo merged commit d4c251a into master May 19, 2022
@rlazo rlazo deleted the vk.no_javadoc branch May 19, 2022 17:13
qdpham13 added a commit that referenced this pull request May 23, 2022
* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Format and update comments

* Uodate api.txt

* Add nonnull and nullable to params

* Change registration to interface.

* Add author

* Update api.txt

* Dependabot High severity alerts (#3734)

* Dependency updates for `smoke-tests`

* Do not attempt to parse empty json files in MetaDataStore (#3735)

* Do not attempt to parse empty json files in MetaDataStore

* Safely delete corrupt files in MetaDataStore

* Disable javadoc for undocumented sdks. (#3738)

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Reupdate files.

* Make changes based on PR comments;
Make internal ConfigUpdateListenerRegistration non-static to access private listener removal method from outer class.
Add synchonization to listeners set.

* Remove synchronized set and add explicit synchonized to methods.

Co-authored-by: Daymon <[email protected]>
Co-authored-by: Matthew Robertson <[email protected]>
Co-authored-by: Vladimir Kryachko <[email protected]>
qdpham13 added a commit that referenced this pull request Jun 13, 2022
* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Update stream name

* Add copyright info to top of file.

* Update comments

* Format file.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Moved ConfigUpdateListener and ConfigUpdateListenerRegistration to public level.

* Format and update comments

* Uodate api.txt

* Add nonnull and nullable to params

* Change registration to interface.

* Add author

* Update api.txt

* Dependabot High severity alerts (#3734)

* Dependency updates for `smoke-tests`

* Do not attempt to parse empty json files in MetaDataStore (#3735)

* Do not attempt to parse empty json files in MetaDataStore

* Safely delete corrupt files in MetaDataStore

* Disable javadoc for undocumented sdks. (#3738)

* Creates Realtime Http client file. Includes ConfigUpdate Listener & Registration. Also exposes methods to be used by public RC file.

* Reupdate files.

* Make changes based on PR comments;
Make internal ConfigUpdateListenerRegistration non-static to access private listener removal method from outer class.
Add synchonization to listeners set.

* Remove synchronized set and add explicit synchonized to methods.

* Add http connection logic

* Add autofetch logic

* Add http stream connection and async autofetching. Also add template version number to cache.

* Add message decoding

* add unit tests and Realtime based exceptions

* Update api.txt

* Fix check failures

* Format files

* Update changes based on PR comments

* Add back template version number check

* Alter template version number comment to reflect changes

* Revert template version number extraction

* Update template version number comment

* Add thread safe for autofetch listeners

* Add thread safe for autofetch listeners

* add stream unit tests and thread safe for http connection object

* finish autofetch testing

* Post release version updates (#3752)

* Ignore appdistro-api since it's still in beta. (#3751)

* Upgrade Gradle to 6.9 (#3744)

* Migrate from deprecated api usage in Coverage script

* Fix bugs preventing 6.9 upgrade

* oops, that shouldn't have been there still

* Fixed old usage of Gradle BOM support (or lack-there-of)

* Fixed some minor gradle consistencies, and added firehorn to gitignore

* Added distribution versioning back

* Explicitly depend on appdistribution-api

Co-authored-by: Yifan Yang <[email protected]>

* Upgrade kotlin version to 1.6.20 (#3762)

* Upgrade kotlin version to 1.6.20

* Upgrade dagger in protoc-gen-firebase-encoders.

* Filter out only release component.

* Add explanation.

* Remove extra log

Co-authored-by: Daymon <[email protected]>
Co-authored-by: Matthew Robertson <[email protected]>
Co-authored-by: Vladimir Kryachko <[email protected]>
Co-authored-by: Yifan Yang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants