Parse NO_CHANGE fetch response for template version #4177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Generated by 🚫 Danger |
qdpham13
changed the title
qdpham13
changed the title
danasilver
approved these changes
Oct 25, 2022
| return new FetchResponse( | ||
| fetchTime, | ||
| Status.BACKEND_HAS_NO_UPDATES, | ||
| /*fetchedConfigs=*/ null, | ||
| /*fetchedConfigs=*/ fetchedConfigs, |
There was a problem hiding this comment.
I might add a comment that we're including the fetchConfigs because they include the template version (even though they don't include the config entries or metadata)
| @@ -167,7 +167,7 @@ public void fetch_noChange_responseNotSet() throws Exception { | |||
| FetchResponse response = fetch(SECOND_ETAG); | |||
|
|
|||
| assertThat(response.getLastFetchETag()).isNull(); | |||
| assertThat(response.getFetchedConfigs()).isNull(); | |||
| assertThat(response.getFetchedConfigs()).isNotNull(); | |||
There was a problem hiding this comment.
Maybe assert it only contains template version?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse NO_CHANGE fetch response for template version. As part of go/realtime-rc-forward-compatibility