Polish new Firestore GA jobs

[wu-hui]

Improvements:

• build is a separate step while result-grepping happens later, build error will fail the job
• a new job check-required-tests is introduced to check the test results at the end of the workflow
• bring back Compatible tests on Firefox

As a result, the new check-required-tests should be marked as "required", it works correctly when

• there is no firestore change, the job will run to success.
• there is firestore build error, or test error, the job will fail.
• all firestore required tests run to success, the job will run to success as well.

[changeset-bot]

⚠️ No Changeset found

Latest commit: fd3a86c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (4decdf6) and merge commit (e9ddf0d).

Test Logs

• Base (4decdf6): https://github.com/firebase/firebase-js-sdk/actions/runs/5884853436
• Merge (e9ddf0d): https://github.com/firebase/firebase-js-sdk/actions/runs/5895074237

1. https://storage.googleapis.com/firebase-sdk-metric-reports/KBXBd5oK1F.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (4decdf6) and merge commit (e9ddf0d).

Test Logs

• Base (4decdf6): https://github.com/firebase/firebase-js-sdk/actions/runs/5884853436
• Merge (e9ddf0d): https://github.com/firebase/firebase-js-sdk/actions/runs/5895074237

1. https://storage.googleapis.com/firebase-sdk-metric-reports/CoxxEhZ0T7.html

[dconeybe]

Some drive-by comments

[dconeybe]

I recommend adding 2>&1 so that stdout and stderr have their lines in the correct relative order.

i.e.

yarn build:changed firestore 2>&1 | ...

[wu-hui]

Apparently this does not work with yarn build:changed for reasons I don't want to find out.

[dconeybe]

Is continue-on-error: false required? Isn't false the default?

[wu-hui]

No required, but I feel safer to keep it there.

[dconeybe]

I don't really like that failure of the egrep command is conflated with the absence of "skipping all" from the output. Is there a more robust way to test for skipping the tests that you can think of?

Update: What about something like this:

skip_count=$(grep --count "Skipping all" test.txt)
echo "skip_count=$skip_count" >> "$GITHUB_OUTPUT"

Then later on you can do something like this:

if: steps.check-changed.outputs.skip_count == 0

[wu-hui]

I think it's more worthwhile to change the script give more explicit result than doing grepping at all...not today though..i had enough github actions work recently.