Skip to content

Merge ds/custom_editor into master #10619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 17, 2020
Merged

Merge ds/custom_editor into master #10619

merged 14 commits into from
Mar 17, 2020

Conversation

DonJayamanne
Copy link

No description provided.

rchiodo and others added 13 commits March 3, 2020 13:30
* custom_editor_update:
  Fix linter
  Reimplement custom editor using new API
* Fix tests
* Revert "Disable proposed api used for custom editor"
This reverts commit e93f77a.
* More fixes
* Don't need that
* Add support for syncing edits
* Allow syncing edits and disabled in old notebook
* Fix formatting
* Fix linter issues
* Share notebook with multiple native editors
* Oops
* Linter fixes
* Disable test
* Fix tests
* Fix linter
* master:
  Fix flakey file system tests (#10541)
  Tweaks for gather (#10532)
  Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517)
  Add conda support to nightly flake test (#10523)
  Rename datascience to datascience_modules (#10525)
  Clean up the extension activation code. (#10455)
  Allow escape and ctrl+U to clear the interactive window (#10513)
  Fix builtins so they don't interfere with our execution (#10511)
  Jupyter autocompletion will only show up on empty lines, (#10420)
  notify on missing kernel and interpreter with kernel (#10508)
* master:
  Rename notebookProvider to notebookEditorProvider (#10564)
* Accomodate upstream VSC changes
* Use weekmap
* Ignore
* No need to dispose
* Refactor
* Remove nb
* Oops
* Add missing imports
* Skip tests
* Fix linter
* master:
  Move redux logging to a different file (#10605)
  Ensure local host only if connection not available (#10600)
  Fix a bunch of debugger issues (#10572)
  Bump acorn from 6.0.0 to 6.4.1 (#10570)
  Resize plot to fit within pdf page (#10547)
  Update dev build instructions to mention "python.insidersChannel"
  Install the ZMQ prebuilt binaries and verify ZMQ works on startup (#10551)
@DonJayamanne DonJayamanne added the no-changelog No news entry required label Mar 17, 2020
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit 7ae360e into master Mar 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
@DonJayamanne DonJayamanne deleted the ds/custom_editor branch June 18, 2020 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants