Skip to content

[library/wsgiref.po] initial partial translation #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 7, 2019
Merged

[library/wsgiref.po] initial partial translation #900

merged 19 commits into from
Dec 7, 2019

Conversation

arthurzenika
Copy link
Contributor

No description provided.

@arthurzenika arthurzenika changed the title [library/wsgiref] initial translation [library/wsgiref] initial partial translation Oct 9, 2019
Seluj78
Seluj78 requested changes Oct 9, 2019
View reviewed changes
arthurzenika and others added 5 commits October 9, 2019 23:47
@arthurzenika @Seluj78
Update library/wsgiref.po
c68389c 
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
@arthurzenika @Seluj78
Update library/wsgiref.po
55d1ded 
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
@arthurzenika @Seluj78
Update library/wsgiref.po
f667de8 
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
@arthurzenika @Seluj78
Update library/wsgiref.po
43f1237 
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
@arthurzenika @Seluj78
Update library/wsgiref.po
b3bbc38 
Co-Authored-By: Jules Lasne (jlasne) <[email protected]>
arthurzenika
arthurzenika commented Oct 9, 2019
View reviewed changes
Copy link
Contributor Author

@arthurzenika arthurzenika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review

awecx
awecx suggested changes Oct 10, 2019
View reviewed changes
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette PR.
Je t'ai noté quelques points qui méritent relecture.

awecx
awecx suggested changes Oct 10, 2019
View reviewed changes
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette PR.
Je t'ai noté quelques points qui méritent relecture.

@arthurzenika
Copy link
Contributor Author

@awecx énorme merci pour cette relecture et les suggestions de corrections !

christopheNan
christopheNan suggested changes Oct 13, 2019
View reviewed changes
@arthurzenika @christopheNan
Apply suggestions from code review
97fde2c 
Co-Authored-By: Christophe Nanteuil <[email protected]>
@JulienPalard
Copy link
Member

Il reste qq points de détails pour pouvoir merger, le « Renvoie une heuristique » et ligne 176—179.

arthurzenika
arthurzenika commented Oct 18, 2019
View reviewed changes
arthurzenika
arthurzenika commented Oct 18, 2019
View reviewed changes
@JulienPalard
Copy link
Member

Quelques souci d'orthographe et de wrapping selon travis:

library/wsgiref.po:46:utiliśee  # Compose key spotted :]
library/wsgiref.po:46:d'environment
library/wsgiref.po:63:wsgi.readthedocs.io
library/wsgiref.po:72:environments
library/wsgiref.po:168:wsgi

JulienPalard
JulienPalard reviewed Oct 20, 2019
View reviewed changes
JulienPalard
JulienPalard requested changes Oct 20, 2019
View reviewed changes
@christopheNan
Copy link
Contributor

Bonjour,
Avant de fusionner ta PR, il manque encore les fautes d'orthographe remontées par travis/pospell et que @JulienPalard t'a indiquées.

@Seluj78
Copy link
Collaborator

Seluj78 commented Nov 15, 2019

@arthurlogilab ping ! :) 🏓

@Seluj78 Seluj78 changed the title [library/wsgiref] initial partial translation [library/wsgiref.po] initial partial translation Nov 17, 2019
awecx
awecx suggested changes Nov 19, 2019
View reviewed changes
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On y est presque, il reste quelques erreurs remontées par pospell.
Je te les ai mises en suggestion , on pourra soumettre ta PR ensuite.
Merci

deronnax
deronnax requested changes Nov 19, 2019
View reviewed changes
vpoulailleau
vpoulailleau suggested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et quelques petites corrections suggérées par padpo.

padpo -p 900

https://github.com/vpoulailleau/padpo/

@arthurzenika @deronnax
@awecx @vpoulailleau
Apply suggestions from code review
13c0a6a 
Co-Authored-By: Mathieu Dupuy <[email protected]>
Co-Authored-By: Antoine <[email protected]>
Co-Authored-By: Vincent Poulailleau <[email protected]>
vpoulailleau
vpoulailleau reviewed Nov 19, 2019
View reviewed changes
@arthurzenika @vpoulailleau
Fix ReST syntax
db1dfc6 
Co-Authored-By: Vincent Poulailleau <[email protected]>
awecx
awecx suggested changes Nov 19, 2019
View reviewed changes
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne sais pas écrire « environnement »...

awecx
awecx suggested changes Nov 21, 2019
View reviewed changes
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas de chance, ça a cassé le wrapping.
Relance powrap sur le code et repush, c'est presque bon.

awecx
awecx suggested changes Nov 21, 2019
View reviewed changes
Copy link

@awecx awecx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'avais pas vu, tu n'as pas pris en compte la remarque de @deronnax :
« et toutes les autres variables WSGI définies dans »
Il te faut soit l'accepter (attention à la taille de la ligne), soit tu résous la conversation avec un commentaire pour expliquer ton choix.
On y est vraiment presque là.

awecx
awecx suggested changes Nov 21, 2019
View reviewed changes
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deux remarques qui ont dû sauter entre deux commits.

@awecx
Copy link

awecx commented Dec 4, 2019

@arthurlogilab on y est presque. Tu peux voir mes remarques et celle de deronnax ?
Je merge la PR après.

arthurzenika and others added 2 commits December 6, 2019 09:19
christopheNan
christopheNan approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon pour merge en ce qui me concerne.

@awecx awecx merged commit d845e09 into python:3.8 Dec 7, 2019
@awecx
Copy link

awecx commented Dec 7, 2019

Merci pour cette PR !

awecx pushed a commit to awecx/python-docs-fr that referenced this pull request Dec 30, 2019
Remarque de deronnax sur PR python#900.
9ed57d4
@awecx awecx mentioned this pull request Dec 30, 2019
Closed
awecx added a commit that referenced this pull request Dec 30, 2019
@awecx
Remarque de deronnax sur PR #900. (#1106)
bd7b9f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPalard JulienPalard JulienPalard requested changes

@vpoulailleau vpoulailleau vpoulailleau requested changes

@awecx awecx awecx approved these changes

@deronnax deronnax deronnax requested changes

@Seluj78 Seluj78 Seluj78 requested changes

@christopheNan christopheNan christopheNan approved these changes

Assignees

@arthurzenika arthurzenika

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arthurzenika @JulienPalard @christopheNan @Seluj78 @awecx @deronnax @vpoulailleau