-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[frontend] Fix use-after-free issue found via ASAN #9335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
DougGregor
wants to merge
535
commits into
swiftlang:master
from
DougGregor:freeContextAndSIL-asan-4.0
Closed
[frontend] Fix use-after-free issue found via ASAN #9335
DougGregor
wants to merge
535
commits into
swiftlang:master
from
DougGregor:freeContextAndSIL-asan-4.0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 040f3ee.
…efault-bridging-pch-on-swift-3.1-branch Revert "[Bridging PCH] Make -enable-bridging-pch the default."
cfe9e6a removed calls to pre/post printing of PrintStructureKind::GenericRequirement, so SourceKit DocInfo requests started droping the markers for generic requirements, causing some weirdness with documentation rendering and post-processing. Restore the calls to printStructPre/Post when printing generic requirements. rdar://problem/30561880
- Remove a test file that made its way in to the original commit. - Don't need a newline forcing wrapper for printStructurePost rdar://problem/30404063
…g-constraint-annotation-swift-3.1 [ASTPrinter] Restore printing generic requirement contexts
…bi_v7k_swift-3.1-branch Fix IRGen abi_v7k test case
…uite. This sets the NeededByPCHOrCompilationUsesPCH language option when emitting a brigding PCH. rdar://problem/30384801
ClangImporter: Adopt for clang change 2b4323722 and unbreak the testsuite.
`URLError.Code` was missing 2 cases, and had 3 more cases implemented as static properties that would crash when accessed. Due to a limitation in the build process, we can't add availability attributes for enum variants past macOS 10.9. This means 4 of the 5 cases are missing availability attributes that they should have.
[swift-3.1-branch][SDK] Turn URLError.Code back into an enum
…erns. The `cmv.getValue() == value` check here seems fishy, since the downstream case block should always take ownership of the bound values. Now that `copy_value`s produce new defs, it's also never true when it would've been true using the `retain/release_value` model, leading us to fail to copy values when necessary.
…he testsuite." This reverts commit 30ed291. It shouldn't have been automerged to swift-4.0-branch in the first place.
[3.1] SILGen: Fix overrelease of pattern bindings shared from multiple patterns.
The inactive list may contain other disjunctions associated with bound type variables. For now, make sure we recover the orphan directly to fix the crash in SR-4056 / rdar://problem/30686926. Later, we can treat these as orphans, too. (cherry picked from commit 99a1396)
[3.1] [Constraint solver] Dont assume orphans are along in the inactive list.
…7-revert-default-bridging-pch-on-swift-3.1-branch Renable "[Bridging PCH] Make -enable-bridging-pch the default.""
…izers. Apply the same is-generic check to initializers that we apply to functions when establishing basic override compatibility. This is a simple optimization for master, but fixes a crasher for Swift 3.1. Fixes SR-4059. (cherry picked from commit f74763d)
[3.1] [Type checker] Teach `areOverrideCompatibleSimple()` to look at initializers
Migrates code that compiles fine in Swift 3 but breaks in Swift 4 due to changes in how the typechecker handles tuple arguments.
Not sure why it is failing there.
…_fix_linkage_private_decls_wmo [swift-4.0-branch] IRGen: Use link_once instead of external for private decls
…-fix-4.0 Referencing encoders should use parent codingPath
…lly-enforced-address-4.0 Fix IRGenSIL to always look through DynamicallyEnforcedAddress.
… IEEE 754 non lossy conversions
… that are caused by SR-4634
…bitPattern in literal cases that could be claimed as double values
…at representations
Fixes a bug in large loadable types wherein only the callee type of Apply is changed
…mismatches-4.0
…ompile() This permits continuing to use the diagnostic engine object from the instance.
…ter names. rdar://30702790
Large loadable types pass: resolves a case wherein a tuple’s extracted type is a function signature
…s are disabled. This commit disables runtime stack trace dumping via dladdr on Darwin when asserts are disabled. This stack trace dumping was added as a way to improve the ability to debug the compiler for compiler developers. This is all well and good but having such a feature always enabled prevents us from reducing the size of the swift standard library by eliminating the swift nlist. rdar://31372220
…_nsnumber SE-0170 cherry pick for swift 4.0
…wift_wrappers. When a swift_wrapper'd type is renamed from Swift 3 -> 4, we create a typealias for it. We need to look through that typealias when deserializing members of that type, e.g., global variables of the swift_wrapper'd type. (cherry picked from commit 5934a86)
…ed-4.0 [Clang importer] Look through typealiases when importing members of swift_wrappers
[strip -ST] Disable runtime stack trace dumping on Darwin when assert…
(cherry picked from commit e6f3af8)
ugh, wrong base branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced via #9260