Merge blazor-wasm -> 3.1 #21921

pranavkm · 2020-05-17T03:45:50Z

No description provided.

…203.1 (#19017) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20103.1

…213.5 (#19034) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20113.5 - Microsoft.DotNet.GenAPI - 1.0.0-beta.20113.5 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.20113.5

…213.1 (#19039) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20113.1

* Add service worker * Add manifest * Bring back BaselineTest.cs * Add baselines for blazorwasm templates * Add publishing test for PWA template * Baseline fixes * Fix baseline test logic to allow for multi-project outputs * Remove non-blazorwasm baselines, since this branch now only covers blazorwasm * Add test for PWA publish output * Beginning generation of assets manifest * Generate assets manifest including blazor outputs * Tweaks * Write assets manifest in JSON form * Publish service worker * Better API * More resilience * Better API again * Make ComputeBlazorAssetsManifestItems public as people will need to customize the list * Exclude service worker files from assets manifest * Use web standard format for hash * Update project template * In assets manifest, only include items being published * Renames * Compute default assets manifest version by combining hashes * Emit sw manifest in .js form * Update service worker in project * Actually isolate browser instances when requested during E2E tests * E2E test for published PWA operating offline * Fix SWAM path in template * Clarify targets

when attempting to enable client debugging on blazor-wasm an attempt to provide a helpful message casues an ¨Unknown OS platform¨ exception relates to #16366 #12970

* Adds a Microsoft.AspNetCore.Components.WebAssembly.Authentication library for performing authentication in Blazor webassembly. * Includes a default implementation that supports OIDC capable IdPs using oidc-client.js * Includes multiple primitives to deal with authentication flows and supports acquiring access tokens to call APIs. * RemoteAuthenticatorView is responsible for handling authentication operations at the user interface level. * RemoteAuthenticatorService is responsible for handling the lower level authentication details by using JavaScript interop to interact with the underlying javascript library implementing the auth protocol. * SignOutSessionStateManager handles CSRF protection for the logout path. * IAccessTokenProvider handles provisioning access tokens to call APIs.

* [Blazor] Adds a project template option for individual auth * Handles hosted scenarios with Identity Server. * Handles non-hosted scenarios with oidc-client.js. * Handles AAD and B2C scenarios with an MSAL library (disabled for now).

Fixes #18384

* Adds additional scenarios to address #17011 * Include commit hash so we can track the build of Blazor WASM associated with a perf run * Port some infrastructure fixes from master Fixes #17011

* Make the dev-server log less * Allow loading a user configured settings file

* [Blazor] Move Blazor to use Static Web Assets * Plugs-in Blazor wasm through the static web assets infrastructure. * Avoids the need for a custom Blazor.config file. * Removes broken auto-rebuild and debug support. * Removes unnecessary server-side Blazor helpers.

* Rename Blazor.Mono -> Components.WebAssembly.Runtime

* Update launchSettings.json for BlazorWASM * Remove the `useWebAssemblyDebugging` setting as its no longer needed

…219.1 (#19167) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.1

…219.2 (#19169) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.2

Move to MapBlazorWebAssemblyApplication as the way to map blazor files into a hosted application.

…19119) * [Blazor][Wasm] Move HttpClient from default services to extension method (#16929) * Apply suggestions from code review Co-authored-by: Steve Sanderson <[email protected]>

…220.1 (#19210) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20120.1

…9198)

Fixes #12059

pranavkm · 2020-05-27T17:16:28Z

@dotnet/aspnet-blazor-eng I made a few quality of improvements along with the change to using the non-sandboxed chrome. These should be the two commits that weren't previously part of the blazor-wasm branch:

Would you mind reviewing those?

@dotnet/aspnet-build could one of you look at the changes to the build infrastructure?

javiercn · 2020-05-27T17:17:42Z

src/Shared/E2ETesting/BrowserFixture.cs

@@ -140,8 +140,11 @@ private async Task<(IWebDriver browser, ILogs log)> CreateBrowserAsync(string co
                opts.AddArgument("--headless");
            }

+            opts.AddArgument("--no-sandbox");


This is fair I think. Do you know of any downsides of doing this?

I couldn't find anything that would affect the test. Here's what chromioum had to say about it: https://chromium.googlesource.com/chromium/src/+/master/docs/design/sandbox_faq.md#What-is-the-sandbox

.azure/pipelines/blazor-daily-tests.yml

* Fix logging config and output redirection in DebugProxy * Log all messages from DebugProxy

wtgodbe · 2020-05-27T17:40:49Z

src/Components/WebAssembly/Build/src/ReferenceBlazorBuildFromSource.props

+<Project>
+  <!--
+  Importing this file is equivalent to having:
+    <PackageDependency Include="Microsoft.AspNetCore.Blazor.Build" />


Nit, should be PackageReference instead of PackageDependency

wtgodbe · 2020-05-27T17:42:39Z

@pranavkm what infra stuff in particular do you want reviewed?

pranavkm · 2020-05-27T17:46:34Z

Anything in the .azure \ eng directories.

dougbu

My comments likely overlap the merge into master, either because I duplicated the comments in #22296 or because I should have duplicated the comments there.

Some comments, especially around build reliability and JSON syntax errors, need to be addressed before merging.

.azure/pipelines/blazor-daily-tests.yml

.config/dotnet-tools.json

...ponents/WebAssembly/Authentication.Msal/src/Microsoft.Authentication.WebAssembly.Msal.csproj

dougbu · 2020-06-08T21:47:43Z

...ly/WebAssemblyHttpHandler/src/Microsoft.AspNetCore.Components.WebAssembly.HttpHandler.csproj

+    <AssemblyVersion>0.2.2.0</AssemblyVersion>
+    <ProduceOnlyReferenceAssembly>true</ProduceOnlyReferenceAssembly>
+    <StrongNameKeyId>Open</StrongNameKeyId>
+    <IsProjectReferenceProvider>false</IsProjectReferenceProvider>


On the $(AssemblyVersion) setting, huh❔

On the $(ProduceOnlyReferenceAssembly) settting, why does this project build a reference assembly at all, let alone only❔

On the $(StrongNameKeyId) setting, signing isn't going to happen inline with our builds in the near future; not sure this will be honoured even now. Probably need to update eng/Signing.props for this ref/ assembly to be correctly signed.

Here, why shouldn't this project and others with this setting be referencable using a @(Reference) item❔

We're shipping a ref assembly for an assembly that ships in WASM in 3.2 since they didn't have the build infrastructure ready and there were some open questions about the package's naming. These values were set to mimic the runtime assembly. Since it's a reference assembly, it's built with using IncludeAssets="Compile" which Reference doesn't appear to support.

Do we expect strong name signing to change in 3.1? This is going away in 5.0, so this isn't a long term problem.

Good point about the signing change being specific to 5.0. I'm still unsure this will work correctly and suggest some thorough validation.

It looked fine when I checked. We also have the option of just referencing the package if we absolutely needed to. The ref assembly is very small - https://github.com/dotnet/aspnetcore/blob/blazor-wasm/src/Components/WebAssembly/WebAssemblyHttpHandler/src/Microsoft.AspNetCore.Components.WebAssembly.HttpHandler.netstandard2.1.cs and isn't really meant to change

Why did we ever ship a ref/ assembly for something outside the shared framework? And, where's the implementation project?

This would be a very useful follow-up item because it doesn't fit w/ how the rest of this branch is built. Plus that needs to change yet-again (removing almost all *.Manual.cs files) soon and you won't get the benefits of the simplified results.

Thanks for the added information. We might be able to use more consistent infrastructure to build this but I leave the priority for that to you and others.

src/ProjectTemplates/ComponentsWebAssembly.ProjectTemplates/.gitignore

...mponents/WebAssembly/testassets/Wasm.Authentication.Shared/Wasm.Authentication.Shared.csproj

src/Components/benchmarkapps/Wasm.Performance/dockerfile

src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj

src/Components/test/E2ETest/e2eTestSettings.json

.azure/pipelines/jobs/default-build.yml

.config/dotnet-tools.json

src/ProjectTemplates/ComponentsWebAssembly.ProjectTemplates/.gitignore

dougbu · 2020-06-09T04:05:14Z

...ly/WebAssemblyHttpHandler/src/Microsoft.AspNetCore.Components.WebAssembly.HttpHandler.csproj

+    <AssemblyVersion>0.2.2.0</AssemblyVersion>
+    <ProduceOnlyReferenceAssembly>true</ProduceOnlyReferenceAssembly>
+    <StrongNameKeyId>Open</StrongNameKeyId>
+    <IsProjectReferenceProvider>false</IsProjectReferenceProvider>


Good point about the signing change being specific to 5.0. I'm still unsure this will work correctly and suggest some thorough validation.

pranavkm · 2020-06-09T06:07:58Z

think I updated the yml files per your instructions. Could you have another look?

…-blazor-wasm

pranavkm · 2020-06-09T23:55:31Z

@dougbu bump.

dougbu · 2020-06-10T00:31:53Z

/ack looking…

dougbu

Works for me. If you want to cover anything unresolved now, party on. Otherwise, ping me and I'll merge for you.

.config/dotnet-tools.json

src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj

dougbu · 2020-06-10T00:48:52Z

...ly/WebAssemblyHttpHandler/src/Microsoft.AspNetCore.Components.WebAssembly.HttpHandler.csproj

+    <AssemblyVersion>0.2.2.0</AssemblyVersion>
+    <ProduceOnlyReferenceAssembly>true</ProduceOnlyReferenceAssembly>
+    <StrongNameKeyId>Open</StrongNameKeyId>
+    <IsProjectReferenceProvider>false</IsProjectReferenceProvider>


Why did we ever ship a ref/ assembly for something outside the shared framework? And, where's the implementation project?

This would be a very useful follow-up item because it doesn't fit w/ how the rest of this branch is built. Plus that needs to change yet-again (removing almost all *.Manual.cs files) soon and you won't get the benefits of the simplified results.

pranavkm · 2020-06-10T01:05:44Z

Why did we ever ship a ref/ assembly for something outside the shared framework? And, where's the implementation project?

Because Mono didn't have the infrastructure and we had to get the feature to our users. The implementation is part of the mono/mono repo.

pranavkm · 2020-06-10T15:45:45Z

@dougbu \ @wtgodbe \ @mkArtakMSFT could one of you merge this for me?

wtgodbe · 2020-06-10T16:28:33Z

@pranavkm merge-commit, right?

pranavkm · 2020-06-10T16:32:05Z

Yes please

dotnet-maestro bot and others added 30 commits February 13, 2020 12:20

Update dependencies from https://github.com/dotnet/blazor build 20200…

074f8fa

…203.1 (#19017) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20103.1

No-op if ValidateComplexType is validated without the right context (#…

fb50111

…18935) Fixes #17316

Update dependencies from https://github.com/dotnet/arcade build 20200…

75ca750

…213.5 (#19034) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20113.5 - Microsoft.DotNet.GenAPI - 1.0.0-beta.20113.5 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.20113.5

Update dependencies from https://github.com/dotnet/blazor build 20200…

52f4636

…213.1 (#19039) - Microsoft.AspNetCore.Blazor.Mono - 3.2.0-preview1.20113.1

allow valid error message to be displayed on linux (#18997)

8fb412e

when attempting to enable client debugging on blazor-wasm an attempt to provide a helpful message casues an ¨Unknown OS platform¨ exception relates to #16366 #12970

Remove ProjectTemplates ownership (#19066)

e0fe30c

Cache assemblies and wasm using content hashes (#18859)

4628dfb

Blazor WebAssembly package renames (#19026)

c935e9a

Fixes #18384

Rename Blazor.Mono -> Components.WebAssembly.Runtime

e521205

Add a perf scenario involing nested components + editing

31f63d9

* Adds additional scenarios to address #17011 * Include commit hash so we can track the build of Blazor WASM associated with a perf run * Port some infrastructure fixes from master Fixes #17011

Make the dev-server log less (#18971)

92409e2

* Make the dev-server log less * Allow loading a user configured settings file

Update WASM Runtime

d90f5ef

Fixup

52c4598

Fix token in PWA manifest

38f3267

Rename Blazor.Mono -> Components.WebAssembly.Runtime (#19124)

1dfbe75

* Rename Blazor.Mono -> Components.WebAssembly.Runtime

Use RTM version of the SDK (#19130)

ffc7279

Update launchSettings.json for BlazorWASM (#19136)

6342a81

* Update launchSettings.json for BlazorWASM * Remove the `useWebAssemblyDebugging` setting as its no longer needed

Update dependencies from https://github.com/dotnet/blazor build 20200…

2f6938e

…219.1 (#19167) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.1

Update dependencies from https://github.com/dotnet/blazor build 20200…

09ee6a7

…219.2 (#19169) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20119.2

[Blazor] Move to MapBlazorWebAssemblyApplication (#19147)

c39bc6a

Move to MapBlazorWebAssemblyApplication as the way to map blazor files into a hosted application.

Only the PWA template should produce ServiceWorkerAssetsManifest

e9ccd7f

[Blazor][Wasm] Move HttpClient from default services to Program.Main (#…

6a85855

…19119) * [Blazor][Wasm] Move HttpClient from default services to extension method (#16929) * Apply suggestions from code review Co-authored-by: Steve Sanderson <[email protected]>

Workaround CacheStorage API bug

06def5c

Update dependencies from https://github.com/dotnet/blazor build 20200…

c5f5325

…220.1 (#19210) - Microsoft.AspNetCore.Components.WebAssembly.Runtime - 3.2.0-preview2.20120.1

Change MapBlazorWebAssemblyApplication to UseBlazorFrameworkFiles (#1…

9ded8e1

…9198)

Fixup RuntimeDependenciesResolver test (#19208)

4715de4

Fixes #12059

Listen to the internet

53edc76

pranavkm force-pushed the prkrishn/merge-blazor-wasm branch from b7c59d4 to 53edc76 Compare May 27, 2020 15:59

javiercn reviewed May 27, 2020

View reviewed changes

wtgodbe reviewed May 27, 2020

View reviewed changes

.azure/pipelines/blazor-daily-tests.yml Outdated Show resolved Hide resolved

jaredpar mentioned this pull request May 27, 2020

OSX machines are de-provisioned during CI / PR runs leading to failures dotnet/runtime#34472

Closed

Fix logging config and output redirection in DebugProxy (#22157)

0394a45

* Fix logging config and output redirection in DebugProxy * Log all messages from DebugProxy

wtgodbe reviewed May 27, 2020

View reviewed changes

pranavkm added the * NO MERGE * Do not merge this PR as long as this label is present. label May 27, 2020

wtgodbe approved these changes May 29, 2020

View reviewed changes

dougbu suggested changes Jun 8, 2020

View reviewed changes

dougbu reviewed Jun 9, 2020

View reviewed changes

Changes per PR

11ac23c

pranavkm force-pushed the prkrishn/merge-blazor-wasm branch from fe8865a to 11ac23c Compare June 9, 2020 05:19

Merge remote-tracking branch 'origin/release/3.1' into prkrishn/merge…

dd62a69

…-blazor-wasm

dougbu approved these changes Jun 10, 2020

View reviewed changes

pranavkm added 2 commits June 9, 2020 19:20

Use randomized ports in dotnet-serve

ae8f67f

Mark Wasm benchmark app as a test asset

b3ad812

pranavkm removed the * NO MERGE * Do not merge this PR as long as this label is present. label Jun 10, 2020

wtgodbe merged commit 432dc97 into release/3.1 Jun 10, 2020

wtgodbe deleted the prkrishn/merge-blazor-wasm branch June 10, 2020 16:32

Merge blazor-wasm -> 3.1 #21921

Merge blazor-wasm -> 3.1 #21921

Uh oh!

Conversation

pranavkm commented May 17, 2020

Uh oh!

pranavkm commented May 27, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wtgodbe commented May 27, 2020

Uh oh!

pranavkm commented May 27, 2020

Uh oh!

dougbu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pranavkm commented Jun 9, 2020

Uh oh!

pranavkm commented Jun 9, 2020

Uh oh!

dougbu commented Jun 10, 2020

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pranavkm commented Jun 10, 2020

Uh oh!

pranavkm commented Jun 10, 2020

Uh oh!

wtgodbe commented Jun 10, 2020

Uh oh!

pranavkm commented Jun 10, 2020

Uh oh!

Uh oh!

dougbu left a comment •

edited

Loading