sync with source repo #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins hooks are not always present, therefore we can't rely on them. Lets rely on not failing for jenkins-ci hooks. This should cover when they are not there due to smart tester, or executed and green. If failed, the condition would be false.
`BufferedSerial` is `UARTSerial` renamed to convey the original purpose of the class. It is the recommended buffered I/O serial class.
ST targets: Replace UARTSerial references with BufferedSerial
NXP target: Replace UARTSerial references with BufferedSerial
ESP8266: Replace UARTSerial references with BufferedSerial
mergify: add fixes to the conditions
Fix UDP socket test cases to check more strictly on failure, and lower trace levels to not print errors on successful cases.
NRF5x targets: Replace UARTSerial references with BufferedSerial
Disable coverage report filtering because of poor results. Test name filtering pattern (-r) was used to filter coverage report causing wrong results when filtered test name wasn't matching the implementation source file name
This reverts commit e4cd938.
Fix UDP socket test cases
SFDP logic is the same between SPIF and QSIP.
This call to sorted does nothing in Python 2, as there is no way to sort a list of Exceptions without providing a key. In Python 3 this call fails with an error as there is no comparison implemented for the jsonschema.exceptions.ValidationError Exception. This is fixed by providing the key str, which sorts by the str representation of the Exception.
…ular Cellular: Replace UARTSerial references with BufferedSerial
RZ_A1H and GR_LYCHEE: Enable bootloader support
Refactor unnecessary functions from cellular driver
…action storage_abstraction: deprecated since Mbed OS 5.5 and now removed
- adds the missing PinMap definitions for UART0, UART1, LEUART0 and LEUART1 - corrects a misplaced `#endif` for `#if DEVICE_SPI` which included `UART_TX` - all according to https://www.silabs.com/documents/public/data-sheets/efm32gg11-datasheet.pdf
…ring unittests: disable coverage report filtering
According to the documentation of STM32F437VG76 MCU: The LSI RC acts as an low-power clock source that can be kept running in Stop and Standby mode for the independent watchdog (IWDG) and Auto-wakeup unit (AWU). The clock frequency is around 32 kHz. For more details, refer to the electrical characteristics section of the datasheets. It seems that typical LSI frequency is 32 kHz, but it may vary from 17 to 47 kHz! This means that lp-timer test may fail on the same board because lp-ticker frequency is unstable.
Make an exception for this target and enable lp-ticker when LSE is not available. This exception is added because of with disabled lp-ticker (and BLE feature) we have the following linker error with ARM compiler: [Error] @0,0: L6218E: Undefined symbol hciCmdAlloc (referred from BUILD/tests/MTB_UBLOX_ODIN_W2/ARM/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/TOOLCHAIN_ARM/libublox-odin-w2-driver.ar(hci_vendor_cmd.o)). [Error] @0,0: L6218E: Undefined symbol hciCmdSend (referred from BUILD/tests/MTB_UBLOX_ODIN_W2/ARM/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/TOOLCHAIN_ARM/libublox-odin-w2-driver.ar(hci_vendor_cmd.o)). It looks like the folloiwng library must be updated: targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/TOOLCHAIN_ARM/libublox-odin-w2-driver.ar
Add a "used" attribute to __vector_handlers to fix ARMC6 build with the "-flto" flag. (Error: L6236E: No section matches selector - no section to be FIRST/LAST.) This attribute, attached to a function/variable, means that code must be emitted for the function even if it appears that the function is not referenced.
Add a "used" attribute to __vector_handlers to fix ARMC6 build with the "-flto" flag. (Error: L6236E: No section matches selector - no section to be FIRST/LAST. ) This attribute, attached to a function/variable, means that code must be emitted for the function even if it appears that the function is not referenced.
…LTO builds Add a "used" attribute to SVCHandler_main/tfm_pendsv_do_schedule to fix ARMC6 build with the "-flto" flag. This attribute, attached to a function/variable, means that code must be emitted for the function even if it appears that the function is not referenced.
…read In STM32 Cube HAL, in interrupt mode (async), 2 bytes can be prepared in hardware registers without any read (1 in regular register, the other in shift register), but Only 1 RX byte can stored in hardware register, specially when there is no hardware FIFO. If interrupt handling is fast enough, each read is made in parralele of the write. But if interrupt handling is too long or is interrupted for too long, it can happen that one read byte is lost (overrun). For STM32F4, Tickless has been deactivated to avoid such issue. For STM32L0, we don't want to deactivate tickless, because those chips are specially design for lowpower. So instead of removing SPI async mode, we propose to change the HAL behavior specially for L0: each byte is send only when previous read is performed. Thus only 1 RX byte at a time which is saved in hardware register. This prevent overrun, but it introduceS some latency between each byte send, this is why it is not applied to all STM32 families.
Check if release review is not applied for merged PR. If not, we use "release version missing" label.
…_SETTINGS TARGET_STM32F1: don't set ADC common register when ADC doesn't support it
MXRT1050 Flash support
Mergify: fix release version label
Signed-off-by: Mahesh Mahadevan <[email protected]>
1. Enable GCC support on non-secure targets 2. Disable GCC support on secure targets becasue of GCC bug (as of 9-2019-q4-major): In non-secure entry function, callee-saved registers must be restored, but they are incorrectly cleared at optimization level "Os".
1. Re-organize to make clear for all targets/toolchains support in single startup file 2. Inline assembly syntax is limited, esp. on IAR. Try paving the way for accessing external symbols still in inline assembly instead of re-write in assembly.
The changes are based on the scatter file in TOOLCHAIN_ARM_MICRO
TARGET_STM: L0 CUBE SPI async mode send next byte after previous one is read
LPC1768: Fix ARM toolchain baremetal by defining 2 memory region
M2351: Support GCC
Update cellular drivers/tests for UBLOX_C030_R412M
…2361 OKDO_ODIN_W2: Reenable lp-ticker and BLE
…or_release ARMC6: Add a build profile extension with the link-time optimizer enabled
Cellular: Remove friend definitions from cellular state machine
ONME-3433 ESP8266 driver support for UDP get - modified ESP8266 drive…
MXRT1050: Add bootloader support
…aders BUGFIX: SFDP Sector Map Table Parameter ID LSB is 0x81
Update psoc6cm0p asset to 1.1.0
Cellular: Remove API's empty default implemetations
AlvinZhou97
pushed a commit
that referenced
this pull request
Jun 22, 2021
Many test stub functions are meant to return a value, but weren't. Clang
would generate a warning for each instance where we weren't returning
anything in a function that was meant to return a value.
warning: non-void function does not return a value [-Wreturn-type]
For a specific example, my_radio::time_on_air() is supposed to return a
uint32_t, but wasn't returning anything. We'll return a zero instead of
relying on undefined behavior.
Without this, clang 11.0.1 was generating a virtual function
implementation with a `ud2` instruction to abort at run-time, causing
some execution of some unit tests to abort.
Running main() from gmock_main.cc
[==========] Running 10 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 10 tests from Test_LoRaPHYUS915
[ RUN ] Test_LoRaPHYUS915.constructor
[ OK ] Test_LoRaPHYUS915.constructor (0 ms)
[ RUN ] Test_LoRaPHYUS915.restore_default_channels
[ OK ] Test_LoRaPHYUS915.restore_default_channels (0 ms)
[ RUN ] Test_LoRaPHYUS915.rx_config
[ OK ] Test_LoRaPHYUS915.rx_config (0 ms)
[ RUN ] Test_LoRaPHYUS915.tx_config
Process 35669 stopped
* thread #1, name = 'lorawan-loraphy-', stop reason = signal SIGILL: privileged instruction
frame #0: 0x0000000000276f73 lorawan-loraphy-us915-unittest`my_radio::time_on_air(this=0x0000000800c2b048, modem=MODEM_LORA, pkt_len='\0') at Test_LoRaPHYUS915.cpp:90:5
87 };
88
89 virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len)
-> 90 {
91 };
92
93 virtual bool perform_carrier_sense(radio_modems_t modem,
(lldb) disassemble --pc
lorawan-loraphy-us915-unittest`my_radio::time_on_air:
-> 0x276f73 <+67>: ud2
0x276f75: int3
0x276f76: int3
0x276f77: int3
(lldb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers