Feature emac merge test #6635

kjbracey · 2018-04-13T12:41:27Z

Description

This is a dummy test merge - operation was actually performed as a rebase, and will be pushed as such. This contains the same final tree contents as my current proposed rebase, and hopefully gitk will show a semi-legible diff for the bits touched in the merge commit.

Actual rebased feature-emac is at https://github.com/kjbracey-arm/mbed-os/commits/feature-emac - when this passes CI, I will force push that to feature-emac.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Cellular: BC95 echo test fixes

STM32 LPTICKER : optimize RTC wake up timer init

dir seek fixed - dptr was not updated before checking

Cellular: update attach test

littlefs: Fix issue updating dir struct when extended dir chain

Corrected lwip adaptation TCP flagging

NUCLEO_L433RC_P: fix pins definitions

Update mbed-coap to version 4.4.0

Update for VK_RZ_A1H

LoRa refactoring

- Only internal changes, no functionality changes - Some minor improvements to LoRaWanStack

… instead of a boolean Removed the while loop checking the return value from set_next_channel (GitHub Issue Lora-net/LoRaMac-node#357) The new return values are: LORAWAN_STATUS_OK : A channel has been found. LORAWAN_STATUS_NO_FREE_CHANNEL_FOUND : No free channel has been found (AS923 and KR920 regions) LORAWAN_STATUS_DUTYCYCLE_RESTRICTED : No channel found due to the duty-cycle or JoinReq back-off restrictions. Trial must be delayed. LORAWAN_STATUS_NO_CHANNEL_FOUND : No channel has been found. Re-enabled the default channels.

This issue is only present for a device in class c mode, which has perform unconfirmed uplinks. Lora-net/LoRaMac-node#327

Store the rx slot temporarily. When in class C, this variable will be changed in function OpenContinuousRx2Window.

Perform only an assignment. Lora-net/LoRaMac-node#282

1. Do not stop the 2nd window timer, as it is not running. 2. Wait for the OnAckTimeout event, before setting MacDone 3. Process for class c also the 2nd window timeout part, as we do not have a 2nd window timer.

This is especially important for class c devices.

In the DevStatusAns format, the protocol requires RFU(7:6) value = 0

Lora-net/LoRaMac-node#362

This API can be used to runtime change device class. Please note that only class A and C are supported at the moment. Trying to set class B will return LORAWAN_STATUS_UNSUPPORTED. Fix set_device_class documentation fix documentation

- Do not put radio into sleep when message is received in class c mode - Experimental feature for acknowledging confirmed downlink messages

Since our timers are now already using events, we no longer need to defer timer callback calls.

- This is internal change, no functionality has been changed - LoRaWanInterface cleaned up and code moved to LoRaMacStack - Compliance code in LoRaMacStack moved to EOF - Green tea tests have been run manually - Doxygen updated accordingly LoRA: reorder class members

CM3DS Maintenance Pull Request: TRNG support (3/4)

Lora: small fixes

PR template: fix tick definition

This is a dummy test merge - operation was actually performed as a rebase, and will be pushed as such. This contains the same final tree contents as my current proposed rebase, and hopefully gitk will show a semi-legible diff for the bits touched in the merge commit.

kjbracey · 2018-04-13T14:01:19Z

/morph build

mbed-ci · 2018-04-13T14:34:46Z

Build : SUCCESS

Build number : 1746
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6635/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-04-14T01:02:31Z

Exporter Build : SUCCESS

Build number : 1381
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6635/

mbed-ci · 2018-04-14T08:16:29Z

Test : FAILURE

Build number : 1549
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6635/1549

kjbracey · 2018-04-16T08:42:07Z

/morph build

mbed-ci · 2018-04-16T09:06:48Z

Build : SUCCESS

Build number : 1753
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6635/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mikaleppanen · 2018-04-16T11:45:05Z

I'll add review comments here rather than trying to find the correct files.

One finding:

"EMACInterface.cpp": missing "_mac_address" initialization here:

/* Interface implementation */
EMACInterface::EMACInterface(EMAC &emac, OnboardNetworkStack &stack) :
_emac(emac),
_stack(stack),
_interface(NULL),
_dhcp(true),
_ip_address(),
_netmask(),
_gateway()
{
}

kjbracey · 2018-04-16T11:57:20Z

Hmm, don't think _mac_address needs initialisation - it's just an output buffer for the get_mac_address method.

Although checking that highlights that _netmask, _ip_address and _gateway are doing dual duty as output buffers for the get calls and storage buffers for set_network->connect. I guess that's always been the case, but a little weird.

mbed-ci · 2018-04-16T12:51:40Z

Exporter Build : FAILURE

Build number : 1390
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6635/

mbed-ci · 2018-04-16T12:52:16Z

Test : SUCCESS

Build number : 1558
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6635/1558

kjbracey · 2018-04-17T06:07:26Z

/morph export-build

mbed-ci · 2018-04-17T13:58:48Z

Exporter Build : SUCCESS

Build number : 1406
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6635/

kjbracey · 2018-04-18T06:29:41Z

Okay, I'm pushing this tree to feature-emac as a rebase.

That rebase also squashes together a couple of minor fixups, reducing the branch length from 40 to 31 commits.

Original branch: 646efbd
Rebased partially-squashed branch: 597d3cb

kjbracey · 2018-04-18T09:02:13Z

Unpleasant GitHub feature - having closed without asking GitHub to do the merge, the test results appear to have vanished.

cmonr and others added 30 commits March 20, 2018 14:06

Merge pull request ARMmbed#6291 from mirelachirica/bc95_echotest_fixes

7b2ee2d

Cellular: BC95 echo test fixes

Merge pull request ARMmbed#6370 from jeromecoutant/PR_LPT_RTC_OPTIM

d7dfab5

STM32 LPTICKER : optimize RTC wake up timer init

Merge pull request ARMmbed#6363 from deepikabhavnani/seek_fix

a3d8c8f

dir seek fixed - dptr was not updated before checking

Merge pull request ARMmbed#6350 from u-blox/cellular_test

53adeed

Cellular: update attach test

Merge pull request ARMmbed#6338 from geky/fix-littlefs-dir-chain

7ab4b06

littlefs: Fix issue updating dir struct when extended dir chain

Merge pull request ARMmbed#6333 from mikaleppanen/lwip_tcp_flag_corr

0b7a9a9

Corrected lwip adaptation TCP flagging

Merge pull request ARMmbed#6330 from bcostm/fix_pins_nucleo_l433rc_p

6cb6dd9

NUCLEO_L433RC_P: fix pins definitions

Merge pull request ARMmbed#6357 from anttiylitokola/master

f3e2a3d

Update mbed-coap to version 4.4.0

Merge pull request ARMmbed#6245 from mbedNoobNinja/Sync_PR

2c7f909

Update for VK_RZ_A1H

Merge pull request ARMmbed#6279 from AnttiKauppila/master

53cb6e0

LoRa refactoring

Add an option to use LowPowerTimer for poll

2e9ff47

LoRa: LoRaWANInterface refactored.

a294aa0

- Only internal changes, no functionality changes - Some minor improvements to LoRaWanStack

Ensure DR_6 cannot be selected for IN865 region

339306e

Fix an issue with sequence calls.

6114f2b

This issue is only present for a device in class c mode, which has perform unconfirmed uplinks. Lora-net/LoRaMac-node#327

Do only set the MacDone if the MAC is not in class c

fc1696b

Fix rx slot handling

c1ea418

Store the rx slot temporarily. When in class C, this variable will be changed in function OpenContinuousRx2Window.

Fix calculation of the aggregated time-off.

256a3a5

Perform only an assignment. Lora-net/LoRaMac-node#282

Add the possibility to set the default antenna gain.

591bc7d

Bug fix in RX timeout and RX error handling for class c nodes.

a9e1076

1. Do not stop the 2nd window timer, as it is not running. 2. Wait for the OnAckTimeout event, before setting MacDone 3. Process for class c also the 2nd window timeout part, as we do not have a 2nd window timer.

Remove unused is_fPort_allowed method

e097429

Changed mcps confirmation ul_frequency to channel

6c165e0

Update handling for functions OnRadioRxError and OnRadioRxTimout.

e1fff2e

This is especially important for class c devices.

Update DevStatusAnd format

65b2dbc

In the DevStatusAns format, the protocol requires RFU(7:6) value = 0

Change minimum required channels from 6 to 2 (US915Hybrid)

4aba343

Lora-net/LoRaMac-node#362

Fix reception of class C messages

32075b9

- Do not put radio into sleep when message is received in class c mode - Experimental feature for acknowledging confirmed downlink messages

Simplify check for pending bit

c6eee4f

Remove redundant event from timer callbacks

fe225a8

Since our timers are now already using events, we no longer need to defer timer callback calls.

Cruz Monrreal and others added 5 commits April 12, 2018 18:38

Merge pull request ARMmbed#6169 from hug-dev/cm3ds-trng

641e814

CM3DS Maintenance Pull Request: TRNG support (3/4)

Merge pull request ARMmbed#6569 from kivaisan/LORAWAN_FEATURE_BRANCH

68ebbb0

Lora: small fixes

Merge pull request ARMmbed#6619 from 0xc0170/fix_pr_x

cabef4d

PR template: fix tick definition

fixup! Nanostack EMAC implementation

03be19e

0xc0170 added the do not merge label Apr 13, 2018

kjbracey requested review from mikaleppanen and jarlamsa April 13, 2018 13:05

kjbracey added 2 commits April 13, 2018 16:24

fixup! Networking update: general refactoring, unifying EMAC

8a259eb

fixup! Networking update: general refactoring, unifying EMAC

7e1c789

fixup! Networking update: general refactoring, unifying EMAC

722db40

mikaleppanen approved these changes Apr 16, 2018

View reviewed changes

jarlamsa approved these changes Apr 17, 2018

View reviewed changes

kjbracey closed this Apr 18, 2018

sg- removed the do not merge label Apr 18, 2018

kjbracey mentioned this pull request May 8, 2018

Feature emac merge test (again) #6837

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature emac merge test #6635

Feature emac merge test #6635

Uh oh!

kjbracey commented Apr 13, 2018 •

edited

Loading

Uh oh!

kjbracey commented Apr 13, 2018

Uh oh!

mbed-ci commented Apr 13, 2018

Uh oh!

mbed-ci commented Apr 14, 2018

Uh oh!

mbed-ci commented Apr 14, 2018

Uh oh!

kjbracey commented Apr 16, 2018

Uh oh!

mbed-ci commented Apr 16, 2018

Uh oh!

mikaleppanen commented Apr 16, 2018

Uh oh!

kjbracey commented Apr 16, 2018

Uh oh!

mbed-ci commented Apr 16, 2018

Uh oh!

mbed-ci commented Apr 16, 2018

Uh oh!

kjbracey commented Apr 17, 2018

Uh oh!

mbed-ci commented Apr 17, 2018

Uh oh!

kjbracey commented Apr 18, 2018 •

edited

Loading

Uh oh!

kjbracey commented Apr 18, 2018

Uh oh!

Uh oh!

Feature emac merge test #6635

Feature emac merge test #6635

Uh oh!

Conversation

kjbracey commented Apr 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

kjbracey commented Apr 13, 2018

Uh oh!

mbed-ci commented Apr 13, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Apr 14, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Apr 14, 2018

Test : FAILURE

Uh oh!

kjbracey commented Apr 16, 2018

Uh oh!

mbed-ci commented Apr 16, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mikaleppanen commented Apr 16, 2018

Uh oh!

kjbracey commented Apr 16, 2018

Uh oh!

mbed-ci commented Apr 16, 2018

Exporter Build : FAILURE

Uh oh!

mbed-ci commented Apr 16, 2018

Test : SUCCESS

Uh oh!

kjbracey commented Apr 17, 2018

Uh oh!

mbed-ci commented Apr 17, 2018

Exporter Build : SUCCESS

Uh oh!

kjbracey commented Apr 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kjbracey commented Apr 18, 2018

Uh oh!

Uh oh!

kjbracey commented Apr 13, 2018 •

edited

Loading

kjbracey commented Apr 18, 2018 •

edited

Loading