generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 43
Merging feature branch - 23.0.0 into main #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* backporting 7497 Netbeans PR * Additional registration needed to provider Java default platform override. * updated configuration * README updated * update README --------- Co-authored-by: Jan Lahoda <[email protected]>
In NB23, [patch #7390](apache/netbeans/pull/7390) fixed the regression where the newly created exception from template did not extend Exception, thereby failing to compile. This temporarily backports the fix until NB23 is incorporated. Signed-off-by: Siddharth Srinivasan <[email protected]>
This version of Gradle brings full JDK23 support. - Manually verified `shasum` of the gradle-tooling-api-8.10.jar recorded in the *extide/libs.gradle/external/binaries-list* file. - Especially important since this PR is still not approved. - BA available. Signed-off-by: Siddharth Srinivasan <[email protected]>
* Fix for delete cache error on windows * Added error handling * Declared constant for windows os label * Refactored code to use await and try catch pattern * Fixed indent
Backport NB patch apache/netbeans#7690 for Gradle tooling 8.10 upgrade
Upgrade to NB-23
#251) **Changes** 1. Added a launch-time JVM property for the netbeans LSP server "project.limitScanRoot", with its value set to the user's home directory path and the workspace folders, if any. - This is obtained using Node's `os.homedir()` function in *nbcode.ts* - Multiple paths are delimited by the OS-specific separator. 2. Added a configuration property "jdk.advanced.disable.projectSearchLimit" which can be used to turn off this new behaviour. **Reasons** - NetBeans supports searching for the build project information in the ancestor directories of the file or folder opened in a workspace. - Thus, NetBeans `org.netbeans.modules.projectapi.SimpleFileOwnerQueryImplementation` supports a JVM launch property (i.e. System property) called **project.limitScanRoot**. - This prevents searching for the build project information when the opened file or folder is outside this specified path. Signed-off-by: Siddharth Srinivasan <[email protected]>
Awaiting BA for NB-rc3. That will be merged via PR #259. This reverts commit a6ce838, reversing changes made to b124094. Signed-off-by: Siddharth Srinivasan <[email protected]>
Refactored JDK Downloader
Remove redudant images
Signed-off-by: Subhash Arabhi <[email protected]>
Patch for unwanted imports bug from NB
Signed-off-by: Subhash Arabhi <[email protected]>
Patch for renaming comments bug
[JAVSCODE-253] adding/updating few language keys and some minor corrections
Upgrade to nb-23-rc3
Correctly pick configuration from launch settings during run and debug sessions
Doing some code cleanup and refactoring
[JAVSCODE-253] enabling nb support for localisation
JDK 23 download option added in JDK Downloader
[JAVSCODE-253] enabling nb support for localisation
sid-srini
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging feature branch 23.0.0 into main