Skip to content

Merging feature branch - 23.0.0 into main #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Sep 17, 2024
Merged

Merging feature branch - 23.0.0 into main #275

merged 30 commits into from
Sep 17, 2024

Conversation

Achal1607
Copy link
Member

Merging feature branch 23.0.0 into main

Achal1607 and others added 30 commits August 26, 2024 11:15
* backporting 7497 Netbeans PR

* Additional registration needed to provider Java default platform override.

* updated configuration

* README updated

* update README

---------

Co-authored-by: Jan Lahoda <[email protected]>
In NB23, [patch #7390](apache/netbeans/pull/7390) fixed the regression
where the newly created exception from template did not extend
Exception, thereby failing to compile.

This temporarily backports the fix until NB23 is incorporated.

Signed-off-by: Siddharth Srinivasan <[email protected]>
This version of Gradle brings full JDK23 support.

- Manually verified `shasum` of the gradle-tooling-api-8.10.jar recorded
  in the *extide/libs.gradle/external/binaries-list* file.
    - Especially important since this PR is still not approved.

- BA available.

Signed-off-by: Siddharth Srinivasan <[email protected]>
* Fix for delete cache error on windows

* Added error handling

* Declared constant for windows os label

* Refactored code to use await and try catch pattern

* Fixed  indent
Backport NB patch apache/netbeans#7690 for Gradle tooling 8.10 upgrade
#251)

**Changes**
1. Added a launch-time JVM property for the netbeans LSP server
    "project.limitScanRoot", with its value set to the user's home
    directory path and the workspace folders, if any.
    - This is obtained using Node's `os.homedir()` function in *nbcode.ts*
    - Multiple paths are delimited by the OS-specific separator.
2. Added a configuration property "jdk.advanced.disable.projectSearchLimit"
   which can be used to turn off this new behaviour.

**Reasons**
- NetBeans supports searching for the build project information in the
  ancestor directories of the file or folder opened in a workspace.
- Thus, NetBeans `org.netbeans.modules.projectapi.SimpleFileOwnerQueryImplementation`
  supports a JVM launch property (i.e. System property) called **project.limitScanRoot**.
- This prevents searching for the build project information when the
  opened file or folder is outside this specified path.

Signed-off-by: Siddharth Srinivasan <[email protected]>
Awaiting BA for NB-rc3. That will be merged via PR #259.

This reverts commit a6ce838, reversing
changes made to b124094.

Signed-off-by: Siddharth Srinivasan <[email protected]>
Patch for unwanted imports bug from NB
Signed-off-by: Subhash Arabhi <[email protected]>
[JAVSCODE-253] adding/updating few language keys and some minor corrections
Correctly pick configuration from launch settings during run and debug sessions
Doing some code cleanup and refactoring
[JAVSCODE-253] enabling nb support for localisation
JDK 23 download option added in JDK Downloader
[JAVSCODE-253] enabling nb support for localisation
@Achal1607 Achal1607 requested a review from sid-srini September 17, 2024 15:58
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 17, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@Achal1607 Achal1607 merged commit 9191366 into main Sep 17, 2024
4 checks passed
@sid-srini sid-srini added this to the JVSC 23.0.0 milestone Sep 18, 2024
@Achal1607 Achal1607 deleted the 23.0.0 branch September 20, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants