This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Better clean up after state changes #61890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 15, 2024
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
c34062f to
e0d352d
Compare
eseliger
force-pushed
the
es/04-13-gitserverbettercleanupafterstatechanges
branch
from
5fb42ba to
9afe418
Compare
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
e0d352d to
ef4b95b
Compare
eseliger
force-pushed
the
es/04-13-gitserverbettercleanupafterstatechanges
branch
from
9afe418 to
212a062
Compare
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
2 times, most recently
from
21c9dbe to
2ea4046
Compare
eseliger
force-pushed
the
es/04-13-gitserverbettercleanupafterstatechanges
branch
2 times, most recently
from
8be01d9 to
ab7d551
Compare
eseliger
changed the base branch from
es/04-11-gitserverextractrepositoryserviceingrpc
to
es/04-13-gitserverstreamfetchprogress
eseliger
force-pushed
the
es/04-13-gitserverstreamfetchprogress
branch
from
25801f0 to
cc6cbd6
Compare
eseliger
force-pushed
the
es/04-13-gitserverbettercleanupafterstatechanges
branch
from
ab7d551 to
4209430
Compare
eseliger
force-pushed
the
es/04-13-gitserverstreamfetchprogress
branch
from
cc6cbd6 to
f2d1857
Compare
eseliger
force-pushed
the
es/04-13-gitserverbettercleanupafterstatechanges
branch
from
4209430 to
f79e9d0
Compare
The database is not super clean when we do state changes, for example we keep the repo size after marking as not cloned, and keep shard assignments, too. This PR splits those operations into three, and resets more rows. Test plan: Cloning and tests around clone status calls are still passing.
eseliger
force-pushed
the
es/04-13-gitserverstreamfetchprogress
branch
from
f2d1857 to
c6b1485
Compare
eseliger
force-pushed
the
es/04-13-gitserverbettercleanupafterstatechanges
branch
from
f79e9d0 to
f9d6775
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database is not super clean when we do state changes, for example we keep the repo size after marking as not cloned, and keep shard assignments, too.
This PR splits those operations into three, and resets more rows.
Test plan:
Cloning and tests around clone status calls are still passing.