This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Remove revspec updates #61861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2024
github-actions
bot
added
team/product-platform
team/source
This was referenced Apr 13, 2024
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
bfe36b0 to
10821e8
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
f293c54 to
b7be81e
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
10821e8 to
234d9cb
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
b7be81e to
33e6836
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
234d9cb to
0f26c76
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
33e6836 to
a02ce85
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
0f26c76 to
266ff89
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
a02ce85 to
c6b7976
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
266ff89 to
f1dd99d
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
c6b7976 to
d25fd28
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
f1dd99d to
539175c
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
d25fd28 to
e95fb31
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
539175c to
9e00e68
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
e95fb31 to
8b15348
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
9e00e68 to
4bac598
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
8b15348 to
b7229ac
Compare
pjlast
approved these changes
Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
4bac598 to
49fa32a
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
b7229ac to
93a5056
Compare
This was referenced Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
49fa32a to
a3cde3f
Compare
Base automatically changed from
es/04-13-gitserversimplifycloneandupdate
to
main
April 18, 2024 21:34
Revspec updates never worked reliably. When there was _any_ operation in flight, we would just not fetch this revspec and return "all good". This is only used by packages, an experimental feature. Gitserver should not modify the authoritative data source for what versions exist. Instead, callers should add the version to the list of desired versions, and they'll eventually be part of the package when the next fetch occurred. Anyhow, experimental, didn't work reliably, will be removed for now. Test plan: Existing test suites.
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
93a5056 to
15e2615
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revspec updates never worked reliably. When there was any operation in flight, we would just not fetch this revspec and return "all good".
This is only used by packages, an experimental feature.
Gitserver should not modify the authoritative data source for what versions exist. Instead, callers should add the version to the list of desired versions, and they'll eventually be part of the package when the next fetch occurred.
Anyhow, experimental, didn't work reliably, will be removed for now.
Test plan:
Existing test suites.