This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Simplify clone and update #61860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2024
This was referenced Apr 13, 2024
github-actions
bot
added
team/product-platform
team/source
This was referenced Apr 13, 2024
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
b3406cc to
e58bcc0
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
bfe36b0 to
10821e8
Compare
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
e58bcc0 to
0ec6a10
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
2 times, most recently
from
234d9cb to
0f26c76
Compare
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
0ec6a10 to
d63cb3c
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
0f26c76 to
266ff89
Compare
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
d63cb3c to
c70f9bb
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
266ff89 to
f1dd99d
Compare
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
c70f9bb to
26fe870
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
f1dd99d to
539175c
Compare
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
26fe870 to
1f6abf3
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
539175c to
9e00e68
Compare
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
1f6abf3 to
3b622df
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
9e00e68 to
4bac598
Compare
pjlast
approved these changes
Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
3b622df to
12a8301
Compare
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
4bac598 to
49fa32a
Compare
This was referenced Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitservermovesearchobservability
branch
from
12a8301 to
fc03429
Compare
Base automatically changed from
es/04-13-gitservermovesearchobservability
to
main
April 18, 2024 21:21
Those two used to have separate mechanisms for locking and for making sure the operation keeps going in the background. This PR unifies those two where possible. Test plan: The clone test covers this pretty well, and I made a few adjustments there to cover the new behavior. Also, E2E tests will cover clone failures.
eseliger
force-pushed
the
es/04-13-gitserversimplifycloneandupdate
branch
from
49fa32a to
a3cde3f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those two used to have separate mechanisms for locking and for making sure the operation keeps going in the background.
This PR unifies those two where possible.
Test plan:
The clone test covers this pretty well, and I made a few adjustments there to cover the new behavior.
Also, E2E tests will cover clone failures.