Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: Add progressWriter to VCS fetch #61863

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

eseliger
Copy link
Member

@eseliger eseliger commented Apr 13, 2024

Clone already did this, now Fetch does the same.

This will allow to also get access to the progress while it's happening, not only afterwards.

Test plan:

Existing clone / update tests still pass.

@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Apr 13, 2024
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from f90543d to a054bee Compare April 13, 2024 23:36
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 2a48f47 to 073193e Compare April 13, 2024 23:54
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from a054bee to 89872f2 Compare April 13, 2024 23:54
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 073193e to 5483b47 Compare April 14, 2024 00:07
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from 89872f2 to e2fb9c3 Compare April 14, 2024 00:07
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 5483b47 to 5bc8e6e Compare April 14, 2024 00:30
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from e2fb9c3 to 6fe688a Compare April 14, 2024 00:30
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 5bc8e6e to f15783d Compare April 15, 2024 13:43
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from 6fe688a to dfaf5a5 Compare April 15, 2024 13:43
@eseliger eseliger marked this pull request as ready for review April 15, 2024 13:48
@eseliger eseliger requested a review from a team April 15, 2024 13:48
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from f15783d to 72c90b8 Compare April 15, 2024 17:21
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from dfaf5a5 to 2f7f7c5 Compare April 15, 2024 17:21
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 72c90b8 to 517fd22 Compare April 15, 2024 19:18
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from 2f7f7c5 to f79fd7f Compare April 15, 2024 19:18
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 517fd22 to e175e8a Compare April 17, 2024 14:21
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from f79fd7f to dfc6fe7 Compare April 17, 2024 14:21
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from e175e8a to 553f38e Compare April 17, 2024 20:37
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from dfc6fe7 to 1bf9f38 Compare April 17, 2024 20:37
Copy link
Contributor

@pjlast pjlast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woop woop!

@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 553f38e to 5622107 Compare April 18, 2024 14:53
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from 1bf9f38 to 21dbb90 Compare April 18, 2024 14:53
@eseliger eseliger force-pushed the es/04-13-gitserverclarifywhatrepositorylockindicates branch from 5622107 to 7d83bb9 Compare April 18, 2024 21:49
Base automatically changed from es/04-13-gitserverclarifywhatrepositorylockindicates to main April 18, 2024 22:00
Clone already did this, now Fetch does the same.

This will allow to also get access to the progress while it's happening, not only afterwards.

Test plan:

Existing clone / update tests still pass.
@eseliger eseliger force-pushed the es/04-13-gitserveraddprogresswritertovcsfetch branch from 21dbb90 to 934e08f Compare April 18, 2024 22:01
Copy link
Member Author

eseliger commented Apr 18, 2024

Merge activity

  • Apr 18, 6:02 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Apr 18, 6:14 PM EDT: @eseliger merged this pull request with Graphite.

@eseliger eseliger merged commit 24a6cae into main Apr 18, 2024
@eseliger eseliger deleted the es/04-13-gitserveraddprogresswritertovcsfetch branch April 18, 2024 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants