This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Move subrepoperms checks back to client #62022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While starting this migration, it felt nice to move sub repo permission checks to the server side, because that means we can make certain optimizations and none of the clients need to reimplement the SRP checker implementation.
However, this moves sub repo authz over the wire, but doesn't move repo perms generally here, so this was a weird split.
This also unnecessarily couples Sourcegraph and gitserver, so for now this is going back into the client layer, like all the auth checks.
Please make sure to pay good attention to the backend and client implementation and help me validate that those are indeed equal.
Test plan:
Added tests, E2E perforce subrepo perms tests are still passing.