This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Clean up output redaction #61857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
This was referenced Apr 13, 2024
This was referenced Apr 13, 2024
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
c40db4e to
7537830
Compare
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
7a096d3 to
a9dbedb
Compare
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
7537830 to
b06fcb3
Compare
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
a9dbedb to
5a4d1fb
Compare
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
b06fcb3 to
7d18ccd
Compare
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
5a4d1fb to
8c0211a
Compare
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
7d18ccd to
0d8b67f
Compare
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
8c0211a to
5799bcd
Compare
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
0d8b67f to
a7116f7
Compare
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
5799bcd to
8d07032
Compare
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
a7116f7 to
4d0356b
Compare
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
8d07032 to
ca202a7
Compare
pjlast
approved these changes
Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
4d0356b to
ee2ad20
Compare
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
ca202a7 to
5e42655
Compare
This was referenced Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitservertestforrepodir
branch
from
ee2ad20 to
b0e31c8
Compare
Since we refactored VCSSyncer recently to take control of the remote URL, we now do redaction at this layer, so this TODO comment can be removed. Test plan: E2E test suite still passes.
eseliger
force-pushed
the
es/04-13-gitservercleanupoutputredaction
branch
from
5e42655 to
c81ef49
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we refactored VCSSyncer recently to take control of the remote URL, we now do redaction at this layer, so this TODO comment can be removed.
Test plan:
E2E test suite still passes.