This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Clarify what RepositoryLock indicates #61862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2024
This was referenced Apr 13, 2024
github-actions
bot
added
team/product-platform
team/source
This was referenced Apr 13, 2024
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
f293c54 to
b7be81e
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
2a48f47 to
073193e
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
b7be81e to
33e6836
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
073193e to
5483b47
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
33e6836 to
a02ce85
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
5483b47 to
5bc8e6e
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
a02ce85 to
c6b7976
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
5bc8e6e to
f15783d
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
c6b7976 to
d25fd28
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
f15783d to
72c90b8
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
d25fd28 to
e95fb31
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
72c90b8 to
517fd22
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
e95fb31 to
8b15348
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
517fd22 to
e175e8a
Compare
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
8b15348 to
b7229ac
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
e175e8a to
553f38e
Compare
pjlast
reviewed
Apr 18, 2024
pjlast
approved these changes
Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
b7229ac to
93a5056
Compare
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
553f38e to
5622107
Compare
This was referenced Apr 18, 2024
eseliger
force-pushed
the
es/04-13-gitserverremoverevspecupdates
branch
from
93a5056 to
15e2615
Compare
After refactoring to use the same locker for both tasks, this no longer only resembles cloneInProgress, so cleaned this up a little. Test plan: Existing test suites.
eseliger
force-pushed
the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
from
5622107 to
7d83bb9
Compare
eseliger
deleted the
es/04-13-gitserverclarifywhatrepositorylockindicates
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring to use the same locker for both tasks, this no longer only resembles cloneInProgress, so cleaned this up a little.
Test plan:
Existing test suites.