This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Extract repository service in gRPC #61807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
05576fd to
314d3a0
Compare
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
6 times, most recently
from
fd71cf5 to
d352fab
Compare
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
d352fab to
d0e7679
Compare
This was referenced Apr 13, 2024
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
d0e7679 to
6f6f001
Compare
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
6f6f001 to
c34062f
Compare
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
2 times, most recently
from
e0d352d to
ef4b95b
Compare
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
ef4b95b to
21c9dbe
Compare
pjlast
approved these changes
Apr 18, 2024
This PR moves the Fetch and Delete operations onto a separate service. With that, we also disallow consumers of the internal/gitserver.Client interface to use these methods. Repo-updaters scheduler has authority over this and it should not be interfered with. If a caller wants to make a scheduling _suggestion_, it will be able to talk to repo-updater. This prepares for a better scheduler that has full control of the operations running. Test plan: E2E and integration tests will verify that repos are still cloned properly.
eseliger
force-pushed
the
es/04-11-gitserverextractrepositoryserviceingrpc
branch
from
21c9dbe to
2ea4046
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Fetch and Delete operations onto a separate service.
With that, we also disallow consumers of the internal/gitserver.Client
interface to use these methods. Repo-updaters scheduler has authority
over this and it should not be interfered with. If a caller wants to make
a scheduling suggestion, it will be able to talk to repo-updater.
This prepares for a better scheduler that has full control of the operations
running.
Test plan:
E2E and integration tests will verify that repos are still cloned properly.