AMDGPU: Switch a test with only function label checks to generated

[arsenm]

I suspect the first function at least is not usefully testing
the original failure.

[arsenm]

• AMDGPU: Switch simplifydemandedbits-recursion.ll to generated checks #131317
• AMDGPU: Switch scheduler-subrange-crash.ll to generated checks #131316
• AMDGPU: Switch test to generated checks #131315
• AMDGPU: Migrate more tests away from undef #131314
• AMDGPU: Migrate some tests away from undef #131277
• AMDGPU: Use generated checks in coalescer_distribute.ll #131276
• AMDGPU: Use generated checks in unchecked test #131275
• AMDGPU: Use generated tests in reg-coalescer-sched-crash.ll test #131259
• AMDGPU: Add generated checks to compile only test #131258
• AMDGPU: Switch a test to generated checks which only tested labels #131257
• AMDGPU: Remove undef in subreg-coalescer-crash.ll #131256
• AMDGPU: Switch a test with only function label checks to generated #131255 👈 (View in Graphite)
• AMDGPU: Replace undef references with poison in some MIR tests #131254
• AMDGPU: Use generated checks in test missing checks #131110
• AMDGPU: Replace some test undef uses with poison #131103
• AMDGPU: Replace more undef test pointer uses with poison #131102
• AMDGPU: Replace test uses of ptr addrspace(5) undef with poison #131101
• AMDGPU: Replace ptr addrspace(4) undef uses with poison in tests #131095
• AMDGPU: Replace some test i32 undef uses with poison #131092 : 1 other dependent PR (#131106 )
• AMDGPU: Replace some float undef test uses with poison #131090
• AMDGPU: Replace i16 undefs with poison in tests #131084
• AMDGPU: Replace half undef uses with poison in tests #131083
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-llvm-globalisel

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

I suspect the first function at least is not usefully testing
the original failure.

---

Full diff: https://github.com/llvm/llvm-project/pull/131255.diff

1 Files Affected:

• (modified) llvm/test/CodeGen/AMDGPU/subreg-coalescer-crash.ll (+32-5)

diff --git a/llvm/test/CodeGen/AMDGPU/subreg-coalescer-crash.ll b/llvm/test/CodeGen/AMDGPU/subreg-coalescer-crash.ll
index 19c43fa22271b..a0ac6c1b28449 100644
--- a/llvm/test/CodeGen/AMDGPU/subreg-coalescer-crash.ll
+++ b/llvm/test/CodeGen/AMDGPU/subreg-coalescer-crash.ll
@@ -1,8 +1,13 @@
-; RUN: llc -mtriple=amdgcn -mcpu=tahiti -verify-machineinstrs -o - %s | FileCheck -check-prefix=GCN %s
-; RUN: llc -mtriple=amdgcn -mcpu=tonga -verify-machineinstrs -o - %s | FileCheck -check-prefix=GCN %s
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc -mtriple=amdgcn -mcpu=tahiti -o - %s | FileCheck -check-prefixes=GCN,GFX6 %s
+; RUN: llc -mtriple=amdgcn -mcpu=tonga -o - %s | FileCheck -check-prefixes=GCN,GFX8 %s
 
-; GCN-LABEL:{{^}}row_filter_C1_D0:
 define amdgpu_kernel void @row_filter_C1_D0() #0 {
+; GCN-LABEL: row_filter_C1_D0:
+; GCN:       ; %bb.0: ; %entry
+; GCN-NEXT:    s_cbranch_scc1 .LBB0_2
+; GCN-NEXT:  ; %bb.1: ; %do.body.preheader
+; GCN-NEXT:  .LBB0_2: ; %for.inc.1
 entry:
   br i1 undef, label %for.inc.1, label %do.body.preheader
 
@@ -40,9 +45,28 @@ for.inc.1:                                        ; preds = %do.body.1562.prehea
   unreachable
 }
 
-; GCN-LABEL: {{^}}foo:
-; GCN: s_endpgm
 define amdgpu_ps void @foo() #0 {
+; GCN-LABEL: foo:
+; GCN:       ; %bb.0: ; %bb
+; GCN-NEXT:    s_mov_b64 s[0:1], -1
+; GCN-NEXT:    s_cbranch_scc0 .LBB1_2
+; GCN-NEXT:  ; %bb.1: ; %bb24
+; GCN-NEXT:    s_mov_b64 s[0:1], 0
+; GCN-NEXT:  .LBB1_2: ; %Flow1
+; GCN-NEXT:    s_and_b64 vcc, exec, s[0:1]
+; GCN-NEXT:    s_cbranch_vccz .LBB1_4
+; GCN-NEXT:  ; %bb.3: ; %bb9
+; GCN-NEXT:    image_sample v[0:1], v0, s[0:7], s[0:3] dmask:0xa
+; GCN-NEXT:    s_branch .LBB1_5
+; GCN-NEXT:  .LBB1_4:
+; GCN-NEXT:    v_mov_b32_e32 v1, 0
+; GCN-NEXT:    v_mov_b32_e32 v0, v1
+; GCN-NEXT:  .LBB1_5: ; %bb14
+; GCN-NEXT:    s_waitcnt vmcnt(0)
+; GCN-NEXT:    v_mul_f32_e32 v0, 0x41280000, v0
+; GCN-NEXT:    v_mul_f32_e32 v1, 0x41380000, v1
+; GCN-NEXT:    exp mrt0 v1, v0, v0, v0 done vm
+; GCN-NEXT:    s_endpgm
 bb:
   br i1 undef, label %bb2, label %bb1
 
@@ -101,3 +125,6 @@ declare <4 x float> @llvm.amdgcn.image.sample.1d.v4f32.f32(i32, float, <8 x i32>
 
 attributes #0 = { nounwind }
 attributes #1 = { nounwind readonly }
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; GFX6: {{.*}}
+; GFX8: {{.*}}

[shiltian]

IMHO, in addition to the manual efforts you’re making now, we should enforce the use of auto-generated check lines whenever possible.

[arsenm]

Merge activity

• Mar 14, 3:38 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Mar 14, 3:46 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 14, 3:48 AM EDT: A user merged this pull request with Graphite.