AMDGPU: Switch test to generated checks

[arsenm]

I doubt this is testing what it originally intended anymore. Also
replace an undef.

[arsenm]

• AMDGPU: Switch simplifydemandedbits-recursion.ll to generated checks #131317
• AMDGPU: Switch scheduler-subrange-crash.ll to generated checks #131316
• AMDGPU: Switch test to generated checks #131315 👈 (View in Graphite)
• AMDGPU: Migrate more tests away from undef #131314
• AMDGPU: Migrate some tests away from undef #131277
• AMDGPU: Use generated checks in coalescer_distribute.ll #131276
• AMDGPU: Use generated checks in unchecked test #131275
• AMDGPU: Use generated tests in reg-coalescer-sched-crash.ll test #131259
• AMDGPU: Add generated checks to compile only test #131258
• AMDGPU: Switch a test to generated checks which only tested labels #131257
• AMDGPU: Remove undef in subreg-coalescer-crash.ll #131256
• AMDGPU: Switch a test with only function label checks to generated #131255
• AMDGPU: Replace undef references with poison in some MIR tests #131254
• AMDGPU: Use generated checks in test missing checks #131110
• AMDGPU: Replace some test undef uses with poison #131103
• AMDGPU: Replace more undef test pointer uses with poison #131102
• AMDGPU: Replace test uses of ptr addrspace(5) undef with poison #131101
• AMDGPU: Replace ptr addrspace(4) undef uses with poison in tests #131095
• AMDGPU: Replace some test i32 undef uses with poison #131092 : 1 other dependent PR (#131106 )
• AMDGPU: Replace some float undef test uses with poison #131090
• AMDGPU: Replace i16 undefs with poison in tests #131084
• AMDGPU: Replace half undef uses with poison in tests #131083
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

I doubt this is testing what it originally intended anymore. Also
replace an undef.

---

Full diff: https://github.com/llvm/llvm-project/pull/131315.diff

1 Files Affected:

• (modified) llvm/test/CodeGen/AMDGPU/subreg-eliminate-dead.ll (+7-4)

diff --git a/llvm/test/CodeGen/AMDGPU/subreg-eliminate-dead.ll b/llvm/test/CodeGen/AMDGPU/subreg-eliminate-dead.ll
index 59ad6f6139ace..2efcb411cf0ee 100644
--- a/llvm/test/CodeGen/AMDGPU/subreg-eliminate-dead.ll
+++ b/llvm/test/CodeGen/AMDGPU/subreg-eliminate-dead.ll
@@ -1,16 +1,19 @@
-; RUN: llc -mtriple=amdgcn-- -verify-machineinstrs -o - %s | FileCheck %s
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc -mtriple=amdgcn-- -mcpu=tahiti < %s | FileCheck %s
 ; LiveRangeEdit::eliminateDeadDef did not update LiveInterval sub ranges
 ; properly.
 
 ; Just make sure this test doesn't crash.
-; CHECK-LABEL: foobar:
-; CHECK: s_endpgm
 define amdgpu_kernel void @foobar() {
+; CHECK-LABEL: foobar:
+; CHECK:       ; %bb.0:
+; CHECK-NEXT:    s_endpgm
   %v0 = icmp eq <4 x i32> poison, <i32 0, i32 1, i32 2, i32 3>
   %v3 = sext <4 x i1> %v0 to <4 x i32>
   %v4 = extractelement <4 x i32> %v3, i32 1
   %v5 = icmp ne i32 %v4, 0
-  %v6 = select i1 %v5, i32 undef, i32 0
+  %undef = freeze i32 poison
+  %v6 = select i1 %v5, i32 %undef, i32 0
   %v15 = insertelement <2 x i32> poison, i32 %v6, i32 1
   store <2 x i32> %v15, ptr addrspace(1) poison, align 8
   ret void

[github-actions]

⚠️ undef deprecator found issues in your code. ⚠️

You can test this locally with the following command:

git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 5679be1b12a79ce1c22d4f588de634ac64a5116b 7b23925faefc723e69bb5afc04a5b2c47fca178b llvm/test/CodeGen/AMDGPU/subreg-eliminate-dead.ll

The following files introduce new uses of undef:

• llvm/test/CodeGen/AMDGPU/subreg-eliminate-dead.ll

Undef is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields undef. You should use poison values for placeholders instead.

In tests, avoid using undef and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:

define void @fn() {
  ...
  br i1 undef, ...
}

Please use the following instead:

define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}

Please refer to the Undefined Behavior Manual for more information.

[arsenm]

Merge activity

• Mar 17, 4:47 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Mar 17, 4:58 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 17, 5:01 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 17, 5:03 AM EDT: A user merged this pull request with Graphite.