AMDGPU: Add generated checks to compile only test #131258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2025
This was referenced Mar 14, 2025
|
@llvm/pr-subscribers-llvm-globalisel @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesAlso replace an undef use Full diff: https://github.com/llvm/llvm-project/pull/131258.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/swdev282079.ll b/llvm/test/CodeGen/AMDGPU/swdev282079.ll
index 184eb4f6f0baa..20eb6ff560979 100644
--- a/llvm/test/CodeGen/AMDGPU/swdev282079.ll
+++ b/llvm/test/CodeGen/AMDGPU/swdev282079.ll
@@ -1,11 +1,35 @@
-; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a < %s
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a < %s | FileCheck %s
define protected amdgpu_kernel void @foo(ptr addrspace(1) %arg, ptr addrspace(1) %arg1) {
+; CHECK-LABEL: foo:
+; CHECK: ; %bb.0: ; %bb
+; CHECK-NEXT: s_add_u32 flat_scratch_lo, s12, s17
+; CHECK-NEXT: s_addc_u32 flat_scratch_hi, s13, 0
+; CHECK-NEXT: s_add_u32 s0, s0, s17
+; CHECK-NEXT: s_addc_u32 s1, s1, 0
+; CHECK-NEXT: s_add_u32 s8, s8, 16
+; CHECK-NEXT: s_addc_u32 s9, s9, 0
+; CHECK-NEXT: s_mov_b32 s13, s15
+; CHECK-NEXT: s_mov_b32 s12, s14
+; CHECK-NEXT: s_getpc_b64 s[18:19]
+; CHECK-NEXT: s_add_u32 s18, s18, eggs@rel32@lo+4
+; CHECK-NEXT: s_addc_u32 s19, s19, eggs@rel32@hi+12
+; CHECK-NEXT: s_mov_b32 s14, s16
+; CHECK-NEXT: v_mov_b32_e32 v31, v0
+; CHECK-NEXT: v_mov_b32_e32 v1, 0
+; CHECK-NEXT: s_mov_b32 s32, 0
+; CHECK-NEXT: s_swappc_b64 s[30:31], s[18:19]
+; CHECK-NEXT: buffer_load_dword v2, off, s[0:3], 0
+; CHECK-NEXT: buffer_load_dword v3, off, s[0:3], 0 offset:4
+; CHECK-NEXT: s_waitcnt vmcnt(0)
+; CHECK-NEXT: flat_store_dwordx2 v[2:3], v[0:1]
+; CHECK-NEXT: s_endpgm
bb:
%tmp = addrspacecast ptr addrspace(5) null to ptr
%tmp2 = call i64 @eggs(ptr poison) #1
%tmp3 = load ptr, ptr %tmp, align 8
- %tmp4 = getelementptr inbounds i64, ptr %tmp3, i64 undef
+ %tmp4 = getelementptr inbounds i64, ptr %tmp3, i64 0
store i64 %tmp2, ptr %tmp4, align 8
ret void
}
|
shiltian
approved these changes
Mar 14, 2025
| @@ -1,11 +1,35 @@ | |||
| ; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a < %s | |||
There was a problem hiding this comment.
what exactly this test is verifying ?
There was a problem hiding this comment.
Don't know, it wasn't properly documented
| bb: | ||
| %tmp = addrspacecast ptr addrspace(5) null to ptr | ||
| %tmp2 = call i64 @eggs(ptr poison) #1 | ||
| %tmp3 = load ptr, ptr %tmp, align 8 | ||
| %tmp4 = getelementptr inbounds i64, ptr %tmp3, i64 undef | ||
| %tmp4 = getelementptr inbounds i64, ptr %tmp3, i64 0 |
There was a problem hiding this comment.
why not poison here ?
There was a problem hiding this comment.
defined results are preferable to undefined results. We only want to replace with poison when it's potentially relevant to the test
pravinjagtap
approved these changes
Mar 14, 2025
arsenm
force-pushed
the
users/arsenm/amdgpu/generate-checks-in-test-swdev282079
branch
from
054d0f3 to
810371b
Compare
arsenm
force-pushed
the
users/arsenm/amdgpu/use-generated-checks-label-only-test
branch
from
568de61 to
77fef8e
Compare
This was referenced Mar 14, 2025
arsenm
force-pushed
the
users/arsenm/amdgpu/use-generated-checks-label-only-test
branch
from
77fef8e to
a5c793b
Compare
Base automatically changed from
users/arsenm/amdgpu/use-generated-checks-label-only-test
to
main
March 14, 2025 07:54
arsenm
force-pushed
the
users/arsenm/amdgpu/generate-checks-in-test-swdev282079
branch
from
810371b to
d527e6f
Compare
Also replace an undef use
arsenm
force-pushed
the
users/arsenm/amdgpu/generate-checks-in-test-swdev282079
branch
from
d527e6f to
69dfaeb
Compare
arsenm
deleted the
users/arsenm/amdgpu/generate-checks-in-test-swdev282079
branch
This was referenced Mar 14, 2025
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
Also replace an undef use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replace an undef use