-
Notifications
You must be signed in to change notification settings - Fork 14.3k
AMDGPU: Use generated checks in unchecked test #131275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arsenm
merged 1 commit into
main
from
users/arsenm/amdgpu/generate-checks-vector-legalizer-divergence
Mar 14, 2025
Merged
AMDGPU: Use generated checks in unchecked test #131275
arsenm
merged 1 commit into
main
from
users/arsenm/amdgpu/generate-checks-vector-legalizer-divergence
Mar 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2025
This was referenced Mar 14, 2025
This was referenced Mar 14, 2025
This was referenced Mar 14, 2025
@llvm/pr-subscribers-llvm-globalisel @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesAlso replace undef uses Full diff: https://github.com/llvm/llvm-project/pull/131275.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/vector-legalizer-divergence.ll b/llvm/test/CodeGen/AMDGPU/vector-legalizer-divergence.ll
index 1daba85ae0122..bb0b661e800c3 100644
--- a/llvm/test/CodeGen/AMDGPU/vector-legalizer-divergence.ll
+++ b/llvm/test/CodeGen/AMDGPU/vector-legalizer-divergence.ll
@@ -1,4 +1,5 @@
-; RUN: llc -mtriple=amdgcn < %s
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc -mtriple=amdgcn < %s | FileCheck %s
; Tests for a bug in SelectionDAG::UpdateNodeOperands exposed by VectorLegalizer
; where divergence information is not updated.
@@ -6,21 +7,37 @@
declare i32 @llvm.amdgcn.workitem.id.x()
define amdgpu_kernel void @spam(ptr addrspace(1) noalias %arg) {
+; CHECK-LABEL: spam:
+; CHECK: ; %bb.0:
+; CHECK-NEXT: s_load_dwordx2 s[0:1], s[4:5], 0x9
+; CHECK-NEXT: v_lshlrev_b32_e32 v4, 3, v0
+; CHECK-NEXT: v_mov_b32_e32 v5, 0
+; CHECK-NEXT: s_mov_b32 s3, 0xf000
+; CHECK-NEXT: s_mov_b32 s2, 0
+; CHECK-NEXT: v_mov_b32_e32 v1, 0x7ff80000
+; CHECK-NEXT: v_mov_b32_e32 v0, v5
+; CHECK-NEXT: s_waitcnt lgkmcnt(0)
+; CHECK-NEXT: buffer_store_dwordx4 v[0:3], v[4:5], s[0:3], 0 addr64 offset:16
+; CHECK-NEXT: s_waitcnt expcnt(0)
+; CHECK-NEXT: v_mov_b32_e32 v2, v5
+; CHECK-NEXT: v_mov_b32_e32 v3, v5
+; CHECK-NEXT: buffer_store_dwordx4 v[0:3], v[4:5], s[0:3], 0 addr64 offset:48
+; CHECK-NEXT: s_endpgm
%tmp = tail call i32 @llvm.amdgcn.workitem.id.x()
%tmp1 = zext i32 %tmp to i64
%tmp2 = getelementptr inbounds double, ptr addrspace(1) %arg, i64 %tmp1
%tmp3 = load double, ptr addrspace(1) %tmp2, align 8
- %tmp4 = fadd double undef, 0.000000e+00
+ %tmp4 = fadd double 0x7FF8000000000000, 0.000000e+00
%tmp5 = insertelement <2 x double> poison, double %tmp4, i64 0
%tmp6 = insertelement <2 x double> %tmp5, double %tmp3, i64 1
%tmp7 = insertelement <2 x double> %tmp6, double 0.000000e+00, i64 1
- %tmp8 = fadd <2 x double> zeroinitializer, undef
+ %tmp8 = fadd <2 x double> zeroinitializer, splat (double 0x7FF8000000000000)
%tmp9 = fadd <2 x double> %tmp7, zeroinitializer
%tmp10 = extractelement <2 x double> %tmp8, i64 0
%tmp11 = getelementptr inbounds double, ptr addrspace(1) %tmp2, i64 2
store double %tmp10, ptr addrspace(1) %tmp11, align 8
%tmp12 = getelementptr inbounds double, ptr addrspace(1) %tmp2, i64 3
- store double undef, ptr addrspace(1) %tmp12, align 8
+ store double poison, ptr addrspace(1) %tmp12, align 8
%tmp13 = extractelement <2 x double> %tmp9, i64 0
%tmp14 = getelementptr inbounds double, ptr addrspace(1) %tmp2, i64 6
store double %tmp13, ptr addrspace(1) %tmp14, align 8
|
494add8
to
1907a9f
Compare
178ebf5
to
54435ee
Compare
1907a9f
to
71c8ed8
Compare
Base automatically changed from
users/arsenm/amdgpu/use-generated-checks-reg-coalescer-sched-crash
to
main
March 14, 2025 09:04
54435ee
to
4dd02c4
Compare
pravinjagtap
approved these changes
Mar 14, 2025
Merge activity
|
13d1b3b
to
c45231e
Compare
Also replace undef uses
c45231e
to
cdfaaf9
Compare
This was referenced Mar 14, 2025
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
Also replace undef uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replace undef uses