Add support for validating passwords against the password policy in auth #7514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add password policy endpoint in auth to allow fetching the password policy for the project/tenant
* Add PasswordPolicy and PasswordValidationStatus public types * Add public types to docs and implement AuthInternal password policy cache * Add schema version mismatch error and tests * Update error code in fetch test and add TODO for schema version handling
* Add password does not meet requirements error and update policy in sign up flow when error is received
* Add validatePassword method with implementation TODO
* Define internal password policy typings
* Define PasswordPolicyImpl * Add PasswordPolicyCustomStrengthOptions internal typing
* Update Auth to use PasswordPolicyImpl for validation * Rename _getPasswordPolicy to _getPasswordPolicyInternal
…tch API proposal (#7456) * Implement validatePassword * Fix allowedNonAlphanumericCharacters typing to match API proposal
… does not meet the backend requirements (#7434) * Update confirmPasswordReset to handle updating the cache upon password requirements error * Refactor existing test cases to clean up code style
…ot meet the backend requirements (#7435) * Update signInWithEmailAndPassword to handle updating password policy cache * Remove await on calls recachePasswordPolicy * Throw errors instead of rejecting promises
…putted to validatePassword (#7471) * Include the character option statuses even when an empty string is inputted
* Update auth demo to include a section for password validation
…7476) * Add enforcementState and forceUpgradeOnSignin to PasswordPolicy type
…icy response (#7485) * Store an empty string if no non-alphanumeric characters are included in the password policy response
…a password (#7487) * Update auth demo with new fields and move validation into auth flow sections
* Use a default minimum password length of 6 when it is undefined in the password policy response as a temporary solution until the backend is updated
* Add password policy integration tests and helper method for generating valid passwords * Update prodbackend tests to include password policy tests * Update README with password policy integration testing instructions
* Update handling of password policy recaching in sign up to not conflict with handling of other errors like missing reCAPTCHA token
🦋 Changeset detectedLatest commit: fbd258c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (381,042 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
ch5zzy
requested review from
markarndt,
kevinthecheung,
lisajian,
prameshj,
renkelvin,
sam-gc,
dwyfrequency and
hsubox76
as code owners
renkelvin
approved these changes
Aug 3, 2023
kevinthecheung
approved these changes
Aug 3, 2023
|
@DellaBitta Can you help review this? Thanks! |
DellaBitta
reviewed
Aug 3, 2023
hsubox76
approved these changes
Aug 7, 2023
DellaBitta
approved these changes
Aug 7, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
validatePasswordmethod that allows developers to validate passwords against the password policy configured for the project or tenant. This method returns a status object,PasswordValidationStatus, that can be used to display the requirements and check whether each was met.