Update test app readme #4595
Merged
Update test app readme #4595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfkellogg
force-pushed
the
fad/in-app-feedback
branch
from
20d6467 to
cdc766d
Compare
tagboola
force-pushed
the
ta/update-test-app-readme
branch
from
e18d41c to
b458857
Compare
Generated by 🚫 Danger |
kaibolay
approved these changes
Jan 25, 2023
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (3e1dcd3) and the base commit (cdc766d) are not available. No macrobenchmark data found for the base commit (cdc766d). Analysis for the CI merge commit (3e1dcd3) can be found at: |
lfkellogg
pushed a commit
that referenced
this pull request
Feb 16, 2023
lfkellogg
added a commit
that referenced
this pull request
Feb 16, 2023
* Revert "Remove In-App Feedback functionality from firebase-appdistribution (#3926)" (#3927) This reverts commit 78d2888. * Add feedback button to app-distribution/test-app (#3924) * Add some more details to firebase-appdistribution/test-app/README.md (#3930) * Rename collectAndSendFeedback to startFeedback (#3932) * Add info text argument to startFeedback (#3971) * Add info text argument to startFeedback * Formatting * Update api.txt * Make infoText CharSequence non null * Minor updates to the App Distribution test app. (#4088) (#4089) * update appcompat (1.3.0 -> 1.5.1) to fix lint (UsingOnClickInXml) which did not work correctly when running with AGP 7.2.2. (#4104) * Fix tests by downgrading AppCompat and fixing lint issue (#4132) * Fix links in FeedbackActivity info text (#4133) * Fix links in FeedbackActivity info text * Add TODO about adding a test for <a> tags in info text * Add a screenshot-based trigger for in-app feedback (#4122) * WIP - Screenshot feedback trigger * Get screenshot trigger working * Some fixes and refactors * Format java * Resolve TODOs in SDK * Update api.txt * Address PR feedback and fix tests * Address Kai's feedback * Request different permission on 33+ and some more feedback * Some fixes to the test app's screenshot detection trigger (#4145) * WIP - Screenshot feedback trigger * Get screenshot trigger working * Some fixes and refactors * Format java * Resolve TODOs in SDK * Update api.txt * Address PR feedback and fix tests * Address Kai's feedback * Request different permission on 33+ and some more feedback * Wait for pending screenshots Co-authored-by: Kai Bolay <[email protected]> * Only allow one feedback flow to be active (#4137) * Only allow one feedback flow to be active * Add tests * Add ShakeForFeedback to test app (#4138) * Add menu to test app for selecting feedback trigger (#4150) * Add menu to test app for selecting feedback trigger * Address Kai's feedback * Hook screenshot trigger to test app menu (#4151) * Reimplement screenshot trigger in Kotlin (#4152) * Rename screenshot trigger file from java to kotlin * Reimplement screenshot trigger in Kotlin * Address Kai's feedback * Fix ApkUpdaterTest flake (#4153) * Make buttons the same size and align them. (#4164) * Implement notification trigger (#4159) * Implement notification trigger. * address Lee's feedback * pick proper icon Co-authored-by: Lee Kellogg <[email protected]> * Change notification importance/priority for notification trigger (#4169) * Fix crash when requesting permissions after changing activities (#4170) * Turn down shake sensitivity (#4173) * Update sign in wording on the SDK (#4168) * Update sign in wording on the SDK * Notifications: Ask permission upfront, show only one persistent notification (#4179) * Simplify requesting permissions: ask for notification permission upfront. * Keep one notification instead of cancelling and showing a new one as Activities pause/resume. * KDoc and misc. cleanup. * Rename `currentActivity` to `activityToScreenshot`. * Fix compiler warnings about checking permissions (#4188) * Update layout of Feedback activity. (#4218) Update layout of Feedback activity. * Notification trigger API (#4183) * Add notification default trigger to in-app feedback * Address Kai's feedback * Update api.txt * Address some feedback * Add InterruptionLevel to notification trigger API (#4205) * Add InterruptionLevel to API * Move interruption and priority levels to InterruptionLevel enum * Mark interruptionLevel as @nonnull * Add @StringRes annotation * fix crash (#4251) * Simplify screenshot trigger example and move to its own activity (#4252) * Clean up shake detection trigger example (#4253) * Remove duplicate trigger class (#4256) * Simplify custom notification trigger example and move to activity (#4255) * Simplify custom notification trigger example and move to activity * Remove synchronized blocks * Some tweaks to the FeedbackActivity (#4273) * Add icon for in-app feedback notifications (#4320) * Fix warning about using flag on API level < 23 (#4321) * Some improvements to firebase-appdistribution/test-app (#4330) * Handle the case where we can't identify the release. (#4331) Use `adb shell setprop debug.firebase.appdistro.devmode true` for development mode. This mode doesn't verify that a release is present and doesn't actually submit feedback - it just demonstrates the UI, * Fix handling of activity destruction based on configuration change (e.g. screen rotation). (#4340) * Fix test and format file. (#4341) * Resolve some changes from the rebase on fad/next * Actually keep asspet ratio of screenshot. (#4342) * Do I/O (reading the screenshot) on separate thread. (#4347) * Do I/O (reading the screenshot) on separate thread. * Use executor * Make FeedbackSender depend on Blocking executor * `./gradlew :firebase-appdistribution:googleJavaFormat` Co-authored-by: Lee Kellogg <[email protected]> * Fix screenshot taking on platforms with hardware bitmaps (#4361) * Fix screenshot taking on platforms with hardware bitmaps * Address Kai's feedback * Suppress lint warning about executors * Fix 'Continuation returned null' error when there is no previous activity (#4377) * Add spinner when sending feedback (#4384) * ./gradlew :firebase-appdistribution:test-app:ktfmtFormat (#4387) * clean up logging (#4465) - make `LogWrapper` static - ensure `TAG` is passed uniformly * prepare for translation (#4467) - Remove unused strings - extract hard-coded strings - add translation_description * Move Kotlin source to `kotlin` directory; add missing copyright notice. (#4476) * Fix errors after rebase on fad/next (#4477) * Fix unit test after rebase on fad/next * Guard reference to previousActivity with lock * Supress lint error about explicit executor in continuation * Migrate some executors in fad/in-app-feedback (#4350) * Migrate executors in fad/in-app-feedback * Add an import and format * Move SharedPreferences usage to background thread (#4480) * Migrate executors in fad/in-app-feedback * Add an import and format * Move SharedPreferences usage to background thread * Address feedback * Fix onSuccessUpdateTask * Clean up ApkUpdater (#4482) * Do not wait to store state when signing out (#4490) * Do not wait to store state when signing out * Remove unnecessary assertions during test setup * Clean up sign in state management (#4491) * Simplify sign in state management * Reword comment * Make isTesterSignedIn more reliable (#4493) * Remove synchronized blocks from ApkInstaller (#4486) * Remove synchronized blocks from ApkInstaller * Fix broken test * Address Kai's feedback * Remove synchronized blocks from ApkUpdater (#4494) * Remove synchronized blocks from ApkUpdater * Fix test failure in CI * Use CountDownLatch instead of Thread.sleep to delay functionality under test * Remove synchronized usage in TaskCache (#4509) * Remove synchronized usage in TaskCache * Re-arrange member declarations and make more consistent * Remove synchronized blocks from NewReleaseFetcher (#4510) * Remove synchronized usage in TaskCache * Re-arrange member declarations and make more consistent * Remove synchronized blocks from NewReleaseFetcher * Improve readability of a test in ApkUpdaterTest (#4518) * Rename CountDownLatch and inline more of the setup to improve readability. * Use a latch for the other usage of awaitProgressEvents() * Refactor awaitProgressEvents into awaitCondition * Some improvements to the task caches (#4519) * Remove synchronized blocks from TesterSignInManager (#4520) * Some improvements to the task caches * Remove synchronized blocks from TesterSignInManager * i18n (#4507) * Translations from n41155-77g2sqbts51e8.zip - retrieved from https://partnerdash.google.com/nalu?utm_source=olp#p=translationprojectpage&selectedTab=0&shortId=n41155 * Move copyright to separate line and update from 2021 to 2022. * The product name "Firebase App-Distribution" should not be translated - at least not to German. * Change escaping of apostrophes from `'` to `\'`. * Remove synchronized blocks from AabUpdater (#4522) * Some final synchronized block cleanup (#4528) * De-flake some tests by waiting for UpdateTasks to complete (#4529) * Focus some synchronized blocks in lifecycle notifier (#4526) * Always call foreground activity callbacks on the UI thread (#4531) * Always call foreground activity callbacks on the UI thread This will make it easier to reason about what runs on what thread. * Refactor getActivityWithIgnoredClass to consolidate synchronized blocks * Migrate executors in NewReleaseFetcher (#4534) * Use explicit executors in more App Distro code (#4535) * Use BufferedOutputStream to prevent StrictMode violations (#4538) * Read file length on background thread to avoid StrictMode violation (#4539) * Request notification permissions in test app (#4541) * Use Dagger in firebase-appdistribution (#4540) * Suppress continuation warnings in UpdateTaskImpl (#4536) * Update infoText javadoc description (#4545) * Allow per-app language preferences to simplify SDK i18n testing. (#4551) * Add unstyled button for uploading a custom screenshot (#4550) * Add unstyled button for uploading a custom screenshot * Bump compileSdkVersion to 31 * Use plain Activity Results API to avoid having to raise compile/target SDK version * Fix resource directory for Chinese (#4572) * Cancel feedback notification if app is in background. (#4571) Use `ScheduleExecutorService` to cancel feedback notification if app is in background. * Remove now-unnecessary lint suppression (#4589) * Some cleanup in App Distro's Dagger usage (#4593) * Update FAD test app readme (#4595) * Add bug to comment about multiple FirebaseApps (#4597) * Style gallery button for uploading custom screenshots (#4598) * Update styling of gallery button * Update button styling and spacing * Update corner radius of card background * Fix typo in FirebaseAppDistributionNotificationManager (#4621) * Pass feedback trigger type to create feedback call (#4631) * Pipe through feedback trigger to API client calls and pass it as a header in call to create feedback * Make FeedbackTrigger package private and add comment * Fix file formatting * Add check before casting interface to impl * Fix formatting of TakeScreenshotAndStartFeedbackActivity.java * Add copyright information to FeedbackTrigger.java * Update FeedbackTrigger and remove instances of valueOf * Fix formatting of java files * Inject FirebaseAppDistributionImpl directly iun TakeScreenshotAndStartFeedbackActivity * Remove FeedbackTrigger dependency from TesterApiHttpClient * Fix formatting * Pass trigger header on commit feedback call (#4632) * Pass trigger header on commit feedback call * Remove unnecessary parenthesis * Store feedback trigger state on screen rotation (#4672) * Changes from API review (#4675) * Update CHANGELOGS * Add App Distro gradle plugin * Address PR feedback - Replace getForegroundActivity(null) with getForegroundActivity() - Use FirebaseExecutors.directExecutor() --------- Co-authored-by: Kai Bolay <[email protected]> Co-authored-by: Tejas Deshpande <[email protected]> Co-authored-by: tagboola <[email protected]>
lfkellogg
added a commit
that referenced
this pull request
Feb 21, 2023
* Minor updates to the App Distribution test app. (#4088) * Update various versions (#4090) * Updated various versions (dependencies and SDK to fix Android resource linking failure (AAPT: error: resource android:attr/lStar not found.) * Update compileSdk/targetSdkVersion from 31 to 33 * Resolve strict mode violations in firebase-appdistribution (#4092) * Remove `release` field. (#4174) * Use shared executors in App Distribution SDK (#4338) * Remove some synchronized blocks from FirebaseAppDistributionImpl (#4353) * Remove some synchronized blocks from FirebaseAppDistributionImpl * Rename UpdateTaskCache.java to TaskCache.java * Add @FunctionalInterface annotation * Reformat a comment * Use sequential executor in place of synchronized blocks for cached new release (#4430) * Remove some synchronized blocks from FirebaseAppDistributionImpl * Rename UpdateTaskCache.java to TaskCache.java * Remove more sync blocks around new release cache * Some refactoring * Java formatting * Add tests * Add javadocs * Simplify SequentialReference and update tests * Update registrar * Fix test and add static imports from TestUtils * Incorporate some feedback * Use actual lightweight executor in test * Remove unused jetbrains annotations dependencies (#4456) * Support multiple progress listeners on an UpdateTask (#4523) * Support multiple progress listeners on an UpdateTask * Remove unnecessary usage * Fix Dex error due to conflicting packages (#4590) * Merge fad/in-app-feedback into fad/next to prepare for release (#4596) * Revert "Remove In-App Feedback functionality from firebase-appdistribution (#3926)" (#3927) This reverts commit 78d2888. * Add feedback button to app-distribution/test-app (#3924) * Add some more details to firebase-appdistribution/test-app/README.md (#3930) * Rename collectAndSendFeedback to startFeedback (#3932) * Add info text argument to startFeedback (#3971) * Add info text argument to startFeedback * Formatting * Update api.txt * Make infoText CharSequence non null * Minor updates to the App Distribution test app. (#4088) (#4089) * update appcompat (1.3.0 -> 1.5.1) to fix lint (UsingOnClickInXml) which did not work correctly when running with AGP 7.2.2. (#4104) * Fix tests by downgrading AppCompat and fixing lint issue (#4132) * Fix links in FeedbackActivity info text (#4133) * Fix links in FeedbackActivity info text * Add TODO about adding a test for <a> tags in info text * Add a screenshot-based trigger for in-app feedback (#4122) * WIP - Screenshot feedback trigger * Get screenshot trigger working * Some fixes and refactors * Format java * Resolve TODOs in SDK * Update api.txt * Address PR feedback and fix tests * Address Kai's feedback * Request different permission on 33+ and some more feedback * Some fixes to the test app's screenshot detection trigger (#4145) * WIP - Screenshot feedback trigger * Get screenshot trigger working * Some fixes and refactors * Format java * Resolve TODOs in SDK * Update api.txt * Address PR feedback and fix tests * Address Kai's feedback * Request different permission on 33+ and some more feedback * Wait for pending screenshots Co-authored-by: Kai Bolay <[email protected]> * Only allow one feedback flow to be active (#4137) * Only allow one feedback flow to be active * Add tests * Add ShakeForFeedback to test app (#4138) * Add menu to test app for selecting feedback trigger (#4150) * Add menu to test app for selecting feedback trigger * Address Kai's feedback * Hook screenshot trigger to test app menu (#4151) * Reimplement screenshot trigger in Kotlin (#4152) * Rename screenshot trigger file from java to kotlin * Reimplement screenshot trigger in Kotlin * Address Kai's feedback * Fix ApkUpdaterTest flake (#4153) * Make buttons the same size and align them. (#4164) * Implement notification trigger (#4159) * Implement notification trigger. * address Lee's feedback * pick proper icon Co-authored-by: Lee Kellogg <[email protected]> * Change notification importance/priority for notification trigger (#4169) * Fix crash when requesting permissions after changing activities (#4170) * Turn down shake sensitivity (#4173) * Update sign in wording on the SDK (#4168) * Update sign in wording on the SDK * Notifications: Ask permission upfront, show only one persistent notification (#4179) * Simplify requesting permissions: ask for notification permission upfront. * Keep one notification instead of cancelling and showing a new one as Activities pause/resume. * KDoc and misc. cleanup. * Rename `currentActivity` to `activityToScreenshot`. * Fix compiler warnings about checking permissions (#4188) * Update layout of Feedback activity. (#4218) Update layout of Feedback activity. * Notification trigger API (#4183) * Add notification default trigger to in-app feedback * Address Kai's feedback * Update api.txt * Address some feedback * Add InterruptionLevel to notification trigger API (#4205) * Add InterruptionLevel to API * Move interruption and priority levels to InterruptionLevel enum * Mark interruptionLevel as @nonnull * Add @StringRes annotation * fix crash (#4251) * Simplify screenshot trigger example and move to its own activity (#4252) * Clean up shake detection trigger example (#4253) * Remove duplicate trigger class (#4256) * Simplify custom notification trigger example and move to activity (#4255) * Simplify custom notification trigger example and move to activity * Remove synchronized blocks * Some tweaks to the FeedbackActivity (#4273) * Add icon for in-app feedback notifications (#4320) * Fix warning about using flag on API level < 23 (#4321) * Some improvements to firebase-appdistribution/test-app (#4330) * Handle the case where we can't identify the release. (#4331) Use `adb shell setprop debug.firebase.appdistro.devmode true` for development mode. This mode doesn't verify that a release is present and doesn't actually submit feedback - it just demonstrates the UI, * Fix handling of activity destruction based on configuration change (e.g. screen rotation). (#4340) * Fix test and format file. (#4341) * Resolve some changes from the rebase on fad/next * Actually keep asspet ratio of screenshot. (#4342) * Do I/O (reading the screenshot) on separate thread. (#4347) * Do I/O (reading the screenshot) on separate thread. * Use executor * Make FeedbackSender depend on Blocking executor * `./gradlew :firebase-appdistribution:googleJavaFormat` Co-authored-by: Lee Kellogg <[email protected]> * Fix screenshot taking on platforms with hardware bitmaps (#4361) * Fix screenshot taking on platforms with hardware bitmaps * Address Kai's feedback * Suppress lint warning about executors * Fix 'Continuation returned null' error when there is no previous activity (#4377) * Add spinner when sending feedback (#4384) * ./gradlew :firebase-appdistribution:test-app:ktfmtFormat (#4387) * clean up logging (#4465) - make `LogWrapper` static - ensure `TAG` is passed uniformly * prepare for translation (#4467) - Remove unused strings - extract hard-coded strings - add translation_description * Move Kotlin source to `kotlin` directory; add missing copyright notice. (#4476) * Fix errors after rebase on fad/next (#4477) * Fix unit test after rebase on fad/next * Guard reference to previousActivity with lock * Supress lint error about explicit executor in continuation * Migrate some executors in fad/in-app-feedback (#4350) * Migrate executors in fad/in-app-feedback * Add an import and format * Move SharedPreferences usage to background thread (#4480) * Migrate executors in fad/in-app-feedback * Add an import and format * Move SharedPreferences usage to background thread * Address feedback * Fix onSuccessUpdateTask * Clean up ApkUpdater (#4482) * Do not wait to store state when signing out (#4490) * Do not wait to store state when signing out * Remove unnecessary assertions during test setup * Clean up sign in state management (#4491) * Simplify sign in state management * Reword comment * Make isTesterSignedIn more reliable (#4493) * Remove synchronized blocks from ApkInstaller (#4486) * Remove synchronized blocks from ApkInstaller * Fix broken test * Address Kai's feedback * Remove synchronized blocks from ApkUpdater (#4494) * Remove synchronized blocks from ApkUpdater * Fix test failure in CI * Use CountDownLatch instead of Thread.sleep to delay functionality under test * Remove synchronized usage in TaskCache (#4509) * Remove synchronized usage in TaskCache * Re-arrange member declarations and make more consistent * Remove synchronized blocks from NewReleaseFetcher (#4510) * Remove synchronized usage in TaskCache * Re-arrange member declarations and make more consistent * Remove synchronized blocks from NewReleaseFetcher * Improve readability of a test in ApkUpdaterTest (#4518) * Rename CountDownLatch and inline more of the setup to improve readability. * Use a latch for the other usage of awaitProgressEvents() * Refactor awaitProgressEvents into awaitCondition * Some improvements to the task caches (#4519) * Remove synchronized blocks from TesterSignInManager (#4520) * Some improvements to the task caches * Remove synchronized blocks from TesterSignInManager * i18n (#4507) * Translations from n41155-77g2sqbts51e8.zip - retrieved from https://partnerdash.google.com/nalu?utm_source=olp#p=translationprojectpage&selectedTab=0&shortId=n41155 * Move copyright to separate line and update from 2021 to 2022. * The product name "Firebase App-Distribution" should not be translated - at least not to German. * Change escaping of apostrophes from `'` to `\'`. * Remove synchronized blocks from AabUpdater (#4522) * Some final synchronized block cleanup (#4528) * De-flake some tests by waiting for UpdateTasks to complete (#4529) * Focus some synchronized blocks in lifecycle notifier (#4526) * Always call foreground activity callbacks on the UI thread (#4531) * Always call foreground activity callbacks on the UI thread This will make it easier to reason about what runs on what thread. * Refactor getActivityWithIgnoredClass to consolidate synchronized blocks * Migrate executors in NewReleaseFetcher (#4534) * Use explicit executors in more App Distro code (#4535) * Use BufferedOutputStream to prevent StrictMode violations (#4538) * Read file length on background thread to avoid StrictMode violation (#4539) * Request notification permissions in test app (#4541) * Use Dagger in firebase-appdistribution (#4540) * Suppress continuation warnings in UpdateTaskImpl (#4536) * Update infoText javadoc description (#4545) * Allow per-app language preferences to simplify SDK i18n testing. (#4551) * Add unstyled button for uploading a custom screenshot (#4550) * Add unstyled button for uploading a custom screenshot * Bump compileSdkVersion to 31 * Use plain Activity Results API to avoid having to raise compile/target SDK version * Fix resource directory for Chinese (#4572) * Cancel feedback notification if app is in background. (#4571) Use `ScheduleExecutorService` to cancel feedback notification if app is in background. * Remove now-unnecessary lint suppression (#4589) * Some cleanup in App Distro's Dagger usage (#4593) * Update FAD test app readme (#4595) * Add bug to comment about multiple FirebaseApps (#4597) * Style gallery button for uploading custom screenshots (#4598) * Update styling of gallery button * Update button styling and spacing * Update corner radius of card background * Fix typo in FirebaseAppDistributionNotificationManager (#4621) * Pass feedback trigger type to create feedback call (#4631) * Pipe through feedback trigger to API client calls and pass it as a header in call to create feedback * Make FeedbackTrigger package private and add comment * Fix file formatting * Add check before casting interface to impl * Fix formatting of TakeScreenshotAndStartFeedbackActivity.java * Add copyright information to FeedbackTrigger.java * Update FeedbackTrigger and remove instances of valueOf * Fix formatting of java files * Inject FirebaseAppDistributionImpl directly iun TakeScreenshotAndStartFeedbackActivity * Remove FeedbackTrigger dependency from TesterApiHttpClient * Fix formatting * Pass trigger header on commit feedback call (#4632) * Pass trigger header on commit feedback call * Remove unnecessary parenthesis * Store feedback trigger state on screen rotation (#4672) * Changes from API review (#4675) * Update CHANGELOGS * Add App Distro gradle plugin * Address PR feedback - Replace getForegroundActivity(null) with getForegroundActivity() - Use FirebaseExecutors.directExecutor() --------- Co-authored-by: Kai Bolay <[email protected]> Co-authored-by: Tejas Deshpande <[email protected]> Co-authored-by: tagboola <[email protected]> * Defend against NPE when feedback trigger param missing (#4689) * Remove ?platform=android from IAF docs link --------- Co-authored-by: Kai Bolay <[email protected]> Co-authored-by: emilypgoogle <[email protected]> Co-authored-by: Tejas Deshpande <[email protected]> Co-authored-by: tagboola <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support build flavors in
test-app.gradleso there is no longer just aappDistributionUploadDebugtask. Instead, there areappDistributionUploadBetaDebugandappDistributionUploadProdDebugdebug tasks.